Re: [Rpm-maint] [rpm-software-management/rpm] rpm-build: %setup and %autosetup crashes on directories with spaces (#1644)

2021-09-29 Thread Panu Matilainen
BTW, there's this 2001 vintage comment in macros.c :sweat_smile: https://github.com/rpm-software-management/rpm/blob/470498bd5a51f8d98ae8e721beea58ef81c19a51/rpmio/macro.c#L830 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub

Re: [Rpm-maint] [rpm-software-management/rpm] rpm-build: %setup and %autosetup crashes on directories with spaces (#1644)

2021-09-29 Thread Panu Matilainen
But okay, indeed quote only really works for macro *arguments*. Somehow, option parameters were never even considered. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/164

Re: [Rpm-maint] [rpm-software-management/rpm] rpm-build: %setup and %autosetup crashes on directories with spaces (#1644)

2021-09-29 Thread Panu Matilainen
> * It uses Unit Separator (ASCII 0x1f) as separator and ignores quotes > > * Non UTF-8 characters are no longer legal in spec files... The unit separators do not end up in the spec, or anywhere else in the package. They only ever exist inside the macro engine. -- You are receiving this becaus

Re: [Rpm-maint] [rpm-software-management/rpm] rpm-build: %setup and %autosetup crashes on directories with spaces (#1644)

2021-09-29 Thread Florian Festi
Skipping over `"\ "` and `"\^t"` in `splitQuoted()` makes `%autosetup -n auto\ foo` work. Still need to figure out what this all breaks. It is also not compatible with `shescape` which uses single quotes. -- You are receiving this because you are subscribed to this thread. Reply to this email d

Re: [Rpm-maint] [rpm-software-management/rpm] rpm-build: %setup and %autosetup crashes on directories with spaces (#1644)

2021-09-29 Thread Florian Festi
OK, to be more clear with this: We currently don't have any (working) means to have spaces in macro parameters (with the exception of built-in macros which are different in all kind of wonderful ways). I wonder if we actually need two ways for doing that. One that is stripped during parsing (as

Re: [Rpm-maint] [rpm-software-management/rpm] rpm-build: %setup and %autosetup crashes on directories with spaces (#1644)

2021-09-29 Thread Florian Festi
Ok, more thorough investigation turns up a few more problems than expected: - Macro parameters are split by ` splitQuoted()` https://github.com/rpm-software-management/rpm/blob/master/rpmio/macro.c#L930 - It uses Unit Separator (ASCII 0x1f) as separator and ignores quotes - Non UTF-8 characters a