Re: [Rpm-maint] [rpm-software-management/rpm] Dynamic Spec generation (#1485)

2022-11-04 Thread Michal Domonkos
@dmnks commented on this pull request. LGTM now, only little nitpicks, see comments. > +layout: default +title: rpm.org - Package Build Process +--- +# Dynamic Spec Generation + +Since rpm 4.19 RPM supports parsing dynamically generated specs. This +allows the build scripts (**%build** or

Re: [Rpm-maint] [rpm-software-management/rpm] Dynamic Spec generation (#1485)

2022-11-04 Thread Florian Festi
OK, fixed the error handling and added a failing test case. Added $RPM_SPECPARTS_DIR to the build scripts and removed the true directory name from the docs. Turns out there is a reason that `parseSpecSection()` returns a `Spec` object: The BUILDARCHITECTURES magic may return a different Spec

Re: [Rpm-maint] [rpm-software-management/rpm] build breaks on libmagic, but it's installed (Issue #2246)

2022-11-04 Thread Panu Matilainen
The log shows the failures are mainly due to missing fakechroot, without which the test-suite shouldn't execute at all. There was test on that but it was broken (doh), fixed since a couple of days ago. -- Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Dynamic Spec generation (#1485)

2022-11-04 Thread Florian Festi
@ffesti pushed 3 commits. a63662e1558a086a850a2da382bd7c5759a1d7ca Split actual parsing of spec into its own function 05e784b9b576aefd88522c88ab06133048c7904d Allow starting new spec parts with PART_EMPTY ab78270fca71149a42fdead2b8dd14a0f2d0898c Add Dynamic Spec generation -- View it on

Re: [Rpm-maint] [rpm-software-management/rpm] test suite failures on Debian Bullseye (Issue #2264)

2022-11-04 Thread Panu Matilainen
Unfortunately find-debuginfo is not available on Debian so any debuginfo-related tests are being skipped, but this is much better than nothing at all. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2264#issuecomment-1303388130 You

Re: [Rpm-maint] [rpm-software-management/rpm] test suite failures on Debian Bullseye (Issue #2264)

2022-11-04 Thread Panu Matilainen
Closed #2264 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2264#event-7740211013 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] test suite failures on Debian Bullseye (Issue #2264)

2022-11-04 Thread Panu Matilainen
Yep, fixed by #2263 now, inspired by looking into the ultimately unrelated test-suite issues you were having. So it was actually a rather useful thing :grin: -- Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Misc testsuite fixes (PR #2263)

2022-11-04 Thread Panu Matilainen
Fixes: #2264 -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2263#issuecomment-1303375125 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing

Re: [Rpm-maint] [rpm-software-management/rpm] Misc testsuite fixes (PR #2263)

2022-11-04 Thread Panu Matilainen
Merged #2263 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2263#event-7740196058 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Misc testsuite fixes (PR #2263)

2022-11-04 Thread Panu Matilainen
@pmatilai pushed 1 commit. ecb6124068187c9e80019e2580014a65c3f02656 Add a Debian based alternative Dockerfile CI for giggles -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2263/files/50b2f9182e93280cae48eb27e67b370980df3be9..ecb6124068187c9e80019e2580014a65c3f02656

Re: [Rpm-maint] [rpm-software-management/rpm] Misc testsuite fixes (PR #2263)

2022-11-04 Thread Panu Matilainen
@pmatilai pushed 1 commit. 50b2f9182e93280cae48eb27e67b370980df3be9 Avoid bashisms in test-suite specs -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2263/files/646bcbdb269b0a3700996c680effdf918633b7d0..50b2f9182e93280cae48eb27e67b370980df3be9 You are receiving this

Re: [Rpm-maint] [rpm-software-management/rpm] rpmtest not built on Debian (Issue #2262)

2022-11-04 Thread Panu Matilainen
It'll be fun to see just how many times I need to run into this before learning to recommend that as the first step :laughing: -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2262#issuecomment-1303291859 You are receiving this because

[Rpm-maint] [rpm-software-management/rpm] test suite failures on Debian Bullseye (Issue #2264)

2022-11-04 Thread Neal H. Walfield
I realize @pmatilai is aware of these, but I wanted to document them. ``` $ git describe rpm-4.17.0-alpha-659-g40d66336a $ make check VERBOSE=1 ... ## --- ## ## rpm 4.18.90 test suite. ## ## --- ## 1: Running tests for malformed OpenPGP packagesok

Re: [Rpm-maint] [rpm-software-management/rpm] rpmtest not built on Debian (Issue #2262)

2022-11-04 Thread Neal H. Walfield
`git reset --hard` plus `git clean -fxd` worked, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2262#issuecomment-1303272499 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] rpmtest not built on Debian (Issue #2262)

2022-11-04 Thread Neal H. Walfield
Closed #2262 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2262#event-7739745611 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] rpmtest not built on Debian (Issue #2262)

2022-11-04 Thread Michal Domonkos
I had similar weird errors when first building a cmake-based snapshot of RPM and it turned out that it was some leftover stuff in my checkout interfering with it. A `make clean` didn't do trick, `git clean -fxd` did. So yup, definitely worth trying that. -- Reply to this email directly or

Re: [Rpm-maint] [rpm-software-management/rpm] rpmtest not built on Debian (Issue #2262)

2022-11-04 Thread Panu Matilainen
Oh, one thing: do you by any chance happen to have autotools-era in-tree build lingering around? Those can throw all sorts of weird curveballs at you - been there. So may be worth testing with a fresh checkout, just to eliminate that possibility. -- Reply to this email directly or view it on

[Rpm-maint] [rpm-software-management/rpm] Misc testsuite fixes (PR #2263)

2022-11-04 Thread Panu Matilainen
You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/2263 -- Commit Summary -- * Avoid buggy (if harmless) bin symlink in test when using /usr prefix * Try to look up utility paths instead of just assuming /usr/bin * Try to

Re: [Rpm-maint] [rpm-software-management/rpm] rpmtest not built on Debian (Issue #2262)

2022-11-04 Thread Neal H. Walfield
Thanks for looking into this and thanks for the advice. FWIW, using the autoconf version all of the OpenPGP-related tests passed on Debian. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2262#issuecomment-1303194782 You are receiving

Re: [Rpm-maint] [rpm-software-management/rpm] rpmtest not built on Debian (Issue #2262)

2022-11-04 Thread Neal H. Walfield
Here's the complete build log: [typescript.txt](https://github.com/rpm-software-management/rpm/files/9936918/typescript.txt) -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2262#issuecomment-1303176964 You are receiving this because

Re: [Rpm-maint] [rpm-software-management/rpm] rpmtest not built on Debian (Issue #2262)

2022-11-04 Thread Neal H. Walfield
I'm on Debian bullseye. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2262#issuecomment-1303170504 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [Rpm-maint] [rpm-software-management/rpm] rpmtest not built on Debian (Issue #2262)

2022-11-04 Thread Panu Matilainen
Any hope of figuring it out would be in the verbose logs. Which Debian version is this? I've been poking around with Debian bullseye and I'm just not able to reproduce, no matter what. -- Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] rpmtest not built on Debian (Issue #2262)

2022-11-04 Thread Neal H. Walfield
I tried and got the exactly same result as above. FWIW, I ran the following: ``` $ mkdir _build $ cd _build $ cmake -DENABLE_PYTHON=OFF .. $ make $ make check ``` -- Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] rpmtest not built on Debian (Issue #2262)

2022-11-04 Thread Panu Matilainen
So based on that log, it somehow just skips the rpmtests generation :flushed: There's not even an error from missing autom4te (from autoconf package), which is what I got when removing autoconf to try and reproduce. Try 'rm -rf'ing the entire _build and start from scratch. So far I'm finding