Re: [Rpm-maint] [rpm-software-management/rpm] package after `rpm --delsign` differs from original, unsigned package (Issue #2382)

2023-02-21 Thread Cory Francis Myers
Thanks for confirming and investigating this, @pmatilai. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2382#issuecomment-1439050756 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] Enhance requires with version information from the build root. (PR #2372)

2023-02-21 Thread Gordon Messmer
> At this point I'd be mostly interested in feedback from other distro folks Are you subscribed to the Fedora devel list? -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2372#issuecomment-1438895451 You are receiving this because you are

Re: [Rpm-maint] [rpm-software-management/rpm] Issue %patchN deprecation warning just once (PR #2388)

2023-02-21 Thread Michal Domonkos
OK, reworked based on: > A simple alternative would be adding a special purpose counter to the spec > struct, and log a message based on that towards the end of parsePrep() where > you can then also log the number of times emitted. This simple solution will unblock the 4.18.1 release. Later, I'

Re: [Rpm-maint] [rpm-software-management/rpm] Issue %patchN deprecation warning just once (PR #2388)

2023-02-21 Thread Michal Domonkos
@dmnks pushed 1 commit. 37c84fae30c7a5a2985e2a50f090a0e5ab8f68c6 Suppress repeated %patchN deprecation warnings -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2388/files/ab7c577f08f3eece2f9d3c48f5cc4c5d39e14693..37c84fae30c7a5a2985e2a50f090a0e5ab8f68c6 You are receiv

Re: [Rpm-maint] [rpm-software-management/rpm] package after `rpm --delsign` differs from original, unsigned package (Issue #2382)

2023-02-21 Thread Panu Matilainen
Didn't test but commit 5c279fb149a44a1bc4d19e11c3c01942732b8486 seems likely, just based on the commit message it probably doesn't consider the --delsign case at all. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2382#issuecomment-14

Re: [Rpm-maint] [rpm-software-management/rpm] package after `rpm --delsign` differs from original, unsigned package (Issue #2382)

2023-02-21 Thread Panu Matilainen
#1326 behavior depends on the architecture of the package vs host used to delete the signature, but there seems to be another bug here, I can easily reproduce with a locally built package: it seems the signature reserved space doesn't get restored to the original value after --delsign. Offhand,

Re: [Rpm-maint] [rpm-software-management/rpm] API improvement to accommodate for RPM CoW (PR#1470) (Discussion #2057)

2023-02-21 Thread Panu Matilainen
> To add to this: Plugins should not get access to content that has not been > verified yet. Regardless of the technical requirements, this is a fine example of what a sane API looks like: it's not about just making X somehow possible, but building the right usage into the API. Often easier sa