Re: [Rpm-maint] [rpm-software-management/rpm] rpmbuild is duplicating OS name in rpm package names when dist tag is in spec file (Discussion #2397)

2023-02-22 Thread Panu Matilainen
> Release: %{release}%{?dist} This is a bad habit. If you want to pre-define the "base" part of the release (or any other similar part) in a macro, use a different name from the tag. Such as "%rel", or whatever. That's not the problem here and doing this wont (currently) break anything, but

[Rpm-maint] [rpm-software-management/rpm] rpmbuild is duplicating OS name in rpm package names when conditional dist tag is in spec file (Discussion #2397)

2023-02-22 Thread RachChoTra
I am new to building rpm packages, and my problem is very similiar to this unix stack exchange: https://unix.stackexchange.com/questions/538458/why-is-my-rpmbuild-dist-fc30-fc30-instead-of-just-fc30 The problem is there's no answer to that question. I am using rpmbuild -ba directly with no

Re: [Rpm-maint] [rpm-software-management/rpm] Issue %patchN deprecation warning just once (PR #2388)

2023-02-22 Thread Michal Domonkos
@dmnks commented on this pull request. > @@ -450,6 +448,20 @@ int parsePrep(rpmSpec spec) } exit: +/* Issue a warning for deprecated %patchN usage */ +int num = spec->numConverted; +if (num) { + const char *msg = + _("%%patchN is deprecated, use %%patch N (or

Re: [Rpm-maint] [rpm-software-management/rpm] Issue %patchN deprecation warning just once (PR #2388)

2023-02-22 Thread Panu Matilainen
@pmatilai commented on this pull request. > @@ -450,6 +448,20 @@ int parsePrep(rpmSpec spec) } exit: +/* Issue a warning for deprecated %patchN usage */ +int num = spec->numConverted; +if (num) { + const char *msg = + _("%%patchN is deprecated, use %%patch N

Re: [Rpm-maint] [rpm-software-management/rpm] Fix couple of --addsign/--delsign regressions (PR #2396)

2023-02-22 Thread Panu Matilainen
@pmatilai pushed 2 commits. 4c7940bcd271e285431d4dbb8ca475f988f3c3ca Fix signature reserved space not restored on --delsign (#2382) f27db9be270188582695d98361c107393dd715d0 Copy original lead on signing instead of recreating -- View it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Fix couple of --addsign/--delsign regressions (PR #2396)

2023-02-22 Thread Panu Matilainen
@pmatilai pushed 2 commits. 20b8dd07b69af7e511785e9a4fc7118368705ccb Fix signature reserved space not restored on --delsign (#2382) 1170bbfd2625f3d087aba492c691ac0df3e4584f Copy original lead on signing instead of recreating -- View it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Fix couple of --addsign/--delsign regressions (PR #2396)

2023-02-22 Thread Panu Matilainen
(false alarm wrt the DONT due to local mistest) -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2396#issuecomment-1439795411 You are receiving this because you are subscribed to this thread. Message ID:

[Rpm-maint] [rpm-software-management/rpm] Fix couple of --addsign/--delsign regressions (PR #2396)

2023-02-22 Thread Panu Matilainen
Fix #1326 and #2382, see commit messages for details. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/2396 -- Commit Summary -- * Fix signature reserved space not restored on --delsign (#2382) * Copy original lead on