Re: [Rpm-maint] [rpm-software-management/rpm] Create content handler plugin hook (PR #2416)

2023-03-07 Thread Richard Phibel
@rphibel pushed 1 commit. 8a7cd8139b759d1711273839a6502333e3c0f914 Create content handler plugin hook -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2416/files/5965d2be5b80eea738b767a5b48c5bff50c87da3..8a7cd8139b759d1711273839a6502333e3c0f914 You are receiving this

Re: [Rpm-maint] [rpm-software-management/rpm] RPM with Copy on Write (PR #2378)

2023-03-07 Thread Colin Walters
I referenced this effort in https://marc.info/?l=linux-fsdevel=167794198604510=2 - my PoV is that the rpm-cow effort makes some sense. I thought a lot though about hard requiring reflinks for ostree though and determined it was not viable. There are too many people that use e.g. ext4. And

Re: [Rpm-maint] [rpm-software-management/rpm] Create content handler plugin hook (PR #2416)

2023-03-07 Thread Richard Phibel
@rphibel pushed 1 commit. 5965d2be5b80eea738b767a5b48c5bff50c87da3 Create content handler plugin hook -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2416/files/82b6cfe2cfdc981cc7fcda4ecd473c8729aa6920..5965d2be5b80eea738b767a5b48c5bff50c87da3 You are receiving this

[Rpm-maint] [rpm-software-management/rpm] Replace rpmTagType_e with a list of defines and an rpmTagType typedef (PR #2417)

2023-03-07 Thread David Cantrell
I ran in to a problem with some versions of clang building rpm where the value of RPM_MASK_TYPE (0x) triggered an overflow error. Per the C standard, the underlying type of the enum is implementation defined. It should be an int unless the values of the enum cannot fit in an int or

Re: [Rpm-maint] [rpm-software-management/rpm] RPM v6 package format, first public draft for commenting (Discussion #2374)

2023-03-07 Thread ニール・ゴンパ
probably not `tar`, but why not `pax`? -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/discussions/2374#discussioncomment-5230414 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] RPM v6 package format, first public draft for commenting (Discussion #2374)

2023-03-07 Thread Stephen Smoogen
So reading through https://github.com/rpm-software-management/rpm/commit/68c7cf80d7b763498d0077daa91f649bc209e7ae the new format is 'stripped cpio' or did I completely misread that patch. [I guess moving to pax or tar would be a bridge too far :scream_cat: ] -- Reply to this email directly or

Re: [Rpm-maint] [rpm-software-management/rpm] Fix ignoring exit code of child scripts in case of EINTR (PR #2398)

2023-03-07 Thread Коренберг Марк
@socketpair commented on this pull request. > @@ -273,8 +273,16 @@ static int runGPG(sigTarget sigt, const char *sigfile) if (pipefd[1]) close(pipefd[1]); -(void) waitpid(pid, , 0); OK -- Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Fix ignoring exit code of child scripts in case of EINTR (PR #2398)

2023-03-07 Thread Коренберг Марк
@socketpair commented on this pull request. > @@ -402,7 +402,19 @@ static int getOutputFrom(ARGV_t argv, reap: /* Collect status from prog */ -reaped = waitpid(child, , 0); + +do { + reaped = waitpid(child, , 0); +} while (reaped == -1 && errno == EINTR); + +//

Re: [Rpm-maint] [rpm-software-management/rpm] Fix ignoring exit code of child scripts in case of EINTR (PR #2398)

2023-03-07 Thread Коренберг Марк
@socketpair pushed 1 commit. 8cb5c6a31a475067d41923b8306f8625dde4a71f Fix ignoring exit code of child scripts in case of EINTR -- View it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] python: Use Py_hash_t instead of long in hdr_hash (PR #2408)

2023-03-07 Thread Khem Raj
> What tooling/versions is giving this error? I don't doubt that Py_hash_t is > the more proper type here, just that I've never seen the compiler complain > about this. clang16+ -- Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] RPM v6 package format, first public draft for commenting (Discussion #2374)

2023-03-07 Thread Daniel Alley
Ah, so to be clear the payload is still a CPIO archive, just with the metadata stripped and stored in a within the RPM header? -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/discussions/2374#discussioncomment-5229948 You are receiving this

Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)

2023-03-07 Thread eaon
Maybe a bit too late of an addition, but since #2396 was merged today (thank you!), I wondered if it could also make it into this release, with it being a fix for a regression and all. It would really help us out, thank you! -- Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] GPG key interpreted as PGP key (Issue #2410)

2023-03-07 Thread Ricky-Tigg
Along with that unconventional issue, the user is probably left with an unknown: _How to determine how or by who the Red Hat GPG/DSA key was imported?_ Could it be me that imported a such package? ``` $ rpm -qa --scripts gpg-pubkey* --qf '%{version}-%{release} %{packager}\n' 5323552a-6112bcdc

Re: [Rpm-maint] [rpm-software-management/rpm] Add x86-64 architecture levels (v2-v4) as architectures (PR #2315)

2023-03-07 Thread Fabian Vogt
> GCC's __builtin_cpu_supports does unfortunately not support all features > needed to detect these levels properly. Looks like since GCC 12.2 it actually can do `__builtin_cpu_supports("x86-64-v3")`:

Re: [Rpm-maint] [rpm-software-management/rpm] Rpm chroot operations use user/group info from the host (#882)

2023-03-07 Thread Daan De Meyer
@pmatilai Is it an option to use `fgetpwent()` and `fgetgrent()` to circumvent glibc's caching? I'm not sure if rpm needs to take into account nsswitch. If it doesn't, using those two functions could be an option. -- Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Fix ignoring exit code of child scripts in case of EINTR (PR #2398)

2023-03-07 Thread Panu Matilainen
@pmatilai commented on this pull request. > @@ -273,8 +273,16 @@ static int runGPG(sigTarget sigt, const char *sigfile) if (pipefd[1]) close(pipefd[1]); -(void) waitpid(pid, , 0); rpmfc lives in a separate library (librpmbuild) which isn't available to librpmsign, but I

Re: [Rpm-maint] [rpm-software-management/rpm] GPG key interpreted as PGP key (Issue #2410)

2023-03-07 Thread Panu Matilainen
Yep, the actual issue here (there *is* one) is that we're calling those keys gpg-anything, when they should be openpgp-pubkey. But renaming would break a lot of 3rd party tooling, and we'd really rather get rid of those entries in the package db to begin with. -- Reply to this email directly

Re: [Rpm-maint] [rpm-software-management/rpm] The bit for LZCNT is in CPUID 0x80000001, not 1 (PR #2412)

2023-03-07 Thread Panu Matilainen
Merged #2412 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2412#event-8685139800 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] The bit for LZCNT is in CPUID 0x80000001, not 1 (PR #2412)

2023-03-07 Thread Panu Matilainen
I'll just take your word on it :see_no_evil: Thanks for the patch! -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2412#issuecomment-1458082079 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] Fix ignoring exit code of child scripts in case of EINTR (PR #2398)

2023-03-07 Thread Panu Matilainen
@pmatilai commented on this pull request. > @@ -402,7 +402,19 @@ static int getOutputFrom(ARGV_t argv, reap: /* Collect status from prog */ -reaped = waitpid(child, , 0); + +do { + reaped = waitpid(child, , 0); +} while (reaped == -1 && errno == EINTR); + +// It's

Re: [Rpm-maint] [rpm-software-management/rpm] package after `rpm --delsign` differs from original, unsigned package (Issue #2382)

2023-03-07 Thread Panu Matilainen
Closed #2382 as completed via be950eabb84a88e5773e096435c37b92e3d47ebb. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2382#event-8685024651 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] rpm --delsign changes the arch element of the lead (#1326)

2023-03-07 Thread Panu Matilainen
Closed #1326 as completed via #2396. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1326#event-8685024394 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [Rpm-maint] [rpm-software-management/rpm] Fix couple of --addsign/--delsign regressions (PR #2396)

2023-03-07 Thread Panu Matilainen
Merged #2396 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2396#event-8685024179 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] python: Use Py_hash_t instead of long in hdr_hash (PR #2408)

2023-03-07 Thread Panu Matilainen
What tooling/versions is giving this error? I don't doubt that Py_hash_t is the more proper type here, just that I've never seen the compiler complain about this. -- Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] python: Use Py_hash_t instead of long in hdr_hash (PR #2409)

2023-03-07 Thread Panu Matilainen
Closed #2409. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2409#event-8684890900 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] python: Use Py_hash_t instead of long in hdr_hash (PR #2409)

2023-03-07 Thread Panu Matilainen
Thanks for the backport, but we generally only accept PR's on master branch, backports are cherry-picked at the time of release-creation. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2409#issuecomment-1458038219 You are receiving this

Re: [Rpm-maint] [rpm-software-management/rpm] Drop support for rpm v3 packages (#1107)

2023-03-07 Thread Panu Matilainen
There are multiple differences between v3 and v4 packages on the "metadata" level, but perhaps the single most important thing is v4 having immutable header regions. Related to that, v4 has header-only digests and signatures whereas v3 digests and signatures are always on header+payload. The

[Rpm-maint] [rpm-software-management/rpm] Create content handler plugin hook (PR #2416)

2023-03-07 Thread Richard Phibel
### Description This change creates a new `content_handler` plugin hook. This hook can be used by plugins to claim responsability for the package payload. The plugin will then be responsible for: - reading the payload - verifying it - installing the files The main motivation for this change is

[Rpm-maint] [rpm-software-management/rpm] Generate user/group provides from systemd sysusers files (Issue #2415)

2023-03-07 Thread Panu Matilainen
@lnussel mentioned in https://github.com/rpm-software-management/rpm/discussions/2277#discussioncomment-4145964 that openSUSE already generates user and group provides from systemd-sysusers files. This should be upstreamed. -- Reply to this email directly or view it on GitHub: