Technically it's not much of an issue, our alphas have traditionally been
versioned (both the tarball and project version) x.y-1.90 anyway. So 90 means
alpha already, 91 can just as well mean beta. Rc is a "problem" because you'd
really want to have it at the final number already, but clearly th
So cmake allows -rcN for itself, but not for projects created by it. Eh...
``
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2477#issuecomment-1504696693
You are receiving this because you are subscribed to this thread.
Message ID: _
@nwalfield commented on this pull request.
> @@ -1120,6 +1120,12 @@ int pgpPrtParamsSubkeys(const uint8_t *pkts, size_t
> pktlen,
return rc;
}
+rpmRC pgpVerifySignature2(pgpDigParams key, pgpDigParams sig, DIGEST_CTX
hashctx, char **error_msg)
+{
+*error_msg = NULL;
Fixed. FWIW,
@nwalfield pushed 1 commit.
5498d2b2b84b66d36978aa6cdeccdc543d2d46e8 Add pgpVerifySignature2
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2453/files/31c80686ce6a9a0d5f4fded1400328f0c2f368d6..5498d2b2b84b66d36978aa6cdeccdc543d2d46e8
You are receiving this because you
@nwalfield commented on this pull request.
> @@ -276,7 +276,18 @@ rpmRC rpmKeyringVerifySig(rpmKeyring keyring,
> pgpDigParams sig, DIGEST_CTX ctx)
pgpkey = key->pgpkey;
/* We call verify even if key not found for a signature sanity check */
- rc = pgpVerifySignature
@nwalfield pushed 171 commits.
84cda9af2ed7bb35bc54babac579cf061913769a Add bunch of deprecation/obsoletion
warnings to python bindings
baeb71141744bb0db6bd72c580bfaf929b7b4fb2 Disarm python binding signal handling
methods
fab9eb143c8cc521ba8ee4709a647a2fd4289c43 Add proper deprecation warnin
Crap... Of course it doesn't work, `CMAKE_VERSION` is for the CMake version,
not the project's version :facepalm:
The correct docs are here:
https://cmake.org/cmake/help/latest/command/project.html#options
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-ma
OK, re-reading the docs, our original format *actually* should be legal, the
`-rc` is there just as an example of how CMake itself does it. Yet, none of
that seems to be working for me... I also tried putting the whole string in
quotes but no dice.
--
Reply to this email directly or view it on
Lastly, according to the
[docs](https://cmake.org/cmake/help/v3.18/variable/CMAKE_VERSION.html), the
following should also be valid:
`4.18.20231104-alpha1`
However, that doesn't work for me for some reason (CMake 3.26 here).
--
Reply to this email directly or view it on GitHub:
https://github.c
... or just keep `4.18.90` and increment the fourth component for each
pre-release, regardless of whether it's an alpha, beta or rc.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2477#issuecomment-1503586306
You are receiving this bec
Maybe we could just keep the `4.18.90` version for these pre-releases, or
perhaps something like `4.18.90.1` for alpha1, `4.18.90.2` for alpha2, etc.
then `4.18.91` for beta1, etc.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2477#i
It seems like our original pre-release numbering, e.g. `4.19.0-alpha1`, isn't
compatible with the format of `CMAKE_VERSION`, which only allows integers in
the version components, and optionally takes the `-rc` suffix.
Possibly related: https://gitlab.kitware.com/cmake/cmake/-/issues/16716
We ne
Merged #2476 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2476#event-8973287280
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint maili
Closed #2474 as completed via #2476.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2474#event-8973287573
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rp
Oh, right. Those FULL vs non-FULL paths throw some weird curveballs at you...
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2476#issuecomment-1503269551
You are receiving this because you are subscribed to this thread.
Message ID: _
which was accidentially dropped when converting to cmake
Use CMAKE_INSTALL_FULL_SYSCONFDIR as it expands to /etc instead of /usr/etc
Resolves: #2474
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/2476
-- Commit Summary --
Merged #2475 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2475#event-8972190978
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint maili
Actually the PR does have documentation for the tunables it adds, to the point
of any of the related stuff is documented - in the main macros file. That's no
place for proper documentation, but we're not going to stop the alpha release
to write a book about rpm build macros.
Punt the task till
@dmnks pushed 1 commit.
1fdb30946c4f6c1b6d3ca5b66ab3e72dc88ed587 Handle IMA as an imported target,
take II
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2475/files/7797193e0ab320f70b359a984c3a81f5b5818661..1fdb30946c4f6c1b6d3ca5b66ab3e72dc88ed587
You are receiving t
Another attempt at commit 7184fb80137363e39d79e2b5a0eb2c4fb060cc2e.
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/2475
-- Commit Summary --
* Handle IMA as an imported target, take II
-- File Changes --
M CMakeLists.
Closed #2246 as completed via #2468.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2246#event-8971923063
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rp
Merged #2468 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2468#event-8971922783
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint maili
Quite annoying to have pkg-config on this and then lose it
:smiling_face_with_tear:
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2468#issuecomment-1503068299
You are receiving this because you are subscribed to this thread.
Message I
it should go to /etc/dbus-1/system.d/org.rpm.conf to make the dbus announce
plugin work.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2474
You are receiving this because you are subscribed to this thread.
Message ID: ___
Closed #2465 as completed via #2467.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2465#event-8971811984
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rp
Merged #2467 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2467#event-8971811705
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint maili
Okay, looks like we're done here.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2467#issuecomment-1503049183
You are receiving this because you are subscribed to this thread.
Message ID: ___
R
@dmnks pushed 1 commit.
53bf68a3c6f54164ef330953ab5066e4b97c8f8e Don't rely on pkg-config for libmagic
just yet
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2468/files/ebf33aaee5e02020b6d48485e58653e91ce1a3e3..53bf68a3c6f54164ef330953ab5066e4b97c8f8e
You are receiv
OK, imported target it is, and using REQUIRED now that we're on 3.18 :smile:
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2468#issuecomment-1503040475
You are receiving this because you are subscribed to this thread.
Message ID: _
@dmnks pushed 1 commit.
ebf33aaee5e02020b6d48485e58653e91ce1a3e3 Don't rely on pkg-config for libmagic
just yet
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2468/files/94e2a6628918fbd5cb30addf1d4b967743810423..ebf33aaee5e02020b6d48485e58653e91ce1a3e3
You are receiv
OK, ran this locally myself and seems to be working as expected, well done
:smile:
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2467#issuecomment-1502915732
You are receiving this because you are subscribed to this thread.
Message ID
Indeed :+1:
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2467#issuecomment-1502914674
You are receiving this because you are subscribed to this thread.
Message ID: ___
Rpm-maint mailing list
I actually considered that (copy as a form of compilation) but it doesn't make
it any simpler, more to the contrary.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2467#issuecomment-1502899015
You are receiving this because you are subsc
@pmatilai commented on this pull request.
> if (EXISTS ${PANDOC})
add_custom_command(OUTPUT ${man} COMMAND ${PANDOC}
${CMAKE_CURRENT_SOURCE_DIR}/${man}.md
-s -t man -o ${man} DEPENDS ${man}.md)
-
@pmatilai pushed 1 commit.
542fae3c0e8d06e93f9cb5ef3feb8fcb3b628cc2 Include pre-built API docs and man
pages in dist tarballs
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2467/files/b57d7ff273acdc2282ea38867417821227899a82..542fae3c0e8d06e93f9cb5ef3feb8fcb3b628cc2
Thinking about it more, there really is no point in copying the docs to the
builddir in the case of a tarball-based build, so please disregard my above
comments :smile:
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2467#issuecomment-1
... which may be intentional, though, as they're only meant to be copied to
destdir when installing, I suppose (?) (which they are)
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2467#issuecomment-1502857495
You are receiving this becaus
It seems like the man pages aren't copied to the build directory when building
from a dist tarball and not having pandoc installed. (The html files are,
though.)
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2467#issuecomment-150285339
@dmnks commented on this pull request.
> if (EXISTS ${PANDOC})
add_custom_command(OUTPUT ${man} COMMAND ${PANDOC}
${CMAKE_CURRENT_SOURCE_DIR}/${man}.md
-s -t man -o ${man} DEPENDS ${man}.md)
- ins
39 matches
Mail list logo
