[Rpm-maint] [rpm-software-management/rpm] rpmbuild -b prints "RPM build warnings:" to stdout but the warnings to stderr (Issue #2494)

2023-04-20 Thread Jens Petersen
If I run `rpmbuild -bs ...` and have some warnings from my spec file then it ends with `RPM build warnings:` on stdout and then the warnings in stderr, which seems wrong to me: should both go to stderr? ``` $ rpmbuild -bs myspec.spec warning: %patchN is deprecated (1 usages found), use %patch

Re: [Rpm-maint] [rpm-software-management/rpm] Don't rely on pkg-config for Lua (PR #2469)

2023-04-20 Thread Panu Matilainen
> Have we tried advocating to Lua upstream to include a pkgconfig file > recently? If not, maybe that's worth doing, and then we can keep relying on > pkgconfig. Feel free. -- Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Don't rely on pkg-config for Lua (PR #2469)

2023-04-20 Thread Michal Domonkos
Yup, we may suggest that upstream. In the interim, until/if that's implemented on their side, let's just go with the custom imported target as mentioned above. I'll update this PR accordingly. -- Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Improve linting for signature packet processing (Issue #2483)

2023-04-20 Thread Panu Matilainen
Closed #2483 as completed via #2493. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2483#event-9056131968 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [Rpm-maint] [rpm-software-management/rpm] Add pgpVerifySignature2() and pgpPrtParams2() (PR #2493)

2023-04-20 Thread Panu Matilainen
Merged #2493 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2493#event-9056131787 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Add pgpVerifySignature2 (PR #2453)

2023-04-20 Thread Panu Matilainen
Closed #2453. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2453#event-9055930109 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Add pgpVerifySignature2 (PR #2453)

2023-04-20 Thread Panu Matilainen
Thanks for the initial work! -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2453#issuecomment-1516112220 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [Rpm-maint] [rpm-software-management/rpm] Add pgpVerifySignature2 (PR #2453)

2023-04-20 Thread Panu Matilainen
I took this, adjusted the tests to match + fixed some minor issues such as indentation, missing prototype for pgpPrtParams2(), added temporary tweak to pull the new rpm-sequoia from updates-testing and merged it into one commit (separate commits didn't seem particularly beneficial): #2493 --

[Rpm-maint] [rpm-software-management/rpm] Add pgpVerifySignature2() and pgpPrtParams2() (PR #2493)

2023-04-20 Thread Panu Matilainen
Add new functions pgpVerifySignature2() and pgpPrtParams2(), which are like their earlier versions, but optionally return descriptive error messages (in the case of failure) or lints (in the case of success). Adjust tests accordingly. This requires rpm-sequoia 1.4 or later. See

Re: [Rpm-maint] [rpm-software-management/rpm] If I reuse the same rpmtd for multiple headerGet() or rpmtdGetString() calls, would this cause a memory leak? (Discussion #2492)

2023-04-20 Thread Panu Matilainen
It's okay to reuse the same struct rpmtd_s for multiple calls, BUT each headerGet() needs to be paired with a rpmtdFreeData(), otherwise it will leak memory. The worse problem in the above is that string pointers you get this way turn to garbage on rpmdbNextIterator() - it will not matter for