@pmatilai commented on this pull request.
> RPM_CONFIGDIR=${RPMTEST}/@RPM_CONFIGDIR@
-export RPMTEST HOME RPM_CONFIGDIR
+export RPMTEST RPM_CONFIGDIR
Not overriding $HOME is the kind of change that makes this :sheep: very nervous
as long as we're running outside a
@pmatilai commented on this pull request.
> @@ -27,7 +29,7 @@ else
exit
fi
-RPMTEST="@CMAKE_CURRENT_BINARY_DIR@/testing"
+RPMTEST=$RPMTREE
That said, the quoting is likely inconsistent to begin with, this just caught
my eye as the previous assignment had them.
--
Reply to this email
@pmatilai commented on this pull request.
> @@ -27,7 +29,7 @@ else
exit
fi
-RPMTEST="@CMAKE_CURRENT_BINARY_DIR@/testing"
+RPMTEST=$RPMTREE
This is missing quotes, which might matter in some exotic cases.
--
Reply to this email directly or view it on GitHub:
This is the final batch before #2559.
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/2568
-- Commit Summary --
* Add sandbox exec command
* Remove needless HOME override in tests
* Add RPMTREE variable to tests
*
Just FTR, I have a
[simplified](https://github.com/dmnks/rpm/tree/iss1580-wip-simpler) version of
this branch prepared and now
[rebasing](https://github.com/dmnks/rpm/tree/iss1580-wip-v2) it. I'll push it
here when it's ready.
--
Reply to this email directly or view it on GitHub:
Merged #2567 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2567#event-9741800656
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint
Oops, a last-minute edit brought back lookup for cxx. Fixup.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2567#issuecomment-1623373527
You are receiving this because you are subscribed to this thread.
Message ID:
@pmatilai pushed 1 commit.
3d61194a95fda6e0cb73a356413e4dfee661e712 Sanitize the helper tool search path
in cmake
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2567/files/d725b43ed95bf2451aa9793f37678171e4754d8a..3d61194a95fda6e0cb73a356413e4dfee661e712
You are
OK, I'll try it out later and if it helps, we can revert it I guess.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2559#issuecomment-1623348746
You are receiving this because you are subscribed to this thread.
Message ID:
#2567 should remove the need for the "prevent __cc leak" patch.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2559#issuecomment-1623337773
You are receiving this because you are subscribed to this thread.
Message ID:
By default cmake uses $PATH, which seems reasonable and even obvious until you
start seeing things like /usr/lib64/ccache/cc in the macros file.
Have cmake use a sanitized path (the usual bins) by default and allow
augmenting via MYPATH environment variable again (another thing temporarily
Oh, sorry. I remember seeing this but it's fallen through the cracks.
The warning was an artifact of a hack in the rpm level, fixed in commit
a9bae82f699a9b112c8802eebe5da9fff5a8f34b. Rpm never warns on unused automatic
macros such as %1, but in 4.16 the %1 passed to the parametric macro was
No idea?
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/discussions/2501#discussioncomment-6371154
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint
Fair point, I'll move that stuff out.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2559#issuecomment-1623144334
You are receiving this because you are subscribed to this thread.
Message ID:
BTW, track the "nice to have" stuff elsewhere. This is a flagday change for the
test-suite and as such, we want to get it over and done with ASAP and block any
PR's that add tests in the meanwhile. Anything that isn't strictly needed can
wait until the dust is settled.
--
Reply to this email
The README.md has this link.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2566
You are receiving this because you are subscribed to this thread.
Message ID: ___
Rpm-maint mailing list
Merged #2565 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2565#event-9739728824
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint
17 matches
Mail list logo
