Re: [Rpm-maint] [rpm-software-management/rpm] Increment build date every release (PR #2677)

2023-09-25 Thread Jan Zerebecki
Closed #2677. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2677#event-10462916706 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm

Re: [Rpm-maint] [rpm-software-management/rpm] Increment build date every release (PR #2677)

2023-09-25 Thread Jan Zerebecki
There is also an error in this as OBS increases the second number of release, like 1.2 -> 1.3 . Will implement in obs-build instead. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2677#issuecomment-1733740158 You are receiving this beca

Re: [Rpm-maint] [rpm-software-management/rpm] Increment build date every release (PR #2677)

2023-09-25 Thread ニール・ゴンパ
The changelog bumps for every build, even no-change rebuilds. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2677#issuecomment-1733638621 You are receiving this because you are subscribed to this thread. Message ID: _

Re: [Rpm-maint] [rpm-software-management/rpm] Increment build date every release (PR #2677)

2023-09-25 Thread ニール・ゴンパ
Never. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2677#issuecomment-1733637577 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-m

Re: [Rpm-maint] [rpm-software-management/rpm] Increment build date every release (PR #2677)

2023-09-25 Thread Jan Zerebecki
Are rebuilds with changed dependencies but unchanged source never done for Fedora? -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2677#issuecomment-1733634320 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] Random failure on dependency generation 3 test (Issue #2470)

2023-09-25 Thread Michal Domonkos
Oh, gotcha. Yep, in that case, Ubuntu can be eliminated for sure now :smile: Whether or not I was running the tests through podman + bwrap or just bwrap is another matter but Ubuntu was *not* involved at all, yup :smile: -- Reply to this email directly or view it on GitHub: https://github.com/

Re: [Rpm-maint] [rpm-software-management/rpm] Fix tagtbl.C placement in build dir (PR #2670)

2023-09-25 Thread Michal Domonkos
We actually [include](https://github.com/rpm-software-management/rpm/blob/58021924994db8949247cf99883695ce12e4d73b/CMakeLists.txt#L371) the top-level build directory in the top-level CMakeLists file, it even says `# generated sources` in a comment. So that could've been the impulse for you to o

Re: [Rpm-maint] [rpm-software-management/rpm] Random failure on dependency generation 3 test (Issue #2470)

2023-09-25 Thread Panu Matilainen
It was originally spotted with fakechroot and Semaphore of course, but that was still a Fedora container running on top of Ubuntu. Getting it locally eliminates Ubuntu from the picture (unless you've switched to the dark side :laughing: ) but we now have continers locally too. Okay there was 'ma

Re: [Rpm-maint] [rpm-software-management/rpm] Fix tagtbl.C placement in build dir (PR #2670)

2023-09-25 Thread Panu Matilainen
Oh. So I'm misremembering something else related to tagtbl.C from the early days then. I wonder wtf I changed it in https://github.com/rpm-software-management/rpm/commit/1c98b67911e19a5f92c7fa4492aaa1000a06edad for, doesn't seem to make any sense at all :flushed: -- Reply to this email direct

Re: [Rpm-maint] [rpm-software-management/rpm] RPM signature verification for files from installed packages (Issue #2671)

2023-09-25 Thread Panu Matilainen
Yeah both the documentation and the integration with the rest of rpm for that major feature is tragically inadequate. The technical side of the format change was covered in https://rpm-software-management.github.io/rpm/manual/hregions.html back then, but there's never been any UI to this featur

Re: [Rpm-maint] [rpm-software-management/rpm] Random failure on dependency generation 3 test (Issue #2470)

2023-09-25 Thread Michal Domonkos
Wasn't the first encounter with the fakechroot backend and in the Semaphore CI though? Anyway, I *think* this last one I saw was actually on the "native" backend that uses bwrap (but I'm not entirely sure as I'm currently tweaking all this as part of #2643 :smile: ) -- Reply to this email dir

Re: [Rpm-maint] [rpm-software-management/rpm] Python tests: Close open files (PR #2675)

2023-09-25 Thread Florian Festi
Over are the good old days when one could rely on the garbage collection to just close the files for you. Had to do something very similar recently in my own Python project. Thanks for the patch! -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/r

Re: [Rpm-maint] [rpm-software-management/rpm] Python tests: Close open files (PR #2675)

2023-09-25 Thread Florian Festi
Merged #2675 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2675#event-10460704680 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mail

Re: [Rpm-maint] [rpm-software-management/rpm] Fix tagtbl.C placement in build dir (PR #2670)

2023-09-25 Thread Michal Domonkos
Heh, sure :smile: Actually, the output location was only changed in the recent commit 1c98b67911e19a5f92c7fa4492aaa1000a06edad so it was more like just a forgotten entry in `target_include_directories(librpm PRIVATE ...)` where it didn't include the current build dir. So this commit was basica

Re: [Rpm-maint] [rpm-software-management/rpm] Random failure on dependency generation 3 test (Issue #2470)

2023-09-25 Thread Panu Matilainen
I have a feeling there's a connection between our first local instance of this failure and switching over to containers. Which backend was it on? -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2470#issuecomment-1733379875 You are recei

Re: [Rpm-maint] [rpm-software-management/rpm] Fix tagtbl.C placement in build dir (PR #2670)

2023-09-25 Thread Panu Matilainen
Ooh, good spotting! I remember there was some "reason" for doing it the way it was, but this would've been added during the first weeks of stumbling in the dark with cmake. So it probably was due to some other mistake, misunderstanding or such. -- Reply to this email directly or view it on Git

Re: [Rpm-maint] [rpm-software-management/rpm] RPM signature verification for files from installed packages (Issue #2671)

2023-09-25 Thread Artem S. Tashkinov
Wow, there's a ton of things I've never known about even though I've been an avid user of `rpm -V`. Thank you very much for the information! I've just double checked `man rpm` and nothing that you've written is there, so please forgive me for this intrusion. @pmatilai My final question is wha

Re: [Rpm-maint] [rpm-software-management/rpm] RPM signature verification for files from installed packages (Issue #2671)

2023-09-25 Thread Panu Matilainen
Closed #2671 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2671#event-10458820245 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint m

Re: [Rpm-maint] [rpm-software-management/rpm] RPM signature verification for files from installed packages (Issue #2671)

2023-09-25 Thread Panu Matilainen
> This results in an ability to verify the integrity of the installed files and > whether they have been tampered with because it's relatively easy to modify > `rpmdb.sqlite` to make it look like files on the disk are pristine and the > system is running normally without any malware, etc. I don