Re: [Rpm-maint] [rpm-software-management/rpm] perl.req: make heredoc block matching more generic (PR #2813)

2023-12-12 Thread Jan Palus
It was motivated by `ddclient`: * `return <<`: https://github.com/ddclient/ddclient/blob/e0611ab192d6b8d3d2b09d6868d063ca5591ad02/ddclient.in#L7200-L7223 * `fun(<<)` (although this particular example is not handled by this PR due to string literal preceding `<<`):

[Rpm-maint] [rpm-software-management/rpm] perl.req: make heredoc block matching more generic (PR #2813)

2023-12-12 Thread Jan Palus
match any MARKER providing: - it is not in comment (not preceded by #) - it cant be string literal (not preceded by or ) - as a sanity check it must be preceded by either whitespace, comma or equals sign adds support for return EOS; fun(arg, EOS); You can view, comment on, or merge

[Rpm-maint] [rpm-software-management/rpm] Portability fixes (PR #2812)

2023-12-12 Thread Panu Matilainen
Should fix couple of items brought up in #2807 You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/2812 -- Commit Summary -- * Fix hard dependency on libelf (cmake transition fallout) * Fix hard dependency on strchrnul() GNU

Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.19.1 released! (Discussion #2810)

2023-12-12 Thread Michal Domonkos
A note on the changelog: The categories are a bit arbitrary at this moment as this is the first release with an automatically generated changelog. We're going to tweak it a bit more and update it here later. -- Reply to this email directly or view it on GitHub:

[Rpm-maint] [rpm-software-management/rpm] Don't install README.md from docs/ (Issue #2811)

2023-12-12 Thread Michal Domonkos
This file (added in commit e0dd875175cf08a1bc11b8ac63badd5d8ff08a93) actually shouldn't be installed on `make install`. It ends up alongside the `README` file from this repo's top-level directory, in `%{_defaultdocdir}` which is just confusing and unnecessary. -- Reply to this email directly

Re: [Rpm-maint] [rpm-software-management/rpm] Is there a way to determine if a package is provided by OS repos or custom built? (Discussion #2808)

2023-12-12 Thread Panu Matilainen
The package signature is the strongest indicator of origin there is. Otherwise it gets very very gray: if you download a package from a repo and then install locally, the connection to the repo was lost. Or, if you copy a package from one repo to another, the package does not change but the

Re: [Rpm-maint] [rpm-software-management/rpm] Is there a way to determine if a package is provided by OS repos or custom built? (Discussion #2808)

2023-12-12 Thread Vít Ondruch
> Thanks for the repsonse. This doesn't work in Fedora-39. > > ``` > $ > ➜ $ dnf info rpm --disablerepo=* | grep repository > $ > ``` I was testing on Rawhide with DNF5. With DNF4, the output might be a bit different, but I believe that `dnf info rpm` still works. > > > I'd say this is out of

Re: [Rpm-maint] [rpm-software-management/rpm] File conflicts: Symlinked directories -> same file replaced by real directories -> unique files (#1458)

2023-12-12 Thread Panu Matilainen
Those releases are something like ten years out of support by now. If you need it, the patch is out there if you need it. That's open-source power for you. Now, this issue here is about a very specific case regarding the symlink detection logic in rpm, that actually has zero to do with the old

Re: [Rpm-maint] [rpm-software-management/rpm] Is there a way to determine if a package is provided by OS repos or custom built? (Discussion #2808)

2023-12-12 Thread Shreenidhi Shedi
Thanks for the repsonse. This doesn't work in Fedora-39. ``` $ ➜ $ dnf info rpm --disablerepo=* | grep repository $ ``` > I'd say this is out of scope for RPM Why do you believe so? It should be possible to have some kind of metadata to indicate that the rpm is provided by OS. Not a mandatory

[Rpm-maint] [rpm-software-management/rpm] RPM 4.19.1 released! (Discussion #2810)

2023-12-12 Thread Michal Domonkos
This is the first update to the 4.19 series, mostly addressing bugs and regressions, with a few small improvements added on top. The changelog follows: Regression fixes * Never use current user info or file ownership during build

[Rpm-maint] RPM 4.19.1 released!

2023-12-12 Thread Michal Domonkos
This is the first update to the 4.19 series, mostly addressing bugs and regressions, with a few small improvements added on top. The changelog follows: Regression fixes * Never use current user info or file ownership during build (#2797) Command line * Print full path if file removal

Re: [Rpm-maint] [rpm-software-management/rpm] File conflicts: Symlinked directories -> same file replaced by real directories -> unique files (#1458)

2023-12-12 Thread ニール・ゴンパ
But you shipped it and then unshipped it, so now you can't even do mock or chroot builds of those releases. If handling stuff like this is properly fixed in RPM, there's no reason to not have some way to emit those `rpmlib()` capabilities either. -- Reply to this email directly or view it on

Re: [Rpm-maint] [rpm-software-management/rpm] 4.20 unbuildable on macOS due to Linux-specific extensions (Issue #2807)

2023-12-12 Thread Panu Matilainen
If rpm *depends* on a non-POSIX extension then it generally is a bug. Such cases just need to be tracked independently, but in brief: - rpm-sort was ported from elsewhere and I guess strchrnul() use went unnoticed in review. It needs needs to be fixed not to use that, and in the meanwhile not

Re: [Rpm-maint] [rpm-software-management/rpm] File conflicts: Symlinked directories -> same file replaced by real directories -> unique files (#1458)

2023-12-12 Thread Panu Matilainen
Eek, no. That Fedora specific hack is not coming anywhere near upstream. Sorry but I don't have a whole lot of sympathy for the use-case of installing Fedora 17 by current rpm versions... -- Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Examine Compressed Headers (Issue #2220)

2023-12-12 Thread Panu Matilainen
You can't. So header compression on package level would have to be an optional feature. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2220#issuecomment-1851861360 You are receiving this because you are subscribed to this thread.

Re: [Rpm-maint] [rpm-software-management/rpm] invalid OpenPGP signature with Sequoia for existing RPM (Issue #2351)

2023-12-12 Thread Panu Matilainen
It only works if you actually follow the instructions. Look more carefully. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2351#issuecomment-1851856266 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] Test-suite cleanups (PR #2809)

2023-12-12 Thread Panu Matilainen
Merged #2809 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2809#event-11222067094 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Is there a way to determine if a package is provided by OS repos or custom built? (Discussion #2808)

2023-12-12 Thread Vít Ondruch
I'd say this is out of scope for RPM, but e.g. DNF can have the answer: ~~~ # dnf info rpm | grep repository >From repository : rawhide ~~~ -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/discussions/2808#discussioncomment-7829645 You are

Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.19.1 bugfix update (PR #2791)

2023-12-12 Thread Michal Domonkos
Merged #2791 into rpm-4.19.x. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2791#event-11221883573 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint

[Rpm-maint] [rpm-software-management/rpm] Test-suite cleanups (PR #2809)

2023-12-12 Thread Panu Matilainen
Side-products from doing something else :sweat_smile: You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/2809 -- Commit Summary -- * Split relocate install test to sub-cases for readability * Avoid unnecessary rebuilding in

Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.19.1 bugfix update (PR #2791)

2023-12-12 Thread Michal Domonkos
@dmnks pushed 11 commits. d4ea40e1899867781b3038b86dad39777d08 Silence not-documented warnings from Doxygen 269075562b42e8f127ad56afe594ef90ee6618a4 Honor ENABLE_WERROR on Doxygen too 9291d900fc862d8cfbb1dd884b1d882854ba8ab7 Optimize Doxygen output for C

Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.19.1 bugfix update (PR #2791)

2023-12-12 Thread Michal Domonkos
Excerpt from `git range-diff` showing the added commits: ``` -: - > 243: 79cca0a9e Split the two rpm2archive tests to separate test-cases -: - > 244: 2de414acd Use the expected rpm2cpio-like syntax for rpm2archive tests -: - > 245: 156fd9cc3 Fix some invalid

Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.19.1 bugfix update (PR #2791)

2023-12-12 Thread Michal Domonkos
@dmnks pushed 35 commits. 79cca0a9e9e80f5029ded3469cd3889c96cd675a Split the two rpm2archive tests to separate test-cases 2de414acd2c111a3526b640170772e4731805970 Use the expected rpm2cpio-like syntax for rpm2archive tests 156fd9cc3d9385eef99ac6b4e89c782bef6d4397 Fix some invalid rpm2cpio

[Rpm-maint] [rpm-software-management/rpm] Is there a way to determine if a package is provided by OS repos or custom built? (Discussion #2808)

2023-12-12 Thread Shreenidhi Shedi
Hi, I'm not sure if something like this exists already; asking here for inputs. I'm using an rpm based distro and I want to know what packages are installed from OS's repo and what packages are custom built and installed from different source. Conditions: - Closed eco system, no network

Re: [Rpm-maint] [rpm-software-management/rpm] RFC: Strip quote characters in macro expansion if we do not split the result (PR #2788)

2023-12-12 Thread Michael Schroeder
No, the code works fine. I'll just to another pull request to tidy it up a bit and add some test cases. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2788#issuecomment-1851633255 You are receiving this because you are subscribed to

Re: [Rpm-maint] [rpm-software-management/rpm] RFC: Strip quote characters in macro expansion if we do not split the result (PR #2788)

2023-12-12 Thread Panu Matilainen
Do you want me to revert it for the time being? -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2788#issuecomment-1851590761 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] RFC: Strip quote characters in macro expansion if we do not split the result (PR #2788)

2023-12-12 Thread Panu Matilainen
Oh. I did actually notice the RFC, but it seemed like a reasonably complete patch so thought why not. The best way to ensure PRs dont get accidentally merged is to create it as a draft PR, that way it's enforced at GH level. -- Reply to this email directly or view it on GitHub: