Re: [Rpm-maint] [rpm-software-management/rpm] 4.19.1: broken `update-pot` target (Issue #2817)

2024-01-17 Thread Panu Matilainen
> MANY projects have not updated .po files I fail to see any relevance to rpm. In any case, this is supposedly fixed in b4dc72f4b92489f77de9b0ae0bed754875d37ece. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2817#issuecomment-18953

Re: [Rpm-maint] [rpm-software-management/rpm] 4.19.1: broken `update-pot` target (Issue #2817)

2024-01-17 Thread Panu Matilainen
Closed #2817 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2817#event-11508091602 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint m

Re: [Rpm-maint] [rpm-software-management/rpm] Attribute marker in `-V` mode undefined for multi-attribute files (Issue #2846)

2024-01-17 Thread Panu Matilainen
I think it's slighly more subtle: whether a file is a %license or not has little relevance to verify results. However a content mismatch on a %config file is something entirely different (with possible noreplace/missingok modifiers) and yet again quite different for a %ghost which can also have

[Rpm-maint] [rpm-software-management/rpm] "setarch i386 rpmbuild ... " no longer working for building 32-bit packages on x86_64 host (Issue #2850)

2024-01-17 Thread Paul Howarth
**Describe the bug** Since upgrading from Fedora 38 to Fedora 39, I cannot create my Oracle Java 8 (i586) packages on my x86_64 host by running rpmbuild via "setarch i386". If I try to do it, it just does a 64-bit build as if the setarch command hadn't been used. In fact, on Fedora 39 with rpm

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: store SBOM data in rpm headers? (Issue #2389)

2024-01-17 Thread Panu Matilainen
@pmatilai converted this issue into discussion #2851. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2389#event-11510089819 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] don't attempt to install html pages if they're not built (PR #2848)

2024-01-17 Thread Panu Matilainen
Closed #2848. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2848#event-11510440839 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm

Re: [Rpm-maint] [rpm-software-management/rpm] don't attempt to install html pages if they're not built (PR #2848)

2024-01-17 Thread Panu Matilainen
Oh indeed. I tweaked the commit message to elaborate on when it happens (this only affects building from git without doxygen, release tarballs have the html content prebuilt) and applied manually as commit 6098fe1e9f735ab3a603eb429e01300ae48bf4fe Thanks for the patch! -- Reply to this email

Re: [Rpm-maint] [rpm-software-management/rpm] Remove cycles from CMake dependency graph (PR #2820)

2024-01-17 Thread Panu Matilainen
@pmatilai requested changes on this pull request. I came *this* close to merging, but testing made me remember why it's done the way it is: we want the tarballs always recreated on "dist". With this patch, that no longer happens. Of course loops can't be right either, but I can't apply this as-

Re: [Rpm-maint] [rpm-software-management/rpm] Remove cycles from CMake dependency graph (PR #2820)

2024-01-17 Thread Panu Matilainen
Just FWIW, https://gitlab.kitware.com/cmake/cmake/-/issues/22852 describes this very case. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2820#issuecomment-1895869882 You are receiving this because you are subscribed to this thread. Mes

Re: [Rpm-maint] [rpm-software-management/rpm] Add "local_generator" (PR #2734)

2024-01-17 Thread Florian Festi
@ffesti pushed 1 commit. cd4bd81ad1c446c119a27eec77b2828b5ea1624a Add %__local_file_attrs macro -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2734/files/61bd40a9df5170da6182e560d172fb16f4e3213b..cd4bd81ad1c446c119a27eec77b2828b5ea1624a You are receiving this because

Re: [Rpm-maint] [rpm-software-management/rpm] Add "local_generator" (PR #2734)

2024-01-17 Thread Florian Festi
OK, just hard coding one file attribute doesn't seem like a good idea. I added a macro that allows you to register an arbitrary number of local file attributes and generators. I am still wondering if we need a mechanism to avoid executing generators twice when the package is already installed wh

Re: [Rpm-maint] [rpm-software-management/rpm] Make user/group lookup caching thread-safe (PR #2843)

2024-01-17 Thread Florian Festi
Looks good to me. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2843#issuecomment-1896120720 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing

Re: [Rpm-maint] [rpm-software-management/rpm] Strange behavior for multilib (Issue #2837)

2024-01-17 Thread Michael Schroeder
i586 <-> i686 is exactly the same class as i586 <-> i686 when the color is zero for one of the rpms. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2837#issuecomment-1896129493 You are receiving this because you are subscribed to this

[Rpm-maint] [rpm-software-management/rpm] CMakeLists.txt: restore readline support as an explicit option (PR #2852)

2024-01-17 Thread Alexander Kanavin
This was lost in autotools -> cmake transition. The particular reason to make it explicit is that readline is gpl version 3 licensed, and in some builds components under that license need to be excluded. You can view, comment on, or merge this pull request online at: https://github.com/rpm-sof

Re: [Rpm-maint] [rpm-software-management/rpm] CMakeLists.txt: restore readline support as an explicit option (PR #2852)

2024-01-17 Thread Florian Festi
Looks basically correct. Unless this was left out on purpose. Panu? -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2852#issuecomment-1896198092 You are receiving this because you are subscribed to this thread. Message ID: ___

[Rpm-maint] [rpm-software-management/rpm] Fix link, declarative builds instead of autobuild (PR #2853)

2024-01-17 Thread Jan Zerebecki
You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/2853 -- Commit Summary -- * Fix link, declarative builds instead of autobuild -- File Changes -- M docs/manual/index.md (2) -- Patch Links -- https://github.com/rpm-so

Re: [Rpm-maint] [rpm-software-management/rpm] Fix link, declarative builds instead of autobuild (PR #2853)

2024-01-17 Thread Florian Festi
Nice find. This is obviously an issue. I just wonder whether the link should be fixed or if the file should be re-named. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2853#issuecomment-1896498945 You are receiving this because you are s

Re: [Rpm-maint] [rpm-software-management/rpm] 4.19.1: broken `update-pot` target (Issue #2817)

2024-01-17 Thread Eli Schwartz
> MANY projects have not updated .po files (look on > https://github.com/mesonbuild/meson/issues/11338) Yes, and we don't believe you should be running update-po either. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2817#issuecomment

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: Make `%setup` work with archives regardless of inner structure (Issue #2664)

2024-01-17 Thread Matteo Croce
I have a draft change in https://github.com/teknoraver/rpm/tree/libarchive2 Most of the work needed to be done in `rpmuncompress`, I added a `-p` flag which does the following: ``` $ tar vtf source-singleroot.tar.gz drwxr-xr-x root/root 0 2024-01-16 19:13 source-xx/ -rw-r--r-- roo

Re: [Rpm-maint] [rpm-software-management/rpm] Remove cycles from CMake dependency graph (PR #2820)

2024-01-17 Thread Timothy Brackett
> we want the tarballs always recreated on "dist". Okay, I get that. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2820#issuecomment-1897680855 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] Fix link, declarative builds instead of autobuild (PR #2853)

2024-01-17 Thread Panu Matilainen
The feature is no longer "autobuild" so there's nothing to rename. Thanks for the patch! -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2853#issuecomment-1897947879 You are receiving this because you are subscribed to this thread. Messa

Re: [Rpm-maint] [rpm-software-management/rpm] Fix link, declarative builds instead of autobuild (PR #2853)

2024-01-17 Thread Panu Matilainen
Merged #2853 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2853#event-11521499719 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mail

Re: [Rpm-maint] [rpm-software-management/rpm] CMakeLists.txt: restore readline support as an explicit option (PR #2852)

2024-01-17 Thread Panu Matilainen
Ack, one of many many many many tiny things that fell through the cracks, probably a case of "I'll fix this later". Thanks for the patch! -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2852#issuecomment-1897951171 You are receiving this

Re: [Rpm-maint] [rpm-software-management/rpm] CMakeLists.txt: restore readline support as an explicit option (PR #2852)

2024-01-17 Thread Panu Matilainen
Merged #2852 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2852#event-11521524070 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mail

Re: [Rpm-maint] [rpm-software-management/rpm] Make user/group lookup caching thread-safe (PR #2843)

2024-01-17 Thread Panu Matilainen
@pmatilai pushed 1 commit. 58b13066e4b540d6440c41becaf3690663cd46d2 Simplify the cache lookup logic, no functional changes -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2843/files/d23eb53abdde25ad2c45d20c32dde255fb36384d..58b13066e4b540d6440c41becaf3690663cd46d2 You

Re: [Rpm-maint] [rpm-software-management/rpm] Fix link, declarative builds instead of autobuild (PR #2853)

2024-01-17 Thread Florian Festi
May be except the link text? -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2853#issuecomment-1897972464 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-ma