@pmatilai commented on this pull request.
> @@ -1060,71 +1069,72 @@ typedef const struct PreambleRec_s {
int type;
int deprecated;
int ismacro;
+int beforebuildonly;
This is certainly better than the not-version (negations in variable names are
the wrong thing, every time),
Thirteenth time the charm, eh? :smile:
Should be fixed up now, and thanks guys for spotting this stuff.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2885#issuecomment-1978136786
You are receiving this because you are subscribed to
@pmatilai commented on this pull request.
> if (initialPackage) {
if (checkForRequiredForBuild(pkg->header)) {
goto exit;
}
- char *buildRoot = rpmGetPath(spec->buildRoot, NULL);
- free(spec->buildRoot);
- spec->buildRoot = buildRoot;
-
Thanks a lot, i just stuck on this for a long time. My build container
`/etc/rpm/macros.image-language-conf`=`%_install_langs en_US.UTF-8`, The ISO i
built with this container, it's Anaconda INSTALLATION screen only support
English.
--
Reply to this email directly or view it on GitHub:
@dmnks commented on this pull request.
> if (initialPackage) {
if (checkForRequiredForBuild(pkg->header)) {
goto exit;
}
- char *buildRoot = rpmGetPath(spec->buildRoot, NULL);
- free(spec->buildRoot);
- spec->buildRoot = buildRoot;
-
Seems like the test-suite changes have accidentally spilled into the preceding
commit `Print informative messages to stderr, not stdout on --target build`
:smile:
--
Reply to this email directly or view it on GitHub:
@mlschroe commented on this pull request.
> - goto exit;
+
+ if (!spec->buildDir) {
+ /* Using release here causes a buildid no-recompute test to fail */
+ spec->buildDir =
rpmExpand("%{_top_builddir}/%{NAME}-%{VERSION}-%{_arch}", NULL);
+ /*
@mlschroe commented on this pull request.
> if (initialPackage) {
if (checkForRequiredForBuild(pkg->header)) {
goto exit;
}
- char *buildRoot = rpmGetPath(spec->buildRoot, NULL);
- free(spec->buildRoot);
- spec->buildRoot = buildRoot;
-
@mlschroe pushed 2 commits.
2880adc356b3808241ab348c372f190dd48cb624 Add support for a _buildtime macro
for setting the build time manually
ee365274c42530286a09dad1fc83144ef478b25a Support clamping the file mtime to
the build time
--
View it on GitHub:
This makes it easier to reproduce a build that was done without
SOURCE_DATE_EPOCH. The two new macros are opt in so that the current
functionality is not touched.
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/2944
--
So... I would think that this is ready now, for real :sweat_smile:
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2885#issuecomment-1976610890
You are receiving this because you are subscribed to this thread.
Message ID:
Renamed the builddir creation script to %mkbuilddir (along with the enum) in
the last push to disambiguate the two.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2885#issuecomment-1976609669
You are receiving this because you are
@pmatilai pushed 1 commit.
fbf6913aef6b851b75f17feb7ea108e1d8143404 Introduce an rpm-controlled per-build
directory
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2885/files/c661ba05dd7d9b745f84df7f6123c270f7160bd6..fbf6913aef6b851b75f17feb7ea108e1d8143404
You are
@pmatilai pushed 1 commit.
c661ba05dd7d9b745f84df7f6123c270f7160bd6 Introduce an rpm-controlled per-build
directory
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2885/files/9fb0bd8ac2899d6f0cd5e9c05280fbb3a544bf17..c661ba05dd7d9b745f84df7f6123c270f7160bd6
You are
Ended up renaming %pkgbuilddir to %builddir as per your and my gut feelings -
we don't have "pkg" anywhere at all in our macros so introducing it here would
seem a bit strange somehow.
Updated the docs a bit + added couple of tests to demonstrate the new layout
and behavior.
As a side-note,
@pmatilai pushed 2 commits.
a162fe61525ff91768299a7231e8ca3d4cf25ce3 Print informative messages to stderr,
not stdout on --target build
9fb0bd8ac2899d6f0cd5e9c05280fbb3a544bf17 Introduce an rpm-controlled per-build
directory
--
View it on GitHub:
Cool, thanks. We'll give this a go in Fedora as soon as it becomes available by
doing some rebuilds of official koji builds. I hope it works as expected, and
if not, we can always adjust.
--
Reply to this email directly or view it on GitHub:
Let's track this in the respective GH project that already exists for this one:
https://github.com/orgs/rpm-software-management/projects/16/views/1
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2655#issuecomment-1976277991
You are
Closed #2655 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2655#event-11996919379
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint
19 matches
Mail list logo
