The second commit (to add the other awks) may be a bit "controversial" in terms
of how useful it really is but... why not :smile:
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2966#issuecomment-1992154308
You are receiving this because
Please see the commit messages for details.
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/2966
-- Commit Summary --
* Sanitize awk and find-debuginfo paths in macros
* Accept alternative awk implementations in cmake
--
**Describe the bug**
rpmsign --delsign leaves behind 0 padding, previously similar problem in
https://github.com/rpm-software-management/rpm/issues/2382 fixed by
https://github.com/rpm-software-management/rpm/pull/2396
**To Reproduce**
Steps to reproduce the behavior:
1. rebuild locally: osc co
Argh, right. Not much thinking was involved in the patch creation, I admit.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2958#issuecomment-1991693442
You are receiving this because you are subscribed to this thread.
Message ID: ___
I'm not sure it's worth the trouble :smile:
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2960#issuecomment-1991688117
You are receiving this because you are subscribed to this thread.
Message ID: __
Needs a re-fix, see #2960 for details.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2926#issuecomment-1991683268
You are receiving this because you are subscribed to this thread.
Message ID: __
Reopened #2926.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2926#event-12089522278
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint mailing list
Note that we need to come up with something that works both for `Source:` and
`%sourcelist`
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/463#issuecomment-1991682334
You are receiving this because you are subscribed to this thread.
M
Oh, now I realize commit
https://github.com/rpm-software-management/rpm/commit/5ac27313a5ecd601e01393cda10e6f16728a434a
was *before*
https://github.com/rpm-software-management/rpm/commit/bbb289e303d8c72b9e35410e593b8d92b006bec1
so I guess that's the explanation :smile:
I'll hack up a fixup co
And while at it, `find-debuginfo` should be handled the same way as `awk` here.
@pmatilai, I wonder what the rationale of commit
https://github.com/rpm-software-management/rpm/commit/5ac27313a5ecd601e01393cda10e6f16728a434a
was? Besides `macros.in`, we're only using it in `atlocal.in` but that d
Yep, I was originally going with exactly that (even had the code locally) but
then I realized there was no point in not just using `find_program()` :smile:
The reason we have `findutil()` is so that we have a sanitized path selection
(i.e. not `$PATH`) for these utilities that go into `macros.in
@mlschroe requested changes on this pull request.
You need to set the signal handler to SIG_DFL in the child
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2958#pullrequestreview-1931036967
You are receiving this because you are subscr
Closed #2926 as completed via #2960.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2926#event-12089020607
You are receiving this because you are subscribed to this thread.
Message ID:
___
R
Merged #2960 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2960#event-12089020248
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint mail
Oh, I was thinking of passing a new arg to findutil() instead, but I see
there's already a similar precedent from find-debuginfo. That's just as well
then.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2960#issuecomment-1991616494
You
Uh, so that was just some disturbances in the cosmic order it seems.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2964#issuecomment-1991610469
You are receiving this because you are subscribed to this thread.
Message ID: __
@pmatilai pushed 2 commits.
b8dfffe322e7022ba42e2718d085c3b01fff46ae Add the ability to pass qualifiers to
our dependency tests
a83032fcdf7a49dfe840a5e9739bb8c4842a4c0e Really allow qualifiers like
pre/post/meta for weak dependencies
--
View it on GitHub:
https://github.com/rpm-software-mana
@pmatilai pushed 1 commit.
42e6e85adda4fb2395ab3cba3a11292f8c4edb97 Really allow qualifiers like
pre/post/meta for weak dependencies
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2964/files/d8be83c4edf8e6f2b6b01161ed72af203b38916e..42e6e85adda4fb2395ab3cba3a11292f8c
Converting to draft for now, there's something weird going on with CI
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2964#issuecomment-1991578341
You are receiving this because you are subscribed to this thread.
Message ID: _
@pmatilai pushed 1 commit.
d8be83c4edf8e6f2b6b01161ed72af203b38916e Really allow qualifiers like
pre/post/meta for weak dependencies
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2964/files/078ccae5a655e044a9b867206cf4215acb3f0113..d8be83c4edf8e6f2b6b01161ed72af203b
@pmatilai pushed 0 commits.
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2964/files/2507bba7fec24b347f65e61d160b4f09e2d4709f..078ccae5a655e044a9b867206cf4215acb3f0113
You are receiving this because you are subscribed to this thread.
Message ID:
OK, should be fixed now.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2960#issuecomment-1991531934
You are receiving this because you are subscribed to this thread.
Message ID: ___
Rpm-maint
@pmatilai pushed 1 commit.
a507fabf235bedcc94add2be224ea2745cd60ba5 Really allow qualifiers like
pre/post/meta for weak dependencies
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2964/files/4818cb348f14e76dda28f91e5a3ec87978e33da4..a507fabf235bedcc94add2be224ea2745c
Commit ddbf30cf96a33319805b362b01d8a6fdfe7dea9c neglected to update the
preamble table types for the weak dependency tags, so it never worked. Add a
test to ensure it works and stays that way.
Fixes: #624
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-s
[root@linux ~]# dnf install
https://build.stream.opencloudos.tech/kojifiles/work/tasks/3484/223484/python3-cheroot-10.0.0-2.ocs23.noarch.rpm
Last metadata expiration check: 3:22:05 ago on Tue Mar 12 16:17:04 2024.
python3-cheroot-10.0.0-2.ocs23.noarch.rpm 3.8 MB/s | 217 kB 00:00
Generally requests for new features should be opened as a
[Discussion](https://github.com/rpm-software-management/rpm/discussions) first.
There feedback from the community can be collected and possible solutions can
be discussed. Consider maintaining a design outline in the top post and update
This is intended to be used for non-mock builds. It simplifies patches
maintenance when preparing old rhel specs from Fedora system, so it does not
need to be backported to rhel8 or previous. It is meant to be used for rebasing
or testing in ``fedpkg local`` or ``fedpkg install`` modes, where ad
I'd probably go with `RPMTAG_FILEMIME`.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/discussions/2919#discussioncomment-8757616
You are receiving this because you are subscribed to this thread.
Message ID:
_
IOW this is what the heading says:
~~~
$ rpm -E "%{lua:rpm.define('foo', '1')}" -E "%foo"
error: Macro %foo has empty body
error: lua script failed: [string ""]:1: error defining macro
~~~
but this is how it actually works:
~~~
$ rpm -E "%{lua:rpm.define('foo 1')}" -E "%foo"
1
~~~
--
Reply to
This line is incorrect IMHO:
https://github.com/rpm-software-management/rpm/blob/689f1d8d3ef4fcba4b4d05160cb5063b8ac11310/docs/manual/lua.md?plain=1#L120
It should actually be something like `define(name_body)`. This example actually
seems to be correct:
https://github.com/rpm-software-manageme
Thanks, I'll update the PR accordingly.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2960#issuecomment-1991244835
You are receiving this because you are subscribed to this thread.
Message ID: ___
findutil() doesn't fail on purpose because we don't really want all those silly
little utilities in /usr/bin/ as build-dependencies of rpm itself, most of them
are only relevant for installed rpmbuild.
But, clearly some of the utilities are more important than others. The easiest
solution is pr
Applying such a patch upstream won't help rhel-7 or rhel-8 in the slightest.
The upstream method for git integration is %autosetup, so I don't really see a
case here. %setup is weird enough as it is, I'd rather not tangle up any more
functionality into it.
--
Reply to this email directly or vi
> Plain awk is commonly available, but it's quite possible to have eg a minimal
> image where it's not installed. So I think we should check for it explicitly
> and fail if not found.
OK, I admit I was just being a bit lazy here :sweat_smile: The point of (cmake)
configuration is not to *assume
this allows creating git-based build patches applied, even on rhel7 or rhel8,
where %autosetup is not used.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2961#issuecomment-1991193975
You are receiving this because you are subscribed to
I have used (or misused) _fixperms macro to provide special actions for
creating build repository as git repository, without the need to modify
original source spec file. Something I have prepared at
https://github.com/pemensik/rpm-gitprep. I would like to have a way more clean
to it.
--
Repl
One almost forgotten metadata-level thing added: replace libmagic strings (in
RPMTAG_FILECLASS) with MIME classification. I don't know if it makes more sense
to reuse the existing tag or reserve a new one just for the purpose though.
--
Reply to this email directly or view it on GitHub:
https:/
Actually, v6 is the place where we can and should flick this particular switch.
The libmagic strings in headers make no sense, but for v4 dropping them is a
compat break.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1096#issuecommen
What's your use-case for this?
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2961#issuecomment-1991114449
You are receiving this because you are subscribed to this thread.
Message ID: ___
Rpm-
Allow custom action done after %_fixperms is done. Creates %_setup_post macro,
which will be expanded after %setup. Consequently also always done in autosetup.
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/2961
-- Commit Sum
40 matches
Mail list logo
