Re: [Rpm-maint] [rpm-software-management/rpm] Convert rpmhook to STL containers, add tests (PR #3164)

2024-06-13 Thread Panu Matilainen
Merged #3164 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3164#event-13156296663 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mail

Re: [Rpm-maint] [rpm-software-management/rpm] Replace digest bundle static sized array with STL map (PR #3163)

2024-06-13 Thread Panu Matilainen
Merged #3163 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3163#event-13156294661 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mail

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: Make dependency loops visible by default (Issue #2941)

2024-06-13 Thread Panu Matilainen
Changed the title a bit, the important part here is that we make the loops visible and analyzeable *somehow* and *by default. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2941#issuecomment-2167295421 You are receiving this because yo

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: Issue dependency loop warnings by default (Issue #2941)

2024-06-13 Thread Panu Matilainen
Yet another thought: we could log the first and last member of each SCC we encounter, either before the transaction or inline the regular output, by default. That'd make it much easier to see the affected package set. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-

Re: [Rpm-maint] [rpm-software-management/rpm] Implement merging of new key material when importing pubkeys (PR #3083)

2024-06-13 Thread Panu Matilainen
Thanks a lot for working on this @mlschroe and @nwalfield for the review! This topic has become a bit of a hot potato in recent months. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3083#issuecomment-2167263902 You are receiving this be

Re: [Rpm-maint] [rpm-software-management/rpm] Implement merging of new key material when importing pubkeys (PR #3083)

2024-06-13 Thread Panu Matilainen
Merged #3083 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3083#event-13156006613 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mail

Re: [Rpm-maint] [rpm-software-management/rpm] Implement merging of new key material when importing pubkeys (PR #3083)

2024-06-13 Thread Panu Matilainen
Ack, lets get it merged then, been open for comments long enough for sure. And it's not as if we couldn't change things once merged if need be. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3083#issuecomment-2167263079 You are receiving

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: %ifarch expression (Issue #3165)

2024-06-13 Thread Panu Matilainen
Well, %isarch() in all its glory is just: `%isarch() %[ "%{_target_cpu}" == "%1" ? 1 : 0 ]` And then: > $ rpm --eval "%{isarch:x86_64}" 1 $ rpm --eval "%{isarch:s390}" 0 -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3165#issuecommen

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: %ifarch expression (Issue #3165)

2024-06-13 Thread Zbigniew Jędrzejewski-Szmek
Sure, that would work. Ideally the syntax/semantics of the arg would be the same as for `%ifarch`, so that people don't introduce mistakes when moving between the two forms. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3165#issuecom

Re: [Rpm-maint] [rpm-software-management/rpm] Implement merging of new key material when importing pubkeys (PR #3083)

2024-06-13 Thread Michael Schroeder
Ok, I think this is now ready to be merged. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3083#issuecomment-2165882897 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [Rpm-maint] [rpm-software-management/rpm] Implement merging of new key material when importing pubkeys (PR #3083)

2024-06-13 Thread Michael Schroeder
@mlschroe pushed 4 commits. 367f8ed974b907163b649aaaecd2b051bb2b Add rpmKeyringModify to change the keys of a keyring da3a9507b4e772e0433c342097aa6183c66d7e9c Add a method to lookup a key from the keyring 1b3dc1165d6b5bd91584f1b6960d39d18f55beca Support pubkey merging in the keyring code

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: %ifarch expression (Issue #3165)

2024-06-13 Thread Michael Schroeder
That would be easy to implement with an expression: ``` %pytest %[isarch("s390x") ? "|| :" : ""] ``` Would that be ok or is it not short enough? -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3165#issuecomment-2165629605 You are receivi

[Rpm-maint] [rpm-software-management/rpm] RFE: %ifarch expression (Issue #3165)

2024-06-13 Thread Zbigniew Jędrzejewski-Szmek
As discussed during the RPM Developers' Meetup during DevConf.cz: please allow %ifarch to be used inline, i.e. make it an expression or provide an a new syntax for an expression. The problem is that %ifarch is very verbose and requires at least 3 lines. It'd be nice to replace this by an inline

[Rpm-maint] [rpm-software-management/rpm] Convert rpmhook to STL containers, add tests (PR #3164)

2024-06-13 Thread Panu Matilainen
You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/3164 -- Commit Summary -- * Add a testcase for Lua hook register/call/unregister * Convert rpmhook table and args to STL containers -- File Changes -- M rpmio/rpmhook.