Re: [Rpm-maint] [rpm-software-management/rpm] Mass-rename all relevant sources to a C++ extension (Issue #3316)

2024-10-04 Thread Florian Festi
Closed #3316 as completed via #3356. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3316#event-14515340297 You are receiving this because you are subscribed to this thread. Message ID: ___ R

Re: [Rpm-maint] [rpm-software-management/rpm] Mass rename C++ sources to .cc/.hh extension (PR #3356)

2024-10-04 Thread Florian Festi
Merged #3356 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3356#event-14515340088 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mail

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-10-02 Thread Florian Festi
@ffesti commented on this pull request. > @@ -288,7 +346,15 @@ rpmRC rpmKeyringVerifySig(rpmKeyring keyring, > pgpDigParams sig, DIGEST_CTX ctx) rpmlog(rc ? RPMLOG_ERR : RPMLOG_WARNING, "%s\n", lints); free(lints); } + if (keyptr) { + *keyptr = rp

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-10-02 Thread Florian Festi
@ffesti pushed 5 commits. 818162645d3441cd8f8df57331d5e81ba2540808 Add rpmPubkeyFingerprint and rpmPubkeyFingerprintAsHex 8df52704121eba0b5a45e4d440bb671a8914d509 Add rpmKeyringVerifySig2 that return the matching primary key 505638062b624b1dc08974b249cc3a9848ce8da2 Add Key Fingerprints to rp

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-10-02 Thread Florian Festi
@ffesti commented on this pull request. > /* Returned to C, can't use new */ subkeys = (rpmPubkey *)xmalloc(pgpsubkeysCount * sizeof(*subkeys)); - for (i = 0; i < pgpsubkeysCount; i++) - subkeys[i] = rpmPubkeyNewSubkey(pgpsubkeys[i]); + for (i = 0; i < pgp

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-10-02 Thread Florian Festi
@ffesti commented on this pull request. > { rpmPubkey *subkeys = NULL; pgpDigParams *pgpsubkeys = NULL; int pgpsubkeysCount = 0; int i; -if (mainkey && !pgpPrtParamsSubkeys(mainkey->pkt.data(), mainkey->pkt.size(), - mainkey->pgpkey, &pgpsubkeys,

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-10-02 Thread Florian Festi
@ffesti pushed 7 commits. 4fce6ece30fb5b5385c1b8d39a2e9620224a4ea8 Use long PGP Key IDs for all outputs 536679e4ecd03ec4631b324be60be0cc1a28ec68 Use long PGP Key Ids in our test cases bb654f2c13ab0be27318d94882f53272742dfd4b Add rpmPubkeyPrimarykey and rpmPubkeyFingerprint(AsHex) 58d77283fc389

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-10-02 Thread Florian Festi
@ffesti commented on this pull request. > @@ -288,7 +346,15 @@ rpmRC rpmKeyringVerifySig(rpmKeyring keyring, > pgpDigParams sig, DIGEST_CTX ctx) rpmlog(rc ? RPMLOG_ERR : RPMLOG_WARNING, "%s\n", lints); free(lints); } + if (keyptr) { + *keyptr = rp

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-10-01 Thread Florian Festi
@ffesti commented on this pull request. > @@ -107,6 +117,22 @@ rpmPubkey rpmPubkeyLink(rpmPubkey key); */ char * rpmPubkeyBase64(rpmPubkey key); +/** \ingroup rpmkeyring + * Return fingerprint of primary key + * @param key Pubkey + * @param fp Fingerprint data + * @param

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-10-01 Thread Florian Festi
@ffesti commented on this pull request. > @@ -387,7 +387,7 @@ runroot rpm -U --ignorearch --ignoreos --nodeps \ ], [1], [], -[error: /tmp/hello-2.0-1.x86_64-signed.rpm: Header V4 RSA/SHA256 Signature, key ID 1964c5fc: BAD +[error: /tmp/hello-2.0-1.x86_64-signed.rpm: Header V4 RSA/SHA256 Sign

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-10-01 Thread Florian Festi
@ffesti pushed 5 commits. b7a81df984de2b993c0eb85cd09a7545d153f8f0 Add rpmPubkeyPrimarykey and rpmPubkeyFingerprint(AsHex) c39b607f5344d8cc9f8245c507e783bdbce6ff8b Add rpmKeyringVerifySig2 that return the matching key 2bc671e4176e6b18005ae125534f34ba5da13633 Add Key Fingerprints to rpmsinfoMs

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-10-01 Thread Florian Festi
@ffesti commented on this pull request. > free(pgpsubkeys); } *count = pgpsubkeysCount; return subkeys; } +rpmPubkey rpmPubkeyPrimarykey(rpmPubkey key) +{ +rpmPubkey primarykey = NULL; +if (key) { + wrlock lock(key->mutex); + if (key->primarykey == N

Re: [Rpm-maint] [rpm-software-management/rpm] Reference Manual: RPM's Philosophy (PR #3299)

2024-10-01 Thread Florian Festi
@ffesti commented on this pull request. > + * Upstream build scripts using tools like maker, cmake, ant, ... + * rpmbuild for running those via a Spec file + * Build systems for installing build dependencies and keeping track of build artifacts + * Package repositories offering binary packages

Re: [Rpm-maint] [rpm-software-management/rpm] Reference Manual: RPM's Philosophy (PR #3299)

2024-10-01 Thread Florian Festi
@ffesti pushed 2 commits. de9ba0e9378f163cf4b30e8b8d789fcd1090198d Reference Manual: RPM's Philosophy 29e22e80c01f012ceeb19c7cc353abebb2561b15 Link philosophy page from CONTRIBUTING file -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/3299/files/9e37b8ef5232c93946b2c

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-10-01 Thread Florian Festi
@ffesti commented on this pull request. > /* Returned to C, can't use new */ subkeys = (rpmPubkey *)xmalloc(pgpsubkeysCount * sizeof(*subkeys)); - for (i = 0; i < pgpsubkeysCount; i++) - subkeys[i] = rpmPubkeyNewSubkey(pgpsubkeys[i]); + for (i = 0; i < pgp

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-10-01 Thread Florian Festi
@ffesti commented on this pull request. > { rpmPubkey *subkeys = NULL; pgpDigParams *pgpsubkeys = NULL; int pgpsubkeysCount = 0; int i; -if (mainkey && !pgpPrtParamsSubkeys(mainkey->pkt.data(), mainkey->pkt.size(), - mainkey->pgpkey, &pgpsubkeys,

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-10-01 Thread Florian Festi
@ffesti commented on this pull request. > { rpmPubkey *subkeys = NULL; pgpDigParams *pgpsubkeys = NULL; int pgpsubkeysCount = 0; int i; -if (mainkey && !pgpPrtParamsSubkeys(mainkey->pkt.data(), mainkey->pkt.size(), - mainkey->pgpkey, &pgpsubkeys,

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-10-01 Thread Florian Festi
@ffesti commented on this pull request. > /* Returned to C, can't use new */ subkeys = (rpmPubkey *)xmalloc(pgpsubkeysCount * sizeof(*subkeys)); - for (i = 0; i < pgpsubkeysCount; i++) - subkeys[i] = rpmPubkeyNewSubkey(pgpsubkeys[i]); + for (i = 0; i < pgp

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-10-01 Thread Florian Festi
@ffesti pushed 5 commits. 5c6f832c41535173b012d8046ab4afbe0d32a3d4 Add rpmPubkeyPrimarykey and rpmPubkeyFingerprint(AsHex) 66759e71a6314b8ed7df79545af08cad93d32ee9 Add rpmKeyringVerifySig2 that return the matching key 05bae29c7e074f0b00c9409516cf8c45b4ed1655 Add Key Fingerprints to rpmsinfoMs

Re: [Rpm-maint] [rpm-software-management/rpm] Reference Manual: RPM's Philosophy (PR #3299)

2024-09-30 Thread Florian Festi
@ffesti pushed 1 commit. 9e37b8ef5232c93946b2c2f1fa137cbf2cd48ddd Link philosophy page from CONTRIBUTING file -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/3299/files/0bc8d9a1c7b5a553cc4340badbfa3414cdba286b..9e37b8ef5232c93946b2c2f1fa137cbf2cd48ddd You are receivin

Re: [Rpm-maint] [rpm-software-management/rpm] Reference Manual: RPM's Philosophy (PR #3299)

2024-09-30 Thread Florian Festi
Ok, I don't have the mental capacity to make this into a corner stone of western literature but it should now pass as a piece of our docs. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3299#issuecomment-2384869285 You are receiving this

Re: [Rpm-maint] [rpm-software-management/rpm] Reference Manual: RPM's Philosophy (PR #3299)

2024-09-30 Thread Florian Festi
@ffesti pushed 2 commits. 1b0bc723fd753f7f0e0793ceb477871aeb1b0f44 About Reference Manual 0bc8d9a1c7b5a553cc4340badbfa3414cdba286b Reference Manual: RPM's Philosophy -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/3299/files/255a8fa4647ff07a66fb4d63d41c6c54696d3293..0

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-09-30 Thread Florian Festi
@ffesti commented on this pull request. > @@ -387,7 +387,7 @@ runroot rpm -U --ignorearch --ignoreos --nodeps \ ], [1], [], -[error: /tmp/hello-2.0-1.x86_64-signed.rpm: Header V4 RSA/SHA256 Signature, key ID 1964c5fc: BAD +[error: /tmp/hello-2.0-1.x86_64-signed.rpm: Header V4 RSA/SHA256 Sign

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-09-30 Thread Florian Festi
@ffesti commented on this pull request. > @@ -590,9 +615,11 @@ static rpmRC verifySignature(rpmKeyring keyring, struct rpmsinfo_s *sinfo) { rpmRC res = RPMRC_FAIL; -if (pgpSignatureType(sinfo->sig) == PGPSIGTYPE_BINARY) - res = rpmKeyringVerifySig(keyring, sinfo->sig, sinfo->ctx

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-09-30 Thread Florian Festi
@ffesti commented on this pull request. > { rpmPubkey *subkeys = NULL; pgpDigParams *pgpsubkeys = NULL; int pgpsubkeysCount = 0; int i; -if (mainkey && !pgpPrtParamsSubkeys(mainkey->pkt.data(), mainkey->pkt.size(), - mainkey->pgpkey, &pgpsubkeys,

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-09-30 Thread Florian Festi
@ffesti commented on this pull request. > free(pgpsubkeys); } *count = pgpsubkeysCount; return subkeys; } +rpmPubkey rpmPubkeyPrimarykey(rpmPubkey key) +{ +rpmPubkey primarykey = NULL; +if (key) { + rdlock lock(key->mutex); + if (key->primarykey == N

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-09-30 Thread Florian Festi
@ffesti commented on this pull request. > @@ -107,6 +117,22 @@ rpmPubkey rpmPubkeyLink(rpmPubkey key); */ char * rpmPubkeyBase64(rpmPubkey key); +/** \ingroup rpmkeyring + * Return fingerprint of primary key + * @param key Pubkey + * @param fp Fingerprint data + * @param

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-09-30 Thread Florian Festi
@ffesti commented on this pull request. > @@ -56,6 +56,16 @@ int rpmKeyringAddKey(rpmKeyring keyring, rpmPubkey key); */ rpmRC rpmKeyringVerifySig(rpmKeyring keyring, pgpDigParams sig, DIGEST_CTX ctx); +/** \ingroup rpmkeyring + * Perform combined keyring lookup and signature verification

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-09-30 Thread Florian Festi
@ffesti pushed 4 commits. eb5089121b8b167f6991f95152d55bf2d35c88d3 Add rpmPubkeyPrimarykey and rpmPubkeyFingerprint 31ede0d1a6a88993bf6208c2b8aa36f7c5b5 Add rpmKeyringVerifySig2 that return the matching key 906bdae31ac906238c6025d8c824f8f0d24c4f06 Add Key Fingerprints to rpmsinfoMsg() a42

Re: [Rpm-maint] [rpm-software-management/rpm] Redo lib/package.c stashKeyid() and rpmsinfo_s.keyid to use long KeyId (Issue #3333)

2024-09-30 Thread Florian Festi
One way to solve both at the same time would be adding `rpmtsLogOnce()` or something similar that would solve the general problem of omitting (or downgrading) log messages after the first one. There are several more use cases for such an mechanism. There is nothing special about this case here.

Re: [Rpm-maint] [rpm-software-management/rpm] Implement an abstact keystore API (Issue #3342)

2024-09-30 Thread Florian Festi
Needs to account for #3338, #3339, #3340, #3347 -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3342#issuecomment-2382895548 You are receiving this because you are subscribed to this thread. Message ID: _

[Rpm-maint] [rpm-software-management/rpm] Move installed gpg keys to the currently configured storage (Issue #3347)

2024-09-30 Thread Florian Festi
Pratically we only really support gpg-pubkey packages as storage for pgp keys. If we support more backends in earnest we need a way to move keys from one storage backend to another to prevent users needing to re-import the keys. This should probably be done completely automatically to make trans

Re: [Rpm-maint] [rpm-software-management/rpm] Eliminate the gpg-pubkey pseudo-packages in rpmdb (Issue #3313)

2024-09-30 Thread Florian Festi
Well, if we don't want to use the current fs backend but a new "shared OpenPGP certificate directory" backend that will probably be a whole set of new pre-requisites. From skimming through the document I seems to have a signed "catalog" for the installed keys. I am not sure whether we want to im

Re: [Rpm-maint] [rpm-software-management/rpm] Eliminate --pkgid and --hdrid commandline switches (Issue #2633)

2024-09-30 Thread Florian Festi
Closed #2633 as completed via 7b8ff813efa0e97d27b6779a3daed486a76793b1. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2633#event-14451711223 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [Rpm-maint] [rpm-software-management/rpm] Eliminate --pkgid and --hdrid commandline switches (Issue #2633)

2024-09-30 Thread Florian Festi
Closed #2633 as completed via #3335. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2633#event-14451711166 You are receiving this because you are subscribed to this thread. Message ID: ___ R

Re: [Rpm-maint] [rpm-software-management/rpm] Drop --pkgid and --hdrid query source cli-switches (PR #3335)

2024-09-30 Thread Florian Festi
Merged #3335 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3335#event-14451710789 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mail

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-09-26 Thread Florian Festi
@ffesti commented on this pull request. > @@ -107,6 +107,22 @@ rpmPubkey rpmPubkeyLink(rpmPubkey key); */ char * rpmPubkeyBase64(rpmPubkey key); +/** \ingroup rpmkeyring + * Return fingerprint of primary key + * @param key Pubkey + * @param fp Fingerprint data + * @param

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-09-26 Thread Florian Festi
@ffesti pushed 5 commits. 5124ffb1099eab79c968d853748f002af98687bd Add rpmPubkeyPrimarykey and rpmPubkeyFingerprint e28395c631795f70c9efa72eb65815e2b9641b56 Rename mainkey to primarykey d7a9b1d555c78f02970bd4d1e420b9ff545fd209 Add rpmKeyringVerifySig2 that return the matching key 95ac178247fe

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-09-26 Thread Florian Festi
@ffesti commented on this pull request. > @@ -107,6 +107,22 @@ rpmPubkey rpmPubkeyLink(rpmPubkey key); */ char * rpmPubkeyBase64(rpmPubkey key); +/** \ingroup rpmkeyring + * Return fingerprint of primary key + * @param key Pubkey + * @param fp Fingerprint data + * @param

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-09-26 Thread Florian Festi
>From my POV this is now complete. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3321#issuecomment-2376750347 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-09-26 Thread Florian Festi
OK, back to fingerprints in one piece. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3321#issuecomment-2376746515 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-09-26 Thread Florian Festi
@ffesti pushed 0 commits. -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/3321/files/a06349ba66cb3fe8ee156029829959d1b7f82a7d..a927b9d12e218b77133418ee32d886588eaf9b64 You are receiving this because you are subscribed to this thread. Message ID: _

Re: [Rpm-maint] [rpm-software-management/rpm] rpm should not use short gpg key ids in messages (Issue #2403)

2024-09-26 Thread Florian Festi
OK; I put the sub projects into their own tickets and updated the todo list. #3321 has shown that we are fine with the API of the backends as they are. So this whole thing is a bit easier than first thought. Next step is teaching `rpmkeys` to give some useful information on the installed keys (#

[Rpm-maint] [rpm-software-management/rpm] keyring only allows unique key IDs (Issue #3334)

2024-09-26 Thread Florian Festi
Key IDs (even long ones) can have collisions - especially when an attacker tries to generate them on purpose. The right behavior is to try all keys with matching key IDs and see if one is able to verify the signature. -- Reply to this email directly or view it on GitHub: https://github.com/rpm

[Rpm-maint] [rpm-software-management/rpm] Redo lib/package.c stashKeyid() and rpmsinfo_s.keyid to use long KeyId and dynamic storage (Issue #3333)

2024-09-26 Thread Florian Festi
AC: * Key stash is moved to a dynamic data type like the rpmts or the keyring * The key stash is using the long KeyID -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/ You are receiving this because you are subscribed to this thread.

[Rpm-maint] [rpm-software-management/rpm] Make rpmkeys --list show Key fingerprint and sub key IDs (Issue #3332)

2024-09-26 Thread Florian Festi
Currently rpmkeys --list only give the version, release and summary of the gpg-pubkey packages aka short key ID, creation time and issuer. There is now way to get the fingerprint or even long key ID from RPM for the installed GPG keys. Make the current format more useful and also offer a long f

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-09-25 Thread Florian Festi
I wonder what's the deal with upper verses lower case hex strings. I split the fingerprints into groups of four and in lowercase this looks very wrong to me for some reason. Any opinions on that topic? Looks like RPM has always used lowercase in one continuous string. -- Reply to this email di

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-09-25 Thread Florian Festi
@ffesti pushed 1 commit. a06349ba66cb3fe8ee156029829959d1b7f82a7d Split PGP fingerprints into groups of 4 characters -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/3321/files/a927b9d12e218b77133418ee32d886588eaf9b64..a06349ba66cb3fe8ee156029829959d1b7f82a7d You are r

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-09-25 Thread Florian Festi
@ffesti pushed 4 commits. 6aea28756d11044c69f55ea1c8ba8405195c8ecf Add rpmPubkeyMainKey and rpmPubkeyFingerprint d8689a699b58eb380641c582759c924a4f02a877 Add rpmKeyringVerifySig2 that return the matching key 3a19e3737b7c8f2bd9156453c4cefe0eaf4f5293 Add Key Fingerprints to rpmsinfoMsg() a927b9

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-09-25 Thread Florian Festi
@ffesti commented on this pull request. > @@ -319,10 +319,16 @@ rpmRC rpmKeyringVerifySig(rpmKeyring keyring, > pgpDigParams sig, DIGEST_CTX ctx) rpmlog(rc ? RPMLOG_ERR : RPMLOG_WARNING, "%s\n", lints); free(lints); } -} - -if (keyring) + if (keyptr

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-09-25 Thread Florian Festi
@ffesti commented on this pull request. > free(pgpsubkeys); } *count = pgpsubkeysCount; return subkeys; } + +int rpmPubkeyFingerprint(rpmPubkey key, uint8_t **fp, size_t *fplen) +{ +if (key == NULL) + return -1; +key = key->mainkey; +pthread_rwlock_rdl

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-09-25 Thread Florian Festi
@ffesti pushed 6 commits. a9202d26b33e7c40bab0c467969fdb74a6029178 Use long PGP Key IDs for all outputs c48d695487fe93cb6d441f51b573d934d61bf527 Use long PGP Key Ids in our test cases 12cbbcc23a71168af83c8c9f80f6b984847a130b Add rpmPubkeyMainKey and rpmPubkeyFingerprint cc6bd70a7cef0caad8ecc08

Re: [Rpm-maint] [rpm-software-management/rpm] brp-remove-la-files: Remove symlinks, too (PR #3311)

2024-09-25 Thread Florian Festi
Yup, this is why there is a loop. Otherwise we'd encounter dangling symlinks that won't get deleted. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3311#issuecomment-2373422407 You are receiving this because you are subscribed to this th

Re: [Rpm-maint] [rpm-software-management/rpm] Remove brp-elfperms script (PR #3324)

2024-09-24 Thread Florian Festi
Patch itself looks good. @pmatilai is this what you had in mind? -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3324#issuecomment-2371087804 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [Rpm-maint] [rpm-software-management/rpm] brp-remove-la-files: Remove symlinks, too (PR #3311)

2024-09-24 Thread Florian Festi
Yes, but does it process all links before all regular files? -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3311#issuecomment-2371074501 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-09-24 Thread Florian Festi
@ffesti commented on this pull request. > @@ -353,13 +353,13 @@ Checking for key: Version : eb04e625 Checking package after importing key: /data/RPMS/hello-2.0-1.x86_64-signed-with-subkey.rpm: -Header V4 RSA/SHA512 Signature, key ID 1f71177215217ee0: OK +Header V4 RSA/SHA512 Signa

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: Add MIME classification of all files to packages (#1096)

2024-09-24 Thread Florian Festi
Closed #1096 as completed via #3318. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1096#event-14378750857 You are receiving this because you are subscribed to this thread. Message ID: ___ R

Re: [Rpm-maint] [rpm-software-management/rpm] Add per-file MIME information to v6 packages (PR #3318)

2024-09-24 Thread Florian Festi
Merged #3318 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3318#event-14378750603 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mail

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-09-24 Thread Florian Festi
@ffesti commented on this pull request. > @@ -304,10 +319,16 @@ rpmRC rpmKeyringVerifySig(rpmKeyring keyring, > pgpDigParams sig, DIGEST_CTX ctx) rpmlog(rc ? RPMLOG_ERR : RPMLOG_WARNING, "%s\n", lints); free(lints); } -} - -if (keyring) + if (keyptr

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-09-24 Thread Florian Festi
@ffesti pushed 3 commits. 080f73d3b3f60045c8dc44c4256d1e37ec1ef0d9 Add rpmKeyringVerifySig2 that return the matching key f50252ce40039e6b4942988f1eaee98c21f55827 Add Key Fingerprints to rpmsinfoMsg() 6721c185060181d0af37e9f9472d58ceed91e704 Don't print key ID if we have the key fingerprint -

Re: [Rpm-maint] [rpm-software-management/rpm] Filter Lua deprecation warnings based on the originating rpm version (PR #3270)

2024-09-23 Thread Florian Festi
Merged #3270 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3270#event-14367671616 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mail

Re: [Rpm-maint] [rpm-software-management/rpm] Use long PGP Key IDs for all outputs (PR #3292)

2024-09-23 Thread Florian Festi
I have added these changes to #3321. So it is redundant now. Closing. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3292#issuecomment-2368874403 You are receiving this because you are subscribed to this thread. Message ID: _

Re: [Rpm-maint] [rpm-software-management/rpm] Use long PGP Key IDs for all outputs (PR #3292)

2024-09-23 Thread Florian Festi
Closed #3292. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3292#event-14367634542 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm

Re: [Rpm-maint] [rpm-software-management/rpm] Enable C++ exceptions on the codebase (PR #3325)

2024-09-23 Thread Florian Festi
Merged #3325 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3325#event-14367583163 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mail

Re: [Rpm-maint] [rpm-software-management/rpm] Bump the lowest level file digest default to SHA256 too (PR #3326)

2024-09-23 Thread Florian Festi
Merged #3326 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3326#event-14367567035 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mail

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-09-23 Thread Florian Festi
@ffesti commented on this pull request. > free(pgpsubkeys); } *count = pgpsubkeysCount; return subkeys; } + +int rpmPubkeyFingerprint(rpmPubkey key, uint8_t **fp, size_t *fplen) +{ +if (key == NULL) + return -1; +key = key->mainkey; +pthread_rwlock_rdl

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-09-23 Thread Florian Festi
@ffesti commented on this pull request. > @@ -305,13 +306,30 @@ const char *rpmsinfoDescr(struct rpmsinfo_s *sinfo) char *rpmsinfoMsg(struct rpmsinfo_s *sinfo) { char *msg = NULL; +char *fphex = NULL; +char *fpmsg = NULL; +if (sinfo->rc == RPMRC_OK && sinfo->key) { + uin

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-09-23 Thread Florian Festi
@ffesti commented on this pull request. > @@ -591,9 +609,11 @@ static rpmRC verifySignature(rpmKeyring keyring, struct rpmsinfo_s *sinfo) { rpmRC res = RPMRC_FAIL; -if (pgpSignatureType(sinfo->sig) == PGPSIGTYPE_BINARY) - res = rpmKeyringVerifySig(keyring, sinfo->sig, sinfo->ctx

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-09-23 Thread Florian Festi
@ffesti pushed 2 commits. 44ef3bc1dabd7b2f5d4d653afa78db2292466071 Add rpmKeyringVerifySig2 that return the matching key 0352deffbefd673a97e4178481fa0a917081dea6 Add Key Fingerprints to rpmsinfoMsg() -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/3321/files/7f8d5c1c

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-09-23 Thread Florian Festi
@ffesti commented on this pull request. > @@ -107,6 +117,15 @@ rpmPubkey rpmPubkeyLink(rpmPubkey key); */ char * rpmPubkeyBase64(rpmPubkey key); +/** \ingroup rpmkeyring + * Return fingerprint of primary key + * @param key Pubkey + * @param fp Fingerprint data + * @param

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-09-23 Thread Florian Festi
OK, put https://github.com/rpm-software-management/rpm/pull/3292 underneath, adjusted the message and the name of `rpmPubkeyFingerprint` and make the test cases pass. For now I have not remove the key IDs from the messages. I wonder if keeping them is more backward compatible. While they are te

Re: [Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-09-23 Thread Florian Festi
@ffesti pushed 5 commits. b2e11786497a89e035ef2fed224f4fa67b607e1c Use long PGP Key IDs for all outputs 970b708e3a3fab4bb4802cca84a9d403a57bacd9 Use long PGP Key Ids in our test cases bbc00e4b09e06d57772c4766acd876ef7b8b1184 Add rpmPubkeyFingerprint 760f81e6a918460835faddf8b6591b57aad9cbe3 Add

Re: [Rpm-maint] [rpm-software-management/rpm] Use long PGP Key IDs for all outputs (PR #3292)

2024-09-21 Thread Florian Festi
Turns out we actually can output the fingerprints without changing the backends. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3292#issuecomment-2365035964 You are receiving this because you are subscribed to this thread. Message ID: __

[Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

2024-09-20 Thread Florian Festi
This does not yet adjust the test cases. So 198 209 216 217 220 221 222 223 226 227 are failing due to unexpected key finger prints. Can probably be used in combination with #3292 as this does not touch the keyid output. Although we might want to skip the key id for verified signatures. Related

Re: [Rpm-maint] [rpm-software-management/rpm] Drop support for installing rpm v3 packages (#1107)

2024-09-19 Thread Florian Festi
Closed #1107 as completed via a76ef22c8f744fc2deaec2c578ec2fd46e552943. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1107#event-14325435393 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [Rpm-maint] [rpm-software-management/rpm] Drop support for installing rpm v3 packages (#1107)

2024-09-19 Thread Florian Festi
Closed #1107 as completed via #3305. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1107#event-14325435367 You are receiving this because you are subscribed to this thread. Message ID: ___ R

Re: [Rpm-maint] [rpm-software-management/rpm] Missing header sanity checks for rpmtsImportHeader() (Issue #3306)

2024-09-19 Thread Florian Festi
Closed #3306 as completed via 1fbf8aeb4e78b8b4afeeaafcbc97b3cbf7cfeaba. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3306#event-14325435517 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [Rpm-maint] [rpm-software-management/rpm] Drop support for installing v3 packages (PR #3305)

2024-09-19 Thread Florian Festi
Merged #3305 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3305#event-14325434974 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mail

Re: [Rpm-maint] [rpm-software-management/rpm] Drop support for installing v3 packages (PR #3305)

2024-09-19 Thread Florian Festi
Commit messages of the first patch talks about versions before 4.0.2 while https://github.com/rpm-software-management/rpm/pull/3305/commits/3e24b095c7ce0397c6211d2cebe5530154ef13fc says "the immutable region as we know it appears in commit https://github.com/rpm-software-management/rpm/commit/7d

Re: [Rpm-maint] [rpm-software-management/rpm] rpm should not use short gpg key ids in messages (Issue #2403)

2024-09-18 Thread Florian Festi
OK, I guess I am not quite getting this sub key business yet. Doesn't the signature list the KeyId of the subkey it was created with? Or does it point to the main key and assumes the subkey will be found there? After looking at this overall mess we figured a way to solve a lot of the issues wi

Re: [Rpm-maint] [rpm-software-management/rpm] brp-remove-la-files: Remove symlinks, too (PR #3311)

2024-09-18 Thread Florian Festi
Loop and test case added. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3311#issuecomment-2358276779 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] brp-remove-la-files: Remove symlinks, too (PR #3311)

2024-09-18 Thread Florian Festi
@ffesti pushed 1 commit. 4936c42b4d8ed68af45fe220d24b2a69baaf9676 brp-remove-la-files: Remove symlinks, too -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/3311/files/8fc4e71f9b51438f09c8206ceb1b407bbaca8aab..4936c42b4d8ed68af45fe220d24b2a69baaf9676 You are receiving

Re: [Rpm-maint] [rpm-software-management/rpm] brp-remove-la-files: Remove symlinks, too (PR #3311)

2024-09-17 Thread Florian Festi
@ffesti pushed 1 commit. 8fc4e71f9b51438f09c8206ceb1b407bbaca8aab brp-remove-la-files: Remove symlinks, too -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/3311/files/7fd4312b5f811152f302406b0a0275edb12a9108..8fc4e71f9b51438f09c8206ceb1b407bbaca8aab You are receiving

Re: [Rpm-maint] [rpm-software-management/rpm] brp-remove-la-files won't remove symlink files (Issue #3304)

2024-09-17 Thread Florian Festi
Can you please test if the PR linked above fixes your issue? Thanks! -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3304#issuecomment-2355385569 You are receiving this because you are subscribed to this thread. Message ID:

[Rpm-maint] [rpm-software-management/rpm] brp-remove-la-files: Remove symlinks, too (PR #3311)

2024-09-17 Thread Florian Festi
As we check for file contents delete symlink before looking at regular files. Resolves: #3304 You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/3311 -- Commit Summary -- * brp-remove-la-files: Remove symlinks, too -- File Ch

Re: [Rpm-maint] [rpm-software-management/rpm] brp-remove-la-files won't remove symlink files (Issue #3304)

2024-09-17 Thread Florian Festi
Looking at the code and the history it looks like it always just matched against regular files. We probably could add another run that matches symlinks only before deleting the regular files. That way we can check the files being linked to to be proper libtool library files. -- Reply to this e

Re: [Rpm-maint] [rpm-software-management/rpm] rpm should not use short gpg key ids in messages (Issue #2403)

2024-09-17 Thread Florian Festi
Here my findings so far: ### PGP KeyID and FingerPrint usage in RPM * PGP Fingerprint: 20 or 32 bytes hash of public key (depending on key algorithm) * (Long) KeyId: last 8 bytes of Fingerprint * Short KeyId: last 4 bytes of Fingerprint Short KeyId is prone to (accidental) collisions Long KeyI

Re: [Rpm-maint] [rpm-software-management/rpm] Don't consider MD5 and SHA1 when verifying packages (PR #3293)

2024-09-13 Thread Florian Festi
Merged #3293 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3293#event-14246487852 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mail

Re: [Rpm-maint] [rpm-software-management/rpm] Phasing out obsolete crypto in rpm (#1292)

2024-09-13 Thread Florian Festi
Closed #1292 as completed via #3293. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1292#event-14246488062 You are receiving this because you commented. Message ID: ___ Rpm-maint mailing lis

[Rpm-maint] [rpm-software-management/rpm] RPM treats disabled digests and signatures equal to not being present (Issue #3303)

2024-09-13 Thread Florian Festi
This results in messages like `MD5 digest: NOTFOUND` which is confusing as the MD5 sum may just be there RPM is just not looking for it. We should at least give a message that shows we didn't even look - or may be give the status and state that it is ignored. Not sure if this is possible with th

Re: [Rpm-maint] [rpm-software-management/rpm] Don't consider MD5 and SHA1 when verifying packages (PR #3293)

2024-09-13 Thread Florian Festi
I wonder if messages like "MD5 digest: NOTFOUND" are really thing to do if we don't even look at those checksums. It's not that they were not found they were not looked for. May be we need a different message for when we ignore them. -- Reply to this email directly or view it on GitHub: https:/

Re: [Rpm-maint] [rpm-software-management/rpm] Document using Sequoia for signing (Issue #3248)

2024-09-13 Thread Florian Festi
Closed #3248 as completed via d99186f2ef6fc0dfaaefe599a98492a84fd18940. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3248#event-14245497584 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [Rpm-maint] [rpm-software-management/rpm] Document using Sequoia for signing (Issue #3248)

2024-09-13 Thread Florian Festi
Closed #3248 as completed via #3282. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3248#event-14245497561 You are receiving this because you are subscribed to this thread. Message ID: ___ R

Re: [Rpm-maint] [rpm-software-management/rpm] Support signing with Sequoia through a simple macro switch (PR #3282)

2024-09-13 Thread Florian Festi
Merged #3282 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3282#event-14245497357 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mail

Re: [Rpm-maint] [rpm-software-management/rpm] Duplicate __debug_package causes problems for spec files directly using %debug_package (Issue #3290)

2024-09-13 Thread Florian Festi
Closed #3290 as completed via #3296. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3290#event-14245298153 You are receiving this because you are subscribed to this thread. Message ID: ___ R

Re: [Rpm-maint] [rpm-software-management/rpm] Fix regression preventing manual %debug_package usage (PR #3296)

2024-09-13 Thread Florian Festi
Merged #3296 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3296#event-14245297793 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mail

Re: [Rpm-maint] [rpm-software-management/rpm] Reference Manual: RPM's Philosophy (PR #3299)

2024-09-12 Thread Florian Festi
Thanks a lot! Good to have a native speaker reading over this. Added the suggested changes. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3299#issuecomment-2346182247 You are receiving this because you are subscribed to this thread. Me

Re: [Rpm-maint] [rpm-software-management/rpm] Reference Manual: RPM's Philosophy (PR #3299)

2024-09-12 Thread Florian Festi
@ffesti pushed 1 commit. 255a8fa4647ff07a66fb4d63d41c6c54696d3293 Reference Manual: RPM's Philosophy -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/3299/files/2efe3cfb546c4f9bed0d5a8c9ab99463991d6bf8..255a8fa4647ff07a66fb4d63d41c6c54696d3293 You are receiving this bec

Re: [Rpm-maint] [rpm-software-management/rpm] Reference Manual: RPM's Philosophy (PR #3299)

2024-09-12 Thread Florian Festi
@ffesti pushed 1 commit. 2efe3cfb546c4f9bed0d5a8c9ab99463991d6bf8 Reference Manual: RPM's Philosophy -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/3299/files/82a40f72c7574400c0f7995a7497b538ca566861..2efe3cfb546c4f9bed0d5a8c9ab99463991d6bf8 You are receiving this bec

[Rpm-maint] [rpm-software-management/rpm] Reference Manual: RPM's Philosophy (PR #3299)

2024-09-11 Thread Florian Festi
First brain dump. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/3299 -- Commit Summary -- * About Reference Manual * Reference Manual: RPM's Philosophy -- File Changes -- M docs/CMakeLists.txt (2) A docs/manual

  1   2   3   4   5   6   7   8   9   10   >