Re: [Rpm-maint] [PATCH] RFC: Add build-id links to rpm for all ELF.

2016-06-02 Thread Lubos Kardos
Hi, I skimmed through your patches and they seem ok to me from a coding style point of view. I would suggest just cosmetic changes like replacing asprintf() with rasprintf() and on some places 8 spaces are used instead of tab for indentation. The problem with patches is that they move some logic

Re: [Rpm-maint] [rpm-software-management/rpm] testing GHPRB (#67)

2016-06-02 Thread Lubos Kardos
Closed #67. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/67#event-679528823___ Rpm-maint mailing list Rpm-maint@lists.rpm.org

Re: [Rpm-maint] [PATCH v9 09/13] Add file signature support to package signing

2016-05-26 Thread Lubos Kardos
Thanks for patch, I applied it. Lubos - Original Message - > From: "Thierry Vignaud" > To: "Fionnuala Gunter" > Cc: rpm-maint@lists.rpm.org, "Fin Gunter" > Sent: Wednesday, May 25, 2016 4:56:45 PM > Subject:

Re: [Rpm-maint] [PATCH 4/5] Extend header size to 64MB due to file signatures

2016-04-29 Thread Lubos Kardos
ef...@us.ibm.com> > To: "Lubos Kardos" <lkar...@redhat.com> > Cc: "Florian Festi" <ffe...@redhat.com>, rpm-maint@lists.rpm.org > Sent: Friday, April 29, 2016 1:35:35 PM > Subject: Re: [Rpm-maint] [PATCH 4/5] Extend header size to 64MB due to file > signat

Re: [Rpm-maint] [PATCH 4/5] Extend header size to 64MB due to file signatures

2016-04-29 Thread Lubos Kardos
It is just a thought. Rpm transaction can be divided in two phases. In the first phase in the beginning of transaction rpm loads all file infos to perform transactions checks and then releases them. In the second phase rpm reloads single file infos to install single packages in row. The memory

Re: [Rpm-maint] [rpm-software-management/rpm] Add RPMCALLBACK_ELEM_PROGRESS callback type (#36)

2016-04-12 Thread Lubos Kardos
Added to fedora rawhide as rpm-4.13.0-0.rc1.29.fc25 --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/36#issuecomment-208960097___

Re: [Rpm-maint] Section end markers

2016-04-05 Thread Lubos Kardos
Because there were no objections I added optional end markers upstream in commit [1]. [1] https://github.com/rpm-software-management/rpm/commit/16c658f1833f5cf9f244cb9f3465587e3bce2491 Lubos - Original Message - > From: "Neal Gompa" <ngomp...@gmail.com> > To

[Rpm-maint] Section end markers

2016-03-19 Thread Lubos Kardos
Hi, I went through the bug #564613 [1] and now I am considering add section end markers to rpm spec syntax. I would add only optional end markers to preserve backward compatibility i. e. if the end marker is not used then the end of a section is where the next section starts. So the parsing of

Re: [Rpm-maint] [rpm] Add lua function posix.redirect2null (#44)

2016-03-10 Thread Lubos Kardos
Closed #44. --- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/44#event-584851708___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm] Add lua function posix.close (#44)

2016-03-03 Thread Lubos Kardos
Yes, this solution sounds better. But maybe we should choose a better name for that function than close_stderr because close is not exactly the same as redirecting to dev/null. E.g. stdout2null() but you can come up with even better name. So if you want to modify your patch according the

Re: [Rpm-maint] [rpm] Support Apache Subversion as SCM in the BUILD arena. (#55)

2016-02-11 Thread Lubos Kardos
It can be applied also without support for compressed patches but it would be nice at least to show some error and fail build when somebody will try to use compressed patches with svn. Now no error is showed an build continues without applying patches. --- Reply to this email directly or view

Re: [Rpm-maint] [rpm] Permit dynamic selection of SCM. (#56)

2016-01-28 Thread Lubos Kardos
Closed #56. --- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/56#event-529846565___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm] Permit dynamic selection of SCM. (#56)

2016-01-28 Thread Lubos Kardos
Applied as ff30bf02b52b5de0acf1175bdc0d75ddb7028584 --- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/56#issuecomment-176238538___ Rpm-maint mailing list Rpm-maint@lists.rpm.org

Re: [Rpm-maint] [rpm] fix %doc with glob with some locales (#45)

2016-01-28 Thread Lubos Kardos
Applied as b30d6657e221a9fe606477987aeb8a02a63b9de4 --- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/45#issuecomment-176147129___ Rpm-maint mailing list Rpm-maint@lists.rpm.org

Re: [Rpm-maint] [rpm] 'quilt push' has option '-q'. (#54)

2016-01-28 Thread Lubos Kardos
Closed #54. --- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/54#event-529569788___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm] fix %doc with glob with some locales (#45)

2016-01-28 Thread Lubos Kardos
Closed #45. --- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/45#event-529570408___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm] alias -P on --provides (#47)

2016-01-28 Thread Lubos Kardos
Closed #47. --- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/47#event-529570135___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm] 'quilt push' has option '-q'. (#54)

2016-01-28 Thread Lubos Kardos
Applied as 3dbcbd1a03c8d47b5177623c2ed211dfb2d7ea71 --- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/54#issuecomment-176146981___ Rpm-maint mailing list Rpm-maint@lists.rpm.org

Re: [Rpm-maint] [rpm] Support Apache Subversion as SCM in the BUILD arena. (#55)

2016-01-28 Thread Lubos Kardos
Maybe instead of %{1} you can try <(cat) and maybe this will work also for compressed patches but I didn't tried that, just an idea. --- Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm] Rpm 4.13.x ft2 (#42)

2016-01-14 Thread Lubos Kardos
Closed #42. --- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/42#event-514949724___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm] Ft2 (#43)

2016-01-14 Thread Lubos Kardos
I modified your patch set. As Panu wrote the first two commits are not useful so I didn't apply them. There is missing include of "rpmchroot.h" and a memory leak in your third patch so I fixed that. And I also added calling of chroot for postun transaction file triggers. Whole thing I applied

Re: [Rpm-maint] [rpm] Remove size limit when expanding macros (#32)

2015-11-19 Thread Lubos Kardos
Closed #32. --- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/32#event-469070752___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm] Remove size limit when expanding macros (#32)

2015-11-19 Thread Lubos Kardos
Accepted as 61838b0fdacb71a881baac164043b8e40ddfbec5 with little modification, I created new function expandMacrosU() instead of modifying existing expandMacros() so API/ABI is not broken by this change. --- Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm] Fix fstat64 implementation conditional and define typo (#29)

2015-11-13 Thread Lubos Kardos
Closed #29. --- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/29#event-463626839___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [PATCH] do not bytecompile python scripts in docdir

2015-08-28 Thread Lubos Kardos
Applied. Thanks. Lubos - Original Message - From: Thierry Vignaud thierry.vign...@gmail.com To: rpm-maint@lists.rpm.org Sent: Friday, August 28, 2015 11:18:56 AM Subject: [Rpm-maint] [PATCH] do not bytecompile python scripts in docdir Hi This patch prevents bytecompiling python

Re: [Rpm-maint] [PATCH v9a 13/13] Add support for prompting the user for the password using pinentry

2015-08-12 Thread Lubos Kardos
- From: Mimi Zohar zo...@linux.vnet.ibm.com To: Lubos Kardos lkar...@redhat.com Cc: Fionnuala Gunter fionnuala.gun...@gmail.com, rpm-maint@lists.rpm.org, fin gunter fin.gun...@hypori.com, Mimi Zohar zo...@us.ibm.com Sent: Tuesday, August 11, 2015 5:59:13 PM Subject: Re: [PATCH v9a 13/13] Add

Re: [Rpm-maint] [dev] rpm python3 binding giving an error

2015-08-10 Thread Lubos Kardos
- Original Message - From: Thierry Vignaud thierry.vign...@gmail.com To: d...@ml.mageia.org, rpm-maint@lists.rpm.org, Lubos Kardos lkar...@redhat.com Sent: Monday, August 10, 2015 10:44:43 AM Subject: Re: [dev] rpm python3 binding giving an error On 9 August 2015 at 21:34, Olav

Re: [Rpm-maint] RPM 4.13.0-alpha released

2015-08-06 Thread Lubos Kardos
- Original Message - From: Thierry Vignaud thierry.vign...@gmail.com To: Lubos Kardos lkar...@redhat.com Cc: Florian Festi ffe...@redhat.com, rpm-maint@lists.rpm.org Sent: Wednesday, August 5, 2015 10:41:05 AM Subject: Re: [Rpm-maint] RPM 4.13.0-alpha released On 4 August 2015

Re: [Rpm-maint] RPM 4.13.0-alpha released

2015-08-04 Thread Lubos Kardos
There was a problem with rpm tests after applying those patches. We will examine this problem and we will probably include these patches in beta release. Lubos - Original Message - From: Thierry Vignaud thierry.vign...@gmail.com To: Florian Festi ffe...@redhat.com Cc:

Re: [Rpm-maint] [PATCH v7 09/11] Add file signature support to package signing

2015-07-22 Thread Lubos Kardos
- Original Message - From: Fionnuala Gunter fionnuala.gun...@gmail.com To: Lubos Kardos lkar...@redhat.com Cc: rpm-maint@lists.rpm.org, ffe...@redhat.org, Mimi Zohar zo...@linux.vnet.ibm.com, fin gunter fin.gun...@hypori.com Sent: Tuesday, July 21, 2015 9:56:19 PM Subject: Re

Re: [Rpm-maint] RFC: experiments with rich dependencies

2015-01-14 Thread Lubos Kardos
Hi, I tested this feature a little and I find the following problem. I have package testA that requires (testB | testC). I tried to installed it. # rpm -i testA-1-1.x86_64.rpm error: Failed dependencies: (testB | testC) is needed by testA-1-1.x86_64 # rpm -i testA-1-1.x86_64.rpm