Hi,
I skimmed through your patches and they seem ok to me from a coding style point
of view. I would suggest just cosmetic changes like replacing asprintf() with
rasprintf() and on some places 8 spaces are used instead of tab
for indentation.
The problem with patches is that they move some logic
Closed #67.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/67#event-679528823___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
Thanks for patch, I applied it.
Lubos
- Original Message -
> From: "Thierry Vignaud"
> To: "Fionnuala Gunter"
> Cc: rpm-maint@lists.rpm.org, "Fin Gunter"
> Sent: Wednesday, May 25, 2016 4:56:45 PM
> Subject:
ef...@us.ibm.com>
> To: "Lubos Kardos" <lkar...@redhat.com>
> Cc: "Florian Festi" <ffe...@redhat.com>, rpm-maint@lists.rpm.org
> Sent: Friday, April 29, 2016 1:35:35 PM
> Subject: Re: [Rpm-maint] [PATCH 4/5] Extend header size to 64MB due to file
> signat
It is just a thought. Rpm transaction can be divided in two phases.
In the first phase in the beginning of transaction rpm loads all file infos to
perform transactions checks and then releases them. In the second phase rpm
reloads single file infos to install single packages in row. The memory
Added to fedora rawhide as rpm-4.13.0-0.rc1.29.fc25
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/36#issuecomment-208960097___
Because there were no objections I added optional end markers upstream
in commit [1].
[1]
https://github.com/rpm-software-management/rpm/commit/16c658f1833f5cf9f244cb9f3465587e3bce2491
Lubos
- Original Message -
> From: "Neal Gompa" <ngomp...@gmail.com>
> To
Hi,
I went through the bug #564613 [1] and now I am considering add section end
markers to rpm spec syntax. I would add only optional end markers to preserve
backward compatibility i. e. if the end marker is not used then the end of
a section is where the next section starts. So the parsing of
Closed #44.
---
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/44#event-584851708___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Yes, this solution sounds better. But maybe we should choose a better name for
that function than close_stderr because close is not exactly the same as
redirecting to dev/null. E.g. stdout2null() but you can come up with even
better name. So if you want to modify your patch according the
It can be applied also without support for compressed patches but it would be
nice at least to show some error and fail build when somebody will try to use
compressed patches with svn. Now no error is showed an build continues without
applying patches.
---
Reply to this email directly or view
Closed #56.
---
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/56#event-529846565___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Applied as ff30bf02b52b5de0acf1175bdc0d75ddb7028584
---
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/56#issuecomment-176238538___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
Applied as b30d6657e221a9fe606477987aeb8a02a63b9de4
---
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/45#issuecomment-176147129___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
Closed #54.
---
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/54#event-529569788___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Closed #45.
---
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/45#event-529570408___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Closed #47.
---
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/47#event-529570135___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Applied as 3dbcbd1a03c8d47b5177623c2ed211dfb2d7ea71
---
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/54#issuecomment-176146981___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
Maybe instead of %{1} you can try <(cat) and maybe this will work also for
compressed patches but I didn't tried that, just an idea.
---
Reply to this email directly or view it on GitHub:
Closed #42.
---
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/42#event-514949724___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
I modified your patch set. As Panu wrote the first two commits are not useful
so I didn't apply them. There is missing include of "rpmchroot.h" and a memory
leak in your third patch so I fixed that. And I also added calling of chroot
for postun transaction file triggers.
Whole thing I applied
Closed #32.
---
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/32#event-469070752___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Accepted as 61838b0fdacb71a881baac164043b8e40ddfbec5 with little modification,
I created new function expandMacrosU() instead of modifying existing
expandMacros() so API/ABI is not broken by this change.
---
Reply to this email directly or view it on GitHub:
Closed #29.
---
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/29#event-463626839___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Applied. Thanks.
Lubos
- Original Message -
From: Thierry Vignaud thierry.vign...@gmail.com
To: rpm-maint@lists.rpm.org
Sent: Friday, August 28, 2015 11:18:56 AM
Subject: [Rpm-maint] [PATCH] do not bytecompile python scripts in docdir
Hi
This patch prevents bytecompiling python
-
From: Mimi Zohar zo...@linux.vnet.ibm.com
To: Lubos Kardos lkar...@redhat.com
Cc: Fionnuala Gunter fionnuala.gun...@gmail.com, rpm-maint@lists.rpm.org,
fin gunter fin.gun...@hypori.com,
Mimi Zohar zo...@us.ibm.com
Sent: Tuesday, August 11, 2015 5:59:13 PM
Subject: Re: [PATCH v9a 13/13] Add
- Original Message -
From: Thierry Vignaud thierry.vign...@gmail.com
To: d...@ml.mageia.org, rpm-maint@lists.rpm.org, Lubos Kardos
lkar...@redhat.com
Sent: Monday, August 10, 2015 10:44:43 AM
Subject: Re: [dev] rpm python3 binding giving an error
On 9 August 2015 at 21:34, Olav
- Original Message -
From: Thierry Vignaud thierry.vign...@gmail.com
To: Lubos Kardos lkar...@redhat.com
Cc: Florian Festi ffe...@redhat.com, rpm-maint@lists.rpm.org
Sent: Wednesday, August 5, 2015 10:41:05 AM
Subject: Re: [Rpm-maint] RPM 4.13.0-alpha released
On 4 August 2015
There was a problem with rpm tests after applying those patches. We
will examine this problem and we will probably include these patches
in beta release.
Lubos
- Original Message -
From: Thierry Vignaud thierry.vign...@gmail.com
To: Florian Festi ffe...@redhat.com
Cc:
- Original Message -
From: Fionnuala Gunter fionnuala.gun...@gmail.com
To: Lubos Kardos lkar...@redhat.com
Cc: rpm-maint@lists.rpm.org, ffe...@redhat.org, Mimi Zohar
zo...@linux.vnet.ibm.com, fin gunter
fin.gun...@hypori.com
Sent: Tuesday, July 21, 2015 9:56:19 PM
Subject: Re
Hi,
I tested this feature a little and I find the following problem.
I have package testA that requires (testB | testC). I tried to installed it.
# rpm -i testA-1-1.x86_64.rpm
error: Failed dependencies:
(testB | testC) is needed by testA-1-1.x86_64
# rpm -i testA-1-1.x86_64.rpm
31 matches
Mail list logo