http://rakesh.fedorapeople.org/misc/0001-Move-parsePGP-and-_print_pkts-from-rpmchecksig.c-and.patch
--
Rakesh Pandit
https://fedoraproject.org/wiki/User:Rakesh
freedom, friends, features, first
>From 5d0976a8d14a1aa763bf1c63c78f42517d835d83 Mon Sep 17 00:00:00 2001
From: Rakesh Pandit
D
--- /dev/null 2010-04-22 21:34:23.112579512 +0530
+++ /home/rakesh/project/rpm/tests/rpmtests.dir/at-groups/31/stderr
2010-04-22
22:08:23.0 +0530
@@ -0,0 +1 @@
+error: foo-1.0-1.noarch: install failed
./rpmdb.at:73: exit code was 1, expected 0
31. rpmdb.at:70: 31. rpm
On 22 April 2010 15:12, Panu Matilainen wrote:
> On Wed, 14 Apr 2010, Rakesh Pandit wrote:
>
>> Pasting corresponding patch inline.
>>
>> Link:
>> http://rakesh.fedorapeople.org/misc/0001-Removing-old-rpmpsTrim-from-rpmps.patch
>
> Applied, thanks for the patc
Pasting corresponding patch inline.
Link:
http://rakesh.fedorapeople.org/misc/0001-Removing-old-rpmpsTrim-from-rpmps.patch
--
Rakesh Pandit
https://fedoraproject.org/wiki/User:Rakesh
freedom, friends, features, first
>From 93e2cfabe045fee8ff55ec1ed9e4cea8a01918f9 Mon Sep 17 00:00:00 2
http://rakesh.fedorapeople.org/rpm/
--
Regards,
Rakesh Pandit
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
2009/6/3 Panu Matilainen wrote:
> On Fri, 24 Apr 2009, Rakesh Pandit wrote:
>
[..]
>> - { "transaction", 'T', POPT_BIT_SET|POPT_ARGFLAG_DOC_HIDDEN,
>> &giFlags, (RPMGI_TSADD|RPMGI_TSORDER),
>> + { "transaction", 'T', POP
http://rakesh.fedorapeople.org/rpm/0009-Fixed-error-handling-case-if-more-then-one-mode-is.patch
--
rakesh
>From f6ca371af55a13fe5becf9148fa3b060029708ae Mon Sep 17 00:00:00 2001
From: Rakesh Pandit
Date: Tue, 2 Jun 2009 16:38:44 +0530
Subject: [PATCH] Fixed 'error handling case'
rom c3b22a6afe54f80bb94cf0bc521617a75261a5d4 Mon Sep 17 00:00:00 2001
From: Rakesh Pandit
Date: Thu, 28 May 2009 03:41:56 +0530
Subject: [PATCH] Making showQueryPackage, rpmcliShowMatches &
rpmQueryVerify static in query.c .
---
lib/query.c |7 +++
lib/rpmcli.h
2009/5/28 Rakesh Pandit wrote:
> $subject
>
> I have kept all behavior same except that after usual db check if no
> match found check for .rpm extension and file presence with read
> access and then read from bin file. Rest flags back and continue the
> normal behaviour.
&g
-query-with-extention-.rpm-and-query-them-a.patch
All patches in serial: http://rakesh.fedorapeople.org/rpm/
--
Regards,
rakesh
>From e207b51b709fd9563c5e8425b2b7924308e616fa Mon Sep 17 00:00:00 2001
From: Rakesh Pandit
Date: Thu, 28 May 2009 00:23:14 +0530
Subject: [PATCH] Handle -q query w
2009/4/28 Rakesh Pandit wrote:
> 2009/4/28 Panu Matilainen wrote:
>> On Fri, 24 Apr 2009, Rakesh Pandit wrote:
>>
> [..]
>>
>> Might as well kick out all these unhandled FTS_FOO cases and let them fall
>> on the default case, "documenting" all the
2009/4/28 Panu Matilainen wrote:
> On Fri, 24 Apr 2009, Rakesh Pandit wrote:
>
[..]
>
> Might as well kick out all these unhandled FTS_FOO cases and let them fall
> on the default case, "documenting" all the possibilities serves little
> purpose here I think.
>
>
we do 32348+33188 = 65536 and bingo! =)
May you review this one ?
Link:
http://rakesh.fedorapeople.org/rpm/0005-Fixed-case-conversion-for-hdr-filemodes.patch
--
Regards,
Rakesh Pandit
>From b2784cc80e59daef761e56c25fa5d35a1218f573 Mon Sep 17 00:00:00 2001
From: Rakesh Pandit
Date: Sat, 2
2009/4/25 Rakesh Pandit :
[..]
> Updated:
> http://rakesh.fedorapeople.org/rpm/0001-Removed-rpmEIU-memeber-fd.patch
>
> And all following at:
> http://rakesh.fedorapeople.org/rpm/
>
> http://rakesh.fedorapeople.org/rpm/0002-Removed-xx-variable-in-rpminstall.c.patch
> http:/
2009/4/24 Panu Matilainen wrote:
> On Fri, 24 Apr 2009, Rakesh Pandit wrote:
[..]
>
> Obviously :) Just one thing: there's little point in setting fd = NULL on
> exit paths now that it's just a local variable.
>
Updated:
http://rakesh.fedorapeople.org/rpm/0001-Removed-rpm
Link:
http://rakesh.fedorapeople.org/rpm/0004-Remove-not-used-RPMGI_TSADD-and-RPMGI_TSORDER.patch
--
rakesh
>From 4f313b4a96451692a4e9defec8335264fae8b4ed Mon Sep 17 00:00:00 2001
From: Rakesh Pandit
Date: Fri, 24 Apr 2009 04:19:02 +0530
Subject: [PATCH] Remove not used RPMGI_TSADD
yeah yeah -- I am at rpmgi now, seriously :)
http://rakesh.fedorapeople.org/rpm/0003-Removing-extra-useless-break-statement-lines.patch
--
Regards,
Rakesh Pandit
>From 6dbc2c22498ecf7e1089ddb63ee428de6302af70 Mon Sep 17 00:00:00 2001
From: Rakesh Pandit
Date: Fri, 24 Apr 2009 03:05:46 +0
headerNVR and rpmtsSetNotifyCallback always return 0.
Link:
http://rakesh.fedorapeople.org/rpm/0002-Removed-useless-xx-integer-usage.patch
Removed useless 'xx' integer usage.
--
rakesh
>From e0f4e1ffe0d92bce0fb828f57f4e2bbd5f4833fb Mon Sep 17 00:00:00 2001
From: Rakesh Pandit
2009/4/23 Panu Matilainen wrote:
> On Sat, 14 Mar 2009, Rakesh Pandit wrote:
[..]
> - A further cleanup suggestion: with this patch it becomes very obvious that
> eiu->fd is only used locally in the tryReadFoo() functions and can (and
> should) be eliminated from struct rpmEIU.
>
2009/4/23 Panu Matilainen wrote:
> On Sat, 14 Mar 2009, Rakesh Pandit wrote:
[..]
> Apologies for the delay, applied now. Just a couple of remarks:
No problem.
> - Please avoid mixing unrelated things in patches no matter how small.
> For an actual code change it's not accept
2009/3/13 Panu Matilainen wrote:
> On Fri, 13 Mar 2009, Rakesh Pandit wrote:
>
[..]
>
> Hmm, rpmgiInitFilter() has:
> gi->mi = rpmdbFreeIterator(gi->mi); /* XXX odd side effect? */
>
> Looks to me like you could simply replace all the rpmdbFreeIterator()
2009/3/13 Panu Matilainen wrote:
> On Fri, 13 Mar 2009, Rakesh Pandit wrote:
[..]
Thanks for review.
> Copy-paste elimination always welcome, just some minor issues/suggestions:
>
> - Please keep alloc+free pairs "symmetric" when possible, eg
> rpmcliArgIterHelpe
2009/3/13 Panu Matilainen wrote:
> On Wed, 11 Mar 2009, Rakesh Pandit wrote:
[..]
> Looks fine to me, just an enhancement suggestion while you're at this...
> the "xx" is completely useless again as headerNVR() only ever returns with
> 0, BUT checking for nam
2009/3/13 Panu Matilainen wrote:
> On Wed, 11 Mar 2009, Rakesh Pandit wrote:
[..]
> Seems sane to me, just a minor nit:
> [pmati...@localhost rpm]$ make -j4 > /dev/null
> rpminstall.c: In function ‘tryReadHeader’:
> rpminstall.c:328: warning: unused variable ‘rc’
>
> Som
Patch:
http://rakesh.fedorapeople.org/rpm/0005--Cleanup-removing-unnecessary-repeated-code.patch
--
rakesh
>From 4c5f5b80beb924de58a2481e6529f8272bbe35a1 Mon Sep 17 00:00:00 2001
From: Rakesh Pandit
Date: Fri, 13 Mar 2009 12:50:35 +0530
Subject: [PATCH] - Cleanup: removing unnecess
eady calls when NOT RPMRC_OK
- Rearranged bit to keep the logic sane.
Patch:
http://rakesh.fedorapeople.org/rpm/0004--Removed-unnecessary-rpmdbFreeIterator-call-as-rpmg.patch
--
rakesh
>From 7cfac00225d9fdf209cb4f5dd1acc03c84be14fb Mon Sep 17 00:00:00 2001
From: Rakesh Pandit
Date: Fri, 1
2009/3/13 Rakesh Pandit :
> Just that I had been looking at usage of rpmgi in query.c did some cleanup.
>
Sorry posted the old one ... latest one:
Patch:
http://rakesh.fedorapeople.org/rpm/0003--Cleanup-Move-similar-patterns-in-rpmcliArgIter-to.patch
Just that I had been looking at usage of rpmgi in query.c did some cleanup.
Attached.
Patch:
http://rakesh.fedorapeople.org/rpm/0003--Cleanup-Move-similar-repeating-code-in-rpmcliArgI.patch
--
rakesh
>From 23ef956a28fe60c8702ec24693527c64d425a599 Mon Sep 17 00:00:00 2001
From: Rakesh Pan
Is checkFreshenStatus apt enough ?
- Moved code to check possibility of freshen operation to checkFreshenStatus.
Patch:
http://rakesh.fedorapeople.org/rpm/0002--Moved-code-to-check-possibility-of-freshen-operati.patch
--
Regards,
Rakesh Pandit
>From 3cab3dac76e2dfffbc6749b991e64032c8042
XX
rpmMkdirPath */" I could not find anything with rpmMkdirPath.
--
Regards,
Rakesh Pandit
>From 571d30a74998fc855ae5e0c53cbc7adaccca58ac Mon Sep 17 00:00:00 2001
From: Rakesh Pandit
Date: Wed, 11 Mar 2009 12:11:40 +0530
Subject: [PATCH] - Move header reading part from rpminstall to
tryReadHea
2009/2/12 Panu Matilainen wrote:
> On Thu, 12 Feb 2009, Rakesh Pandit wrote:
>
>> 2009/2/12 Panu Matilainen wrote:
>>>
>>> On Tue, 20 Jan 2009, Rakesh Pandit wrote:
>>
>> [..]
>>>
>>> That's one possible split (but something lik
2009/2/12 Panu Matilainen wrote:
> On Tue, 20 Jan 2009, Rakesh Pandit wrote:
[..]
>
> That's one possible split (but something like tryReadManifest() would be
> better name than "check manifest), another possibility might be splitting
> out both the package and manifest re
2009/2/10 Panu Matilainen wrote:
> On Mon, 19 Jan 2009, Rakesh Pandit wrote:
[..]
>> +{
>> +rpmVSFlags vsflags;
>> +
>> +if (ia->cliInterfaceFlags & (RPMCLI_UPGRADE | RPMCLI_ERASE))
>> + vsflags = rpmExpandNumeric("%{?_vsfl
2009/2/10 Panu Matilainen wrote:
> On Mon, 19 Jan 2009, Rakesh Pandit wrote:
[..]
>> Comments and suggestions ? Suggestions on Naming of functions are also
>> welcome ?
>
> Seems ok to me. I guess I should start dusting off my erasure progress
> patches, or at least
2009/2/10 Panu Matilainen wrote:
> On Thu, 15 Jan 2009, Rakesh Pandit wrote:
[..]
>>
>> - Merge rpmInstallInterfaceFlags_e and rpmEraseInterfaceFlags_e to
>> rpmCliInterfaceFlags_e.
>> - Renamed (UN)?INSTALL_* to RPMCLI_* and all corresponding changes in
>>
2009/1/20 Rakesh Pandit :
> - /* Read list of packages from manifest. */
> -/* FIX: *eiu->argv can be NULL */
> - rc = rpmReadPackageManifest(eiu->fd, &eiu->argc, &eiu->argv);
Removed "/* FIX: *eiu->argv can be NULL */"
Well, I have done a cas
$subject
Moving out parts which can be logically separated slowly out of
rpmInstall. That will make this beast function more clean,
maintainable and at some point we can untangle the complex flow it
uses (using labels) to simple algorithm giving us some chance to think
about solving some more comp
Move notify flag settings from rpmInstall and rpmErase to rpmSetNotifyFlag.
As you can see
-rpmVSFlags rpmSetVSFlags(struct rpmInstallArguments_s * ia)
+static rpmVSFlags rpmSetVSFlags(struct rpmInstallArguments_s * ia)
and
+static void rpmSetNotifyFlag(struct rpmInstallArguments_s * ia,
+
2009/1/19 Rakesh Pandit :
> This patch moves vsflags calculations from rpmInstall and rpmErase to
> new local function rpmSetVSFlags
>
Forgot to mention that this is in the series of patches sent earlier
i.e would only apply cleanly after applying 3 patches sent earlier.
--
Regards
Rake
This patch moves vsflags calculations from rpmInstall and rpmErase to
new local function rpmSetVSFlags
Comments and suggestions ?
Link:
http://rakesh.fedorapeople.org/misc/0001--Move-vsflags-calculation-from-rpmInstall-and-rpmEra.patch
--
rakesh
diff --git a/lib/rpminstall.c b/lib/rpminstall.
ve-stopinstall-variable-and-moved-rpmcliPackage.patch
Attached are files.
--
rakesh
From f01e1e5ad5294f8cbddb9fe240bfd74a33d890ba Mon Sep 17 00:00:00 2001
From: Rakesh Pandit
Date: Thu, 15 Jan 2009 22:20:42 +0530
Subject: [PATCH] - Merge rpmInstallInterfaceFlags_e and rpmEraseInter
2008/12/3 Rakesh Pandit <[EMAIL PROTECTED]>:
> + rpmcliPackagesTotal += eiu->numSRPMS;
>continue;
Though it was already in wrong place ... I put it in another wrong
place ... fixed below. Also reused rpmInstallSource for MODE_INSTALL.
It was just used for M
2008/12/3 Rakesh Pandit <[EMAIL PROTECTED]>:
[..]
> Snippet:
> +rpmCliInterfaceFlags installInterfaceFlags;
> +rpmCliInterfaceFlags eraseInterfaceFlags;
>
It was trivial then I thought. /my mistake.
--
rakesh
commit ee63a0aa4b278beb2bf3f9d18bfc384f3ec0c728
Author: Rak
Hello list
Second patch[1]:
Moved transaction part from rpmInstall and rpmErase to rpmCliTransaction.
[1] http://rakesh.fedorapeople.org/misc/second.patch
Review ?
--
Regards,
rakesh
commit fe17d655c5c45a164be2f3802007837b8724a93e
Author: =Rakesh Pandit <[EMAIL PROTECTED]>
Date: T
Just finished couple of coherent patches. First one below (link [2]):
[1] http://rpm.org/wiki/Problems/Upgrade
[2] http://rakesh.fedorapeople.org/misc/first.patch
Review ?
--
Regards,
rakesh
commit 31819876ac11f88e71cd777cf039611e096aa4d4
Author: =Rakesh Pandit <[EMAIL PROTECTED]>
Date:
2008/10/27 Rakesh Pandit <[EMAIL PROTECTED]>:
> $subject
db-4.6.21 worked.
Sorry for noise.
--
rakesh
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
$subject
/bin/sh ./libtool --mode=link cc -g -O2 -fPIC -DPIC -D_REENTRANT -Wall
-Wpointer-arith -Wmissing-prototypes -Wno-char-subscripts
-fno-strict-aliasing -fstack-protector -o berkeley_db_svc \
db_server_proc.lo db_server_svc.lo db_server_util.lo
gen_db_server.lo util_log.lo libd
47 matches
Mail list logo
