2009/4/25 Rakesh Pandit :
[..]
> Updated:
> http://rakesh.fedorapeople.org/rpm/0001-Removed-rpmEIU-memeber-fd.patch
>
> And all following at:
> http://rakesh.fedorapeople.org/rpm/
>
> http://rakesh.fedorapeople.org/rpm/0002-Removed-xx-variable-in-rpminstall.c.patch
> http://rakesh.fedorapeople.org/
2009/4/24 Panu Matilainen wrote:
> On Fri, 24 Apr 2009, Rakesh Pandit wrote:
[..]
>
> Obviously :) Just one thing: there's little point in setting fd = NULL on
> exit paths now that it's just a local variable.
>
Updated:
http://rakesh.fedorapeople.org/rpm/0001-Removed-rpmEIU-memeber-fd.patch
And
On Fri, 24 Apr 2009, Rakesh Pandit wrote:
2009/4/23 Panu Matilainen wrote:
On Sat, 14 Mar 2009, Rakesh Pandit wrote:
[..]
- A further cleanup suggestion: with this patch it becomes very obvious that
eiu->fd is only used locally in the tryReadFoo() functions and can (and
should) be eliminated
2009/4/23 Panu Matilainen wrote:
> On Sat, 14 Mar 2009, Rakesh Pandit wrote:
[..]
> - A further cleanup suggestion: with this patch it becomes very obvious that
> eiu->fd is only used locally in the tryReadFoo() functions and can (and
> should) be eliminated from struct rpmEIU.
>
This one:
http:/
2009/4/23 Panu Matilainen wrote:
> On Sat, 14 Mar 2009, Rakesh Pandit wrote:
[..]
> Apologies for the delay, applied now. Just a couple of remarks:
No problem.
> - Please avoid mixing unrelated things in patches no matter how small.
> For an actual code change it's not acceptable, but in this ca
On Sat, 14 Mar 2009, Rakesh Pandit wrote:
2009/3/13 Panu Matilainen wrote:
On Wed, 11 Mar 2009, Rakesh Pandit wrote:
[..]
Seems sane to me, just a minor nit:
[pmati...@localhost rpm]$ make -j4 > /dev/null
rpminstall.c: In function ‘tryReadHeader’:
rpminstall.c:328: warning: unused variable ‘r
2009/3/13 Panu Matilainen wrote:
> On Wed, 11 Mar 2009, Rakesh Pandit wrote:
[..]
> Seems sane to me, just a minor nit:
> [pmati...@localhost rpm]$ make -j4 > /dev/null
> rpminstall.c: In function ‘tryReadHeader’:
> rpminstall.c:328: warning: unused variable ‘rc’
>
> Somewhat related thing (not int
On Wed, 11 Mar 2009, Rakesh Pandit wrote:
Is tryReadHeader a good name ?
- Move header reading part from rpminstall to tryReadHeader function.
Patch:
http://rakesh.fedorapeople.org/rpm/0001--Move-header-reading-part-from-rpminstall-to-tryRea.patch
*Patch also involves removal of "-#include "
Is tryReadHeader a good name ?
- Move header reading part from rpminstall to tryReadHeader function.
Patch:
http://rakesh.fedorapeople.org/rpm/0001--Move-header-reading-part-from-rpminstall-to-tryRea.patch
*Patch also involves removal of "-#include "lib/misc.h" /* XXX
rpmMkdirPath */" I
