Re: [Rpm-maint] [PATCH] Unbreak short-circuited binary builds

2017-01-05 Thread Mark Wielaard
On Thu, Jan 05, 2017 at 03:40:42PM +0200, Panu Matilainen wrote: > > > When checking for pre-existing links see if they already point to > > > the right file and in that case just reuse it instead of creating new > > > ones. > > > > > @@ -1572,6 +1573,16 @@ static int addNewIDSymlink(FileList fl,

Re: [Rpm-maint] [PATCH] Unbreak short-circuited binary builds

2017-01-05 Thread Panu Matilainen
On 01/05/2017 02:50 PM, Mark Wielaard wrote: On Thu, Jan 05, 2017 at 01:47:28PM +0200, Panu Matilainen wrote: Commit bbfe1f86b2e4b5c0bd499d9f3dd9de9c9c20fff2 broke short-circuited binary builds (which can be handy for testing when working on large packages), eg: rpmbuild -bi foo.spec; rpmbu

Re: [Rpm-maint] [PATCH] Unbreak short-circuited binary builds

2017-01-05 Thread Mark Wielaard
On Thu, Jan 05, 2017 at 01:47:28PM +0200, Panu Matilainen wrote: > Commit bbfe1f86b2e4b5c0bd499d9f3dd9de9c9c20fff2 broke short-circuited > binary builds (which can be handy for testing when working on large > packages), eg: > rpmbuild -bi foo.spec; rpmbuild -bb --short-circuit foo.spec > > Th

[Rpm-maint] [PATCH] Unbreak short-circuited binary builds

2017-01-05 Thread Panu Matilainen
Commit bbfe1f86b2e4b5c0bd499d9f3dd9de9c9c20fff2 broke short-circuited binary builds (which can be handy for testing when working on large packages), eg: rpmbuild -bi foo.spec; rpmbuild -bb --short-circuit foo.spec The problem is that in a short-circuited build all the links already exist and