Re: [Rpm-maint] [PATCH] perl.{prov,req} improvments

2014-09-23 Thread Jerome Quelin
On 14/09/17 10:53 +0200, Thierry Vignaud wrote: > >> support-for-_-in-perl-module-version.diff: > >> support for _ in perl module version > > > > This looks fairly obvious, too obvious in fact. Makes me wonder if its being > > omitted on purpose, but I've not a "perl person" and haven't got a clue

Re: [Rpm-maint] [PATCH] perl.{prov,req} improvments

2014-09-18 Thread Ville Skyttä
On Thu, Sep 18, 2014 at 1:38 PM, Michael Schroeder wrote: > > Well, 0.95_01 is actually more correct than 0.9501. Perl's versions > are actually more or less floating point numbers, thus 0.9501 is > supposed to be less than 0.96. > > From rpm's side, '_' is exactly equivalent to '.', so 0.95_01 is

Re: [Rpm-maint] [PATCH] perl.{prov,req} improvments

2014-09-18 Thread Michael Schroeder
On Thu, Sep 18, 2014 at 01:27:17PM +0300, Ville Skyttä wrote: > On Thu, Sep 18, 2014 at 9:38 AM, Jerome Quelin wrote: > > This patch only acknowledges this fact, and allows _ in versions. > > This results in the underscores also ending up in the Provides. I > don't think that's a good thing as II

Re: [Rpm-maint] [PATCH] perl.{prov,req} improvments

2014-09-18 Thread Ville Skyttä
On Thu, Sep 18, 2014 at 9:38 AM, Jerome Quelin wrote: > This patch only acknowledges this fact, and allows _ in versions. This results in the underscores also ending up in the Provides. I don't think that's a good thing as IIRC rpm's version comparison does not treat it the same way as perl does.

Re: [Rpm-maint] [PATCH] perl.{prov,req} improvments

2014-09-17 Thread Thierry Vignaud
On 17 September 2014 10:39, Panu Matilainen wrote: Mageia just switched to internal deps generator (at least). >> In the process, I unforked as most scripts as possible. >> Here's some old fixes: >> >> skip-plain-regular-comments.diff: >> just skip plain, regular perl comments... > > > What's the

Re: [Rpm-maint] [PATCH] perl.{prov,req} improvments

2014-09-17 Thread Panu Matilainen
On 09/15/2014 06:01 PM, Thierry Vignaud wrote: Hi Mageia just switched to internal deps generator (at least). In the process, I unforked as most scripts as possible. Here's some old fixes: skip-plain-regular-comments.diff: just skip plain, regular perl comments... What's the reproducer for th

[Rpm-maint] [PATCH] perl.{prov,req} improvments

2014-09-15 Thread Thierry Vignaud
Hi Mageia just switched to internal deps generator (at least). In the process, I unforked as most scripts as possible. Here's some old fixes: skip-plain-regular-comments.diff: just skip plain, regular perl comments... support-for-_-in-perl-module-version.diff: support for _ in perl module versio