Re: [Rpm-maint] [rpm] Fix symlinks for installations outside /usr/bin (#60)

2016-02-25 Thread Florian Festi
Pushed upstream. No idea why Github doesn't get it this time. --- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/60#issuecomment-188680860___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://li

Re: [Rpm-maint] [rpm] Fix symlinks for installations outside /usr/bin (#60)

2016-02-25 Thread Florian Festi
Closed #60. --- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/60#event-565220329___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm] Fix symlinks for installations outside /usr/bin (#60)

2016-02-21 Thread ニール・ゴンパ
@petere After testing the patch, it seems like it's fine to me. I'm okay with it entering as-is. :+1: --- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/60#issuecomment-186955079___ Rpm-maint mail

Re: [Rpm-maint] [rpm] Fix symlinks for installations outside /usr/bin (#60)

2016-02-19 Thread Peter Eisentraut
@Conan-Kudo The current implementation uses relative symlinks. The Fedora packaging guidelines don't have a strong opinion on what kind of symlink should be used, but I was trying to preserve the existing kind. (Debian policy would call for a relative symlink here, FWIW.) --- Reply to this ema

Re: [Rpm-maint] [rpm] Fix symlinks for installations outside /usr/bin (#60)

2016-02-19 Thread Peter Eisentraut
@ffesti That would certainly make things simpler. --- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/60#issuecomment-186496903___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/

Re: [Rpm-maint] [rpm] Fix symlinks for installations outside /usr/bin (#60)

2016-02-18 Thread ニール・ゴンパ
@ffesti What I was suggesting is that perhaps the following might solve the problem better: ``` @rm -f $(DESTDIR)$(rpmbindir)/rpmquery @LN_S@ -f $(rpmbindir)/rpm $(DESTDIR)$(rpmbindir)/rpmquery @rm -f $(DESTDIR)$(rpmbindir)/rpmverify @LN_S@ -f $(rpmbindir)/rpm $(DESTDIR)$(rpmbindir)/rpmverify ```

Re: [Rpm-maint] [rpm] Fix symlinks for installations outside /usr/bin (#60)

2016-02-18 Thread Florian Festi
May be I should have been more clear: What about @rm -f $(DESTDIR)$(rpmbindir)/rpmquery @LN_S@ rpm $(DESTDIR)$(rpmbindir)/rpmquery @rm -f $(DESTDIR)$(rpmbindir)/rpmverify @LN_S@ rpm $(DESTDIR)$(rpmbindir)/rpmverify ? --- Reply to this email directly or view it on GitHub: https://github.com/rp

Re: [Rpm-maint] [rpm] Fix symlinks for installations outside /usr/bin (#60)

2016-02-16 Thread ニール・ゴンパ
@ffesti The actual problem is that `/bin/rpm` isn't valid when you install to `/usr/local`, and the symlinks unconditionally assume rpm is being installed systemwide. --- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/60#issuecomment-184723

Re: [Rpm-maint] [rpm] Fix symlinks for installations outside /usr/bin (#60)

2016-02-16 Thread Florian Festi
I wonder if the easier way to fix this is to actually move the two symlinks to the same directory as the rpm binary... --- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/60#issuecomment-184661007__

[Rpm-maint] [rpm] Fix symlinks for installations outside /usr/bin (#60)

2016-02-15 Thread Peter Eisentraut
rpmquery and rpmverify are symlinks to rpm. The former are usually installed in /usr/bin, the latter in /bin, so the symlink points to ../../bin/rpm. But for installations into other prefixes, the synlimk should just point to the same directory. You can view, comment on, or merge this pull reques