Merged #862 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/862#event-2664403059___
Rpm-maint mailing list
pmatilai approved this pull request.
Thanks. The danger with including the command at all is that people will think
the command failed, but considering I don't think anybody has ever *seen* this
fail in the first place, maybe we can live with the "danger" :D
--
You are receiving this
Commit message is corrected according to @pmatilai's comment.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@pavlinamv pushed 1 commit.
75ec68392ece1006f1543bd556f64199257b6b32 Add an error message when rpm fails
to open a pipe for shell expansion
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
Right, I noticed but forgot to mention setting mb->error becoming redundant,
thanks.
As for the error message, if you grep around a bit you'll notice that the
common pattern for these things is:
::
...where is a file name or similar, and in this case it'd be the macro,
and is the
@pavlinamv pushed 1 commit.
e2677384cde95e69e14979ccac8936874c376652 Add an error message when rpm fails
to open a pipe for shell expansion
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
Removed unnecessary "mb->error = 1;" line.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/862#issuecomment-535370536___
Changed (added the command it's trying to execute and strerror(errno)).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@pavlinamv pushed 1 commit.
0226f7c190326c6ab1d7a82f4143fe7e7928192a Add an error message when rpm fails
to open a pipe for shell expansion
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
Yup, an error message is indeed missing there. The message lacks context
though, might want to add the command it's trying to execute to give both the
user and the developer who gets bugged a little bit of context as to what rpm
was trying to do (although the command itself has little to do
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/862
-- Commit Summary --
* Add an error message when rpm fails to open a pipe for shell expansion
-- File Changes --
M rpmio/macro.c (1)
-- Patch Links --
11 matches
Mail list logo
