Mark, thanks for reviewing and Pavlina for the patch.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/643#issuecomment-475143144___
Rpm-maint mailing
Merged #643 into master.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/643#event-2219010387___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http:
On Tue, 2019-03-19 at 12:30 +, pavlinamv wrote:
> Thank you very much for the review. According of the review I added
> changes in two places:
> - in documentation: explicitly say "ONLY on DSOs" to make clear how
> it differs from -g. (as Mark wrote) and add that options -g and --g-
> libs are
Sorry, I did a wrong alignment in the previous comment. Corrected:
Thank you very much for the review. According of the review I added changes in
two places:
- in documentation: explicitly say "ONLY on DSOs" to make clear how it differs
from -g. (as Mark wrote) and add that options -g and --g-l
Thank you very much for the review. According of the review I added changes on
two places:
- in documentation
+ explicitly say "ONLY on DSOs" to make clear how it differs from -g. (as Mark
wrote)
+ add a sentence that options -g and --g-libs are mutually exclusive
- add an error if the user gi
On Sat, 2019-03-16 at 22:56 -0700, pavlinamv wrote:
> From 960860164a3c5277d3a31cbf73e60c1d4a16 Mon Sep 17 00:00:00 2001
> From: Pavlina Moravcova Varekova
> Date: Sun, 17 Mar 2019 06:47:26 +0100
> Subject: [PATCH] Add flag to use strip -g instead of full strip on DSOs
> (RhBug:1663264)
>
>
On Mon, 2019-03-18 at 15:40 +0100, Mark Wielaard wrote:
> Alternatively since -g-libs is a subset of "full" -g we might simply
> set strip_g=true if just -g is given. That might need a code tweak
> below though.
boo. now I am confusing myself... sorry.
I meant: "we might simply set strip_glibs=tru
Thank you for the review. The commit message is extended.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/643#issuecomment-473912473_
A commit message is missing.
Pointing to original bug report is good and even necessary, but not enough. The
commit messages need to be self-sufficient, people must be able to understand
the issue and the change without following any external links.
--
You are receiving this because you are su
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/643
-- Commit Summary --
* Add flag to use strip -g instead of full strip on DSOs (RhBug:1663264)
-- File Changes --
M scripts/find-debuginfo.sh (20)
-- Patch Links --
10 matches
Mail list logo
