Re: [Rpm-maint] [rpm-software-management/rpm] Add support for new package declarations in Perl 5.12+ (#237)

2017-06-28 Thread Panu Matilainen
Excellent, thanks! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/237#issuecomment-311594948___ Rpm-maint mailing list Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for new package declarations in Perl 5.12+ (#237)

2017-06-28 Thread Panu Matilainen
Merged #237. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/237#event-1141936354___ Rpm-maint mailing list Rpm-maint@lists.rpm.o

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for new package declarations in Perl 5.12+ (#237)

2017-06-28 Thread Sebastian Riedel
@pmatilai And added to the commit message. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/237#issuecomment-311590943___ Rpm-main

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for new package declarations in Perl 5.12+ (#237)

2017-06-28 Thread Panu Matilainen
Comments in code tend to grow mold, but the description of this PR belongs to the commit message instead. GH is not eternal, git logs are ;) Please update the commit message to include the information about the new syntaxes and versions etc currently only provided here. -- You are receiving th

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for new package declarations in Perl 5.12+ (#237)

2017-06-17 Thread Sebastian Riedel
@Conan-Kudo Any suggestions for what those comments should say instead? As far as i can see they are still just as accurate as before. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-managemen

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for new package declarations in Perl 5.12+ (#237)

2017-06-17 Thread ニール・ゴンパ
Conan-Kudo requested changes on this pull request. The code looks okay, but the comments in the file might need updating the reflect what's been changed. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for new package declarations in Perl 5.12+ (#237)

2017-06-16 Thread Igor Gnatenko
ignatenkobrain approved this pull request. Sadly we have no tests for that, but code looks good. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/237#pullrequestreview-445

[Rpm-maint] [rpm-software-management/rpm] Add support for new package declarations in Perl 5.12+ (#237)

2017-06-16 Thread Sebastian Riedel
This is a [patch](https://build.opensuse.org/package/view_file/Base:System/rpm/perlprov-package.diff) we apply to rpm in openSUSE. It allows the `perl.prov` script to detect new variants of Perl package declarations that have been added in recent years. In [Perl 5.12](https://metacpan.org/pod/