Re: [Rpm-maint] [rpm-software-management/rpm] Always use unified diff format in check-files (#928)

2019-11-07 Thread Panu Matilainen
pmatilai requested changes on this pull request. You can see what is changed by simply looking at the diff, but the all important *what does it do* and *why* is this change needed are completely missing in the commit message. There's also a portability concern here: the reason for using non-un

Re: [Rpm-maint] [rpm-software-management/rpm] Always use unified diff format in check-files (#928)

2019-11-06 Thread ニール・ゴンパ
Conan-Kudo approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/928#pullrequestreview-312588583___ Rpm

Re: [Rpm-maint] [rpm-software-management/rpm] Always use unified diff format in check-files (#928)

2019-11-06 Thread elros34
Done -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/928#issuecomment-550397650___ Rpm-maint mailing list Rpm-maint@lists.rpm.org