I think we already decided. What remains is documenting it.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2477#issuecomment-1718851964
You are receiving this because you are subscribed to this thread.
Message ID:
> Let's stick with the number approach for the alpha and sort out the bigger
> versioning question for the beta
Ack :smile:
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2477#issuecomment-1504941632
You are receiving this because
I'd totally forgotten we used alpha in the 4.18 tarball name, in all previous
versions it was just the "raw" 4.x.90 number instead :laughing: Let's stick
with the number approach for the alpha and sort out the bigger versioning
question for the beta (so bumping milestone)
--
Reply to this
Technically it's not much of an issue, our alphas have traditionally been
versioned (both the tarball and project version) x.y-1.90 anyway. So 90 means
alpha already, 91 can just as well mean beta. Rc is a "problem" because you'd
really want to have it at the final number already, but clearly
So cmake allows -rcN for itself, but not for projects created by it. Eh...
``
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2477#issuecomment-1504696693
You are receiving this because you are subscribed to this thread.
Message ID:
Crap... Of course it doesn't work, `CMAKE_VERSION` is for the CMake version,
not the project's version :facepalm:
The correct docs are here:
https://cmake.org/cmake/help/latest/command/project.html#options
--
Reply to this email directly or view it on GitHub:
OK, re-reading the docs, our original format *actually* should be legal, the
`-rc` is there just as an example of how CMake itself does it. Yet, none of
that seems to be working for me... I also tried putting the whole string in
quotes but no dice.
--
Reply to this email directly or view it
Lastly, according to the
[docs](https://cmake.org/cmake/help/v3.18/variable/CMAKE_VERSION.html), the
following should also be valid:
`4.18.20231104-alpha1`
However, that doesn't work for me for some reason (CMake 3.26 here).
--
Reply to this email directly or view it on GitHub:
... or just keep `4.18.90` and increment the fourth component for each
pre-release, regardless of whether it's an alpha, beta or rc.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2477#issuecomment-1503586306
You are receiving this
Maybe we could just keep the `4.18.90` version for these pre-releases, or
perhaps something like `4.18.90.1` for alpha1, `4.18.90.2` for alpha2, etc.
then `4.18.91` for beta1, etc.
--
Reply to this email directly or view it on GitHub:
It seems like our original pre-release numbering, e.g. `4.19.0-alpha1`, isn't
compatible with the format of `CMAKE_VERSION`, which only allows integers in
the version components, and optionally takes the `-rc` suffix.
Possibly related: https://gitlab.kitware.com/cmake/cmake/-/issues/16716
We
11 matches
Mail list logo
