Re: [Rpm-maint] [rpm-software-management/rpm] Correct rpm -ql exit value when optional -p is omitted (RhBug:1680610) (#641)

2019-03-18 Thread Panu Matilainen
Merged #641 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/641#event-2209704862___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Correct rpm -ql exit value when optional -p is omitted (RhBug:1680610) (#641)

2019-03-18 Thread Panu Matilainen
Merged, thanks. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/641#issuecomment-473830137___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Correct rpm -ql exit value when optional -p is omitted (RhBug:1680610) (#641)

2019-03-14 Thread pavlinamv
I (hopefully) incorporated all comments from Florian and Panu. The line with a manual calculation is not a part of the 2 patches now. Thus I added the third patch to change it (on 2 places in the query file - to be consistent). If you think that the last commit should not be used, I am fine

Re: [Rpm-maint] [rpm-software-management/rpm] Correct rpm -ql exit value when optional -p is omitted (RhBug:1680610) (#641)

2019-03-14 Thread Panu Matilainen
- Use rpmFileHasSuffix() instead of manual calculation (yes I know you're not adding the calculation, but might as well get rid of it while touching the code) - Pretty please, no numbered variables unless the number is a meaningful part of the of the name (eg in coordinates x1, y1, x2, y2 are

Re: [Rpm-maint] [rpm-software-management/rpm] Correct rpm -ql exit value when optional -p is omitted (RhBug:1680610) (#641)

2019-03-13 Thread pavlinamv
An additional commit is added for correcting -ql output for multiple rpm files if -p is omitted. (Thus the PR does not exactly correspond to its name). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[Rpm-maint] [rpm-software-management/rpm] Correct rpm -ql exit value when optional -p is omitted (RhBug:1680610) (#641)

2019-03-12 Thread pavlinamv
Additionally if a package query with the argument was successful, there is no need to rpm query of the argument. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/641 -- Commit Summary -- * Correct rpm -ql exit value when