Re: [Rpm-maint] [rpm-software-management/rpm] Don't brp-strip .ko files (#1744)

2021-07-12 Thread ニール・ゴンパ
@Conan-Kudo commented on this pull request. > @@ -13,5 +13,5 @@ Darwin*) exit 0 ;; esac # Strip ELF binaries -find "$RPM_BUILD_ROOT" -type f \! -regex "${RPM_BUILD_ROOT}/*usr/lib/debug.*" -print0 | \ +find "$RPM_BUILD_ROOT" -type f \! -regex "${RPM_BUILD_ROOT}/*usr/lib/debug.*" \! -name "*

Re: [Rpm-maint] [rpm-software-management/rpm] Don't brp-strip .ko files (#1744)

2021-07-12 Thread ニール・ゴンパ
@Conan-Kudo commented on this pull request. > @@ -13,5 +13,5 @@ Darwin*) exit 0 ;; esac # Strip ELF binaries -find "$RPM_BUILD_ROOT" -type f \! -regex "${RPM_BUILD_ROOT}/*usr/lib/debug.*" -print0 | \ +find "$RPM_BUILD_ROOT" -type f \! -regex "${RPM_BUILD_ROOT}/*usr/lib/debug.*" \! -name "*

Re: [Rpm-maint] [rpm-software-management/rpm] Don't brp-strip .ko files (#1744)

2021-07-12 Thread Michal Domonkos
Yup, that's correct - they would be skipped by the loop anyway (and calling `strip(1)` on them would have no effect either). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull

Re: [Rpm-maint] [rpm-software-management/rpm] Don't brp-strip .ko files (#1744)

2021-07-12 Thread mikhailnov
Ah, sorry, such files probably will not be detected as ELFs -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1744#issuecomment-878384188__

Re: [Rpm-maint] [rpm-software-management/rpm] Don't brp-strip .ko files (#1744)

2021-07-12 Thread mikhailnov
Kernel modules may be *.ko.xz, *.ko.zst, *.ko.gz -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1744#issuecomment-878383675___ R

Re: [Rpm-maint] [rpm-software-management/rpm] Don't brp-strip .ko files (#1744)

2021-07-12 Thread Florian Festi
Merged #1744 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1744#event-5006995636___ Rpm-maint mailing list Rpm-mai

[Rpm-maint] [rpm-software-management/rpm] Don't brp-strip .ko files (#1744)

2021-07-12 Thread Michal Domonkos
Otherwise SecureBoot signatures may be stripped too. We used to exclude shared libraries from this strip as they were supposed to be covered by another brp script (brp-strip-shared), however it turned out the latter was never really used, so we removed the exclusion in commit 0ab151ab138fd4fb6d317