Re: [Rpm-maint] [rpm-software-management/rpm] Don't rely on pkg-config for libmagic just yet (PR #2468)

2023-04-11 Thread Panu Matilainen
Merged #2468 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2468#event-8971922783 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Don't rely on pkg-config for libmagic just yet (PR #2468)

2023-04-11 Thread Panu Matilainen
Quite annoying to have pkg-config on this and then lose it :smiling_face_with_tear: -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2468#issuecomment-1503068299 You are receiving this because you are subscribed to this thread. Message

Re: [Rpm-maint] [rpm-software-management/rpm] Don't rely on pkg-config for libmagic just yet (PR #2468)

2023-04-11 Thread Michal Domonkos
@dmnks pushed 1 commit. 53bf68a3c6f54164ef330953ab5066e4b97c8f8e Don't rely on pkg-config for libmagic just yet -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2468/files/ebf33aaee5e02020b6d48485e58653e91ce1a3e3..53bf68a3c6f54164ef330953ab5066e4b97c8f8e You are

Re: [Rpm-maint] [rpm-software-management/rpm] Don't rely on pkg-config for libmagic just yet (PR #2468)

2023-04-11 Thread Michal Domonkos
OK, imported target it is, and using REQUIRED now that we're on 3.18 :smile: -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2468#issuecomment-1503040475 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] Don't rely on pkg-config for libmagic just yet (PR #2468)

2023-04-11 Thread Michal Domonkos
@dmnks pushed 1 commit. ebf33aaee5e02020b6d48485e58653e91ce1a3e3 Don't rely on pkg-config for libmagic just yet -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2468/files/94e2a6628918fbd5cb30addf1d4b967743810423..ebf33aaee5e02020b6d48485e58653e91ce1a3e3 You are

Re: [Rpm-maint] [rpm-software-management/rpm] Don't rely on pkg-config for libmagic just yet (PR #2468)

2023-04-06 Thread Panu Matilainen
@pmatilai commented on this pull request. > pkg_check_modules(READLINE IMPORTED_TARGET readline) pkg_check_modules(ZSTD IMPORTED_TARGET libzstd>=1.3.8) pkg_check_modules(LIBELF IMPORTED_TARGET libelf) pkg_check_modules(LIBDW IMPORTED_TARGET libdw) pkg_check_modules(LIBLZMA IMPORTED_TARGET

Re: [Rpm-maint] [rpm-software-management/rpm] Don't rely on pkg-config for libmagic just yet (PR #2468)

2023-04-06 Thread Michal Domonkos
@dmnks commented on this pull request. > pkg_check_modules(READLINE IMPORTED_TARGET readline) pkg_check_modules(ZSTD IMPORTED_TARGET libzstd>=1.3.8) pkg_check_modules(LIBELF IMPORTED_TARGET libelf) pkg_check_modules(LIBDW IMPORTED_TARGET libdw) pkg_check_modules(LIBLZMA IMPORTED_TARGET

Re: [Rpm-maint] [rpm-software-management/rpm] Don't rely on pkg-config for libmagic just yet (PR #2468)

2023-04-06 Thread Panu Matilainen
@pmatilai commented on this pull request. > pkg_check_modules(READLINE IMPORTED_TARGET readline) pkg_check_modules(ZSTD IMPORTED_TARGET libzstd>=1.3.8) pkg_check_modules(LIBELF IMPORTED_TARGET libelf) pkg_check_modules(LIBDW IMPORTED_TARGET libdw) pkg_check_modules(LIBLZMA IMPORTED_TARGET

Re: [Rpm-maint] [rpm-software-management/rpm] Don't rely on pkg-config for libmagic just yet (PR #2468)

2023-04-06 Thread Michal Domonkos
@dmnks commented on this pull request. > pkg_check_modules(READLINE IMPORTED_TARGET readline) pkg_check_modules(ZSTD IMPORTED_TARGET libzstd>=1.3.8) pkg_check_modules(LIBELF IMPORTED_TARGET libelf) pkg_check_modules(LIBDW IMPORTED_TARGET libdw) pkg_check_modules(LIBLZMA IMPORTED_TARGET

Re: [Rpm-maint] [rpm-software-management/rpm] Don't rely on pkg-config for libmagic just yet (PR #2468)

2023-04-06 Thread Michal Domonkos
@dmnks commented on this pull request. > pkg_check_modules(READLINE IMPORTED_TARGET readline) pkg_check_modules(ZSTD IMPORTED_TARGET libzstd>=1.3.8) pkg_check_modules(LIBELF IMPORTED_TARGET libelf) pkg_check_modules(LIBDW IMPORTED_TARGET libdw) pkg_check_modules(LIBLZMA IMPORTED_TARGET

Re: [Rpm-maint] [rpm-software-management/rpm] Don't rely on pkg-config for libmagic just yet (PR #2468)

2023-04-06 Thread Panu Matilainen
@pmatilai commented on this pull request. > pkg_check_modules(READLINE IMPORTED_TARGET readline) pkg_check_modules(ZSTD IMPORTED_TARGET libzstd>=1.3.8) pkg_check_modules(LIBELF IMPORTED_TARGET libelf) pkg_check_modules(LIBDW IMPORTED_TARGET libdw) pkg_check_modules(LIBLZMA IMPORTED_TARGET

[Rpm-maint] [rpm-software-management/rpm] Don't rely on pkg-config for libmagic just yet (PR #2468)

2023-04-05 Thread Michal Domonkos
This fixes a regression from automake where we also didnt use pkg-config for libmagic. Fixes: #2246 You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/2468 -- Commit Summary -- * Dont rely on pkg-config for libmagic just yet