Re: [Rpm-maint] [rpm-software-management/rpm] Drop slen from builtin macro parser function (#839)

2019-09-18 Thread Panu Matilainen
pmatilai approved this pull request. Right, I guess the only case where %define/%global can be followed by something is the "silent grouping" with {} eg ```rpm --eval "%define foo {bar} %{warn:issue}" --eval "%foo"``` and that behavior doesn't change here. -- You are receiving this because

Re: [Rpm-maint] [rpm-software-management/rpm] Drop slen from builtin macro parser function (#839)

2019-09-18 Thread Panu Matilainen
Merged #839 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/839#event-264296___ Rpm-maint mailing list

[Rpm-maint] [rpm-software-management/rpm] Drop slen from builtin macro parser function (#839)

2019-09-17 Thread Michael Schroeder
The calculation of the slen parameter was not correct, as it didnt account for already processed characters. The parameter itself was also not used to limit the passed string, as the code assumed zero termination. Thus we can as well simplify the code by using strlen() on the passed string. You