Re: [Rpm-maint] [rpm-software-management/rpm] Fix 4.16.0 regression causing invalid spec file name on rpmbuild -ts (#1453)

2020-12-07 Thread Panu Matilainen
Merged #1453 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1453#event-4078870111___ Rpm-maint mailing list Rpm-mai

Re: [Rpm-maint] [rpm-software-management/rpm] Fix 4.16.0 regression causing invalid spec file name on rpmbuild -ts (#1453)

2020-12-07 Thread Panu Matilainen
@pmatilai commented on this pull request. > @@ -383,12 +385,22 @@ static char * getTarSpec(const char *arg) if (!gotspec) { rpmlog(RPMLOG_ERR, _("Failed to read spec file from %s\n"), arg); - specFile = NULL; +} else { + /* remove trailing \n */ + tarbuf[strl

Re: [Rpm-maint] [rpm-software-management/rpm] Fix 4.16.0 regression causing invalid spec file name on rpmbuild -ts (#1453)

2020-12-04 Thread Michal Domonkos
@dmnks approved this pull request. > @@ -383,12 +385,22 @@ static char * getTarSpec(const char *arg) if (!gotspec) { rpmlog(RPMLOG_ERR, _("Failed to read spec file from %s\n"), arg); - specFile = NULL; +} else { + /* remove trailing \n */ + tarbuf[strlen(tarb

[Rpm-maint] [rpm-software-management/rpm] Fix 4.16.0 regression causing invalid spec file name on rpmbuild -ts (#1453)

2020-12-02 Thread Panu Matilainen
Commit acf5e00281d73a2f8034091241c7b0e2ba00e383 cut a couple of corners too many, causing the temporary file name used to extract the spec from the tarball to end up in the src.rpm too. Revert back to creating %_specdir for tar builds, it might not be optimal but it's not exactly harmful either (%