Merged #2398 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2398#event-8694448485
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint maili
Looks good to me, thanks for the patch!
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2398#issuecomment-1459797124
You are receiving this because you are subscribed to this thread.
Message ID: ___
@socketpair commented on this pull request.
> @@ -273,8 +273,16 @@ static int runGPG(sigTarget sigt, const char *sigfile)
if (pipefd[1])
close(pipefd[1]);
-(void) waitpid(pid, &status, 0);
OK
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-softw
@socketpair commented on this pull request.
> @@ -402,7 +402,19 @@ static int getOutputFrom(ARGV_t argv,
reap:
/* Collect status from prog */
-reaped = waitpid(child, &status, 0);
+
+do {
+ reaped = waitpid(child, &status, 0);
+} while (reaped == -1 && errno == EINTR);
@socketpair pushed 1 commit.
8cb5c6a31a475067d41923b8306f8625dde4a71f Fix ignoring exit code of child
scripts in case of EINTR
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2398/files/e36832755b35ae9aa4b5103987e9375e86e08ba3..8cb5c6a31a475067d41923b8306f8625dde4a71f
@pmatilai commented on this pull request.
> @@ -273,8 +273,16 @@ static int runGPG(sigTarget sigt, const char *sigfile)
if (pipefd[1])
close(pipefd[1]);
-(void) waitpid(pid, &status, 0);
rpmfc lives in a separate library (librpmbuild) which isn't available to
librpmsign, but
@pmatilai commented on this pull request.
> @@ -402,7 +402,19 @@ static int getOutputFrom(ARGV_t argv,
reap:
/* Collect status from prog */
-reaped = waitpid(child, &status, 0);
+
+do {
+ reaped = waitpid(child, &status, 0);
+} while (reaped == -1 && errno == EINTR);
+
@socketpair commented on this pull request.
> @@ -273,8 +273,16 @@ static int runGPG(sigTarget sigt, const char *sigfile)
if (pipefd[1])
close(pipefd[1]);
-(void) waitpid(pid, &status, 0);
It's better to switch to new `rpmfc`. It's too difficult for me, I just can
only recom
I can make backport (the code has changed recently, so fix is slightly
different)
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2398#issuecomment-1443101095
You are receiving this because you are subscribed to this thread.
Message ID:
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/2398
-- Commit Summary --
* Fix ignoring exit code of child scripts in case of EINTR
-- File Changes --
M build/rpmfc.c (14)
M sign/rpmgensig.c (12)
-- Patch Links
10 matches
Mail list logo
