Problem was in reading of the memory right after the end of the
allocated area. (Similar problem as in
commit 54f24ec5486bdacde9419466a2c27defaddf508e).
This is a good opportunity to reflector the corresponding code
(setting variables according to the number of exclamation marks and
interrogation
The code seems fine, and :+1: for taking the opportunity to refactor. The
commit message just needs a bit of love.
This is a software, not hardware issue. You're fixing a buffer over-read, or
invalid memory access, not memory reading :slightly_smiling_face: (commit
54f24ec summary is equally ba
Thank you for the review. The commit message is changed according to your
comments.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/694#issuecomment-490864474__
pmatilai approved this pull request.
Much better, thanks.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/694#pullrequestreview-235537366_
Merged #694 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/694#event-2329951760___
Rpm-maint mailing list
Rpm-maint
