Re: [Rpm-maint] [rpm-software-management/rpm] If fork fails in getOutputFrom(), close opened unused pipe fds on err… (#1046)

2020-02-05 Thread Florian Festi
Fixed white space issues. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1046#issuecomment-582416518___ Rpm-maint mailing list R

Re: [Rpm-maint] [rpm-software-management/rpm] If fork fails in getOutputFrom(), close opened unused pipe fds on err… (#1046)

2020-02-05 Thread Florian Festi
Merged #1046 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1046#event-3010060897___ Rpm-maint mailing list Rpm-mai

Re: [Rpm-maint] [rpm-software-management/rpm] If fork fails in getOutputFrom(), close opened unused pipe fds on err… (#1046)

2020-02-05 Thread Panu Matilainen
Looks correct to me too, only there are some unrelated whitespace changes that don't belong. There are way too many places in this function where these descriptors get closed in one path or another but that's out of scope here. -- You are receiving this because you are subscribed to this threa

Re: [Rpm-maint] [rpm-software-management/rpm] If fork fails in getOutputFrom(), close opened unused pipe fds on err… (#1046)

2020-02-05 Thread Florian Festi
Looks like the right thing to do. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1046#issuecomment-582338245___ Rpm-maint mailin

[Rpm-maint] [rpm-software-management/rpm] If fork fails in getOutputFrom(), close opened unused pipe fds on err… (#1046)

2020-02-04 Thread Florian Festi
…or code path Signed-off-by: Denys Vlasenko You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1046 -- Commit Summary -- * If fork fails in getOutputFrom(), close opened unused pipe fds on error code pat