Re: [Rpm-maint] [rpm-software-management/rpm] Ignore %config flag where not supported (PR #2906)

2024-02-21 Thread Michal Domonkos
Merged #2906 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2906#event-11874927721 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Ignore %config flag where not supported (PR #2906)

2024-02-14 Thread Panu Matilainen
This isn't the only place where a misplaced %config can yield weird results though. I think we should just strip the %config bit out from the file flags entirely, in rpmfilesPopulate() probably. Kinda like we fixup missing rpmlib() flags in rpmdsNewPool(). -- Reply to this email directly or

Re: [Rpm-maint] [rpm-software-management/rpm] Ignore %config flag where not supported (PR #2906)

2024-02-13 Thread Florian Festi
Tested locally with mystery package that shall not be named -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2906#issuecomment-1943236369 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] Ignore %config flag where not supported (PR #2906)

2024-02-13 Thread Florian Festi
To answer the question: We really shouldn't! -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2906#issuecomment-1942018096 You are receiving this because you are subscribed to this thread. Message ID:

[Rpm-maint] [rpm-software-management/rpm] Ignore %config flag where not supported (PR #2906)

2024-02-13 Thread Florian Festi
%config is only allowed for regular files and links. While rpmbuild wont produce package with other files with %config other tools might. Handle these cases gracefully by ignoring the %config flag. Resolves: #2890 You can view, comment on, or merge this pull request online at: