Re: [Rpm-maint] [rpm-software-management/rpm] Implement prepend and append modes for all our normal build scriptlets (PR #2728)

2023-10-27 Thread Panu Matilainen
Merged #2728 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2728#event-10788604256 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mail

Re: [Rpm-maint] [rpm-software-management/rpm] Implement prepend and append modes for all our normal build scriptlets (PR #2728)

2023-10-27 Thread Panu Matilainen
@pmatilai commented on this pull request. > @@ -461,6 +461,13 @@ when name is omitted, the description refers to the main > package. Package build is divided into multiple separate steps, each executed in a separate shell. +Only one of each section can be present in a spec, but all build sc

Re: [Rpm-maint] [rpm-software-management/rpm] Implement prepend and append modes for all our normal build scriptlets (PR #2728)

2023-10-27 Thread Panu Matilainen
@pmatilai commented on this pull request. > @@ -461,6 +461,13 @@ when name is omitted, the description refers to the main > package. Package build is divided into multiple separate steps, each executed in a separate shell. +Only one of each section can be present in a spec, but all build sc

Re: [Rpm-maint] [rpm-software-management/rpm] Implement prepend and append modes for all our normal build scriptlets (PR #2728)

2023-10-27 Thread Panu Matilainen
Thanks @ffesti, but I ended up rewriting that from scratch now that the `%prep` exception is gone. It still isn't a great piece of literature exactly but hopefully passable for a reference manual now. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-manageme

Re: [Rpm-maint] [rpm-software-management/rpm] Implement prepend and append modes for all our normal build scriptlets (PR #2728)

2023-10-27 Thread Panu Matilainen
@pmatilai pushed 1 commit. 3864c8996e1f4b60ee731fcd91c6f744455ebabd Implement prepend and append modes for all build scriptlets -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2728/files/a8b4e5be21cae2f980e75bc528bff0405ec64689..3864c8996e1f4b60ee731fcd91c6f744455ebab

Re: [Rpm-maint] [rpm-software-management/rpm] Implement prepend and append modes for all our normal build scriptlets (PR #2728)

2023-10-26 Thread Florian Festi
May be people like this version better. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2728#issuecomment-1781371354 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [Rpm-maint] [rpm-software-management/rpm] Implement prepend and append modes for all our normal build scriptlets (PR #2728)

2023-10-26 Thread Florian Festi
@ffesti pushed 1 commit. a8b4e5be21cae2f980e75bc528bff0405ec64689 Reword spec.md change -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2728/files/39973be09ef2f0217177fd2afc65cabd1cd3945d..a8b4e5be21cae2f980e75bc528bff0405ec64689 You are receiving this because you are

Re: [Rpm-maint] [rpm-software-management/rpm] Implement prepend and append modes for all our normal build scriptlets (PR #2728)

2023-10-23 Thread Panu Matilainen
Once #2730 is merged we get to drop the %prep exception from this. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2728#issuecomment-1774934623 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] Implement prepend and append modes for all our normal build scriptlets (PR #2728)

2023-10-20 Thread Panu Matilainen
@pmatilai commented on this pull request. On tests/data/SPECS/append.spec: Meh, it's just a filename. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2728#discussion_r1366798392 You are receiving this because you are subscribed to this

Re: [Rpm-maint] [rpm-software-management/rpm] Implement prepend and append modes for all our normal build scriptlets (PR #2728)

2023-10-20 Thread Panu Matilainen
@pmatilai commented on this pull request. > @@ -461,6 +461,13 @@ when name is omitted, the description refers to the main > package. Package build is divided into multiple separate steps, each executed in a separate shell. +Only one of each section can be present in a spec, but all build sc

Re: [Rpm-maint] [rpm-software-management/rpm] Implement prepend and append modes for all our normal build scriptlets (PR #2728)

2023-10-20 Thread Panu Matilainen
@pmatilai commented on this pull request. > @@ -461,6 +461,13 @@ when name is omitted, the description refers to the main > package. Package build is divided into multiple separate steps, each executed in a separate shell. +Only one of each section can be present in a spec, but all build sc

Re: [Rpm-maint] [rpm-software-management/rpm] Implement prepend and append modes for all our normal build scriptlets (PR #2728)

2023-10-20 Thread Vít Ondruch
@voxik commented on this pull request. On tests/data/SPECS/append.spec: s/append.spec/append-prepend.spec/? -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2728#pullrequestreview-1689710331 You are receiving this because you are subscr

Re: [Rpm-maint] [rpm-software-management/rpm] Implement prepend and append modes for all our normal build scriptlets (PR #2728)

2023-10-20 Thread Vít Ondruch
@voxik commented on this pull request. > @@ -461,6 +461,13 @@ when name is omitted, the description refers to the main > package. Package build is divided into multiple separate steps, each executed in a separate shell. +Only one of each section can be present in a spec, but all build scrip

Re: [Rpm-maint] [rpm-software-management/rpm] Implement prepend and append modes for all our normal build scriptlets (PR #2728)

2023-10-20 Thread Vít Ondruch
@voxik commented on this pull request. > @@ -461,6 +461,13 @@ when name is omitted, the description refers to the main > package. Package build is divided into multiple separate steps, each executed in a separate shell. +Only one of each section can be present in a spec, but all build scrip

Re: [Rpm-maint] [rpm-software-management/rpm] Implement prepend and append modes for all our normal build scriptlets (PR #2728)

2023-10-20 Thread Panu Matilainen
@pmatilai pushed 1 commit. 39973be09ef2f0217177fd2afc65cabd1cd3945d Implement prepend and append modes for all our normal build scriptlets -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2728/files/fb317e65c1a6f49f4bae6033566e2243de280528..39973be09ef2f0217177fd2afc65

[Rpm-maint] [rpm-software-management/rpm] Implement prepend and append modes for all our normal build scriptlets (PR #2728)

2023-10-20 Thread Panu Matilainen
Allows %build, %install, %check, %clean and %generate_depends to be augmented arbitrary number of times by appending or prepending to them. The main use-case is to support automatic population of these sections (declarative builds) while still allowing packagers to easily tweak them, but could a