Re: [Rpm-maint] [rpm-software-management/rpm] Improve "git am" support. (#854)

2019-10-09 Thread Panu Matilainen
pmatilai commented on this pull request. > + }\ + %%{!?__scm_apply_patches_%{__scm}:\ + %%{lua:\ +local options = rpm.expand("%%{!-v:-q} %%{-p:-p%%{-p*}} ")\ +local low_limit = tonumber(rpm.expand("%%{-m:%%{-m*}}"))\ +local high_limit =

Re: [Rpm-maint] [rpm-software-management/rpm] Improve "git am" support. (#854)

2019-10-09 Thread Panu Matilainen
pmatilai commented on this pull request. > +}} + +# The list of all sources, or a slice of it +# -m Include patches with number >= min only +# -M Include patches with number <= max only +%sources(m:M:) %{shrink:%{lua:\ +local low_limit = tonumber(rpm.expand("%{-m:%{-m*}}"))\ +

Re: [Rpm-maint] [rpm-software-management/rpm] Improve "git am" support. (#854)

2019-10-09 Thread Panu Matilainen
pmatilai commented on this pull request. > +%_default_apply_flags %{expand:%%{?_default_%{__scm}_apply_flags}} + +# Choose between default apply flags and user-defined apply flags +%_apply_flags

Re: [Rpm-maint] [rpm-software-management/rpm] Improve "git am" support. (#854)

2019-09-27 Thread Peter Jones
Okay, I think this one should be pretty much fully baked - there's test cases now for %{patches -m N -M N}, %{sources...}, %autosetup -S git_am, %autosetup -S git, each of those with -N, and %autopatch after each of those. -- You are receiving this because you are subscribed to this thread.

Re: [Rpm-maint] [rpm-software-management/rpm] Improve "git am" support. (#854)

2019-09-26 Thread ニール・ゴンパ
This looks very cool! I've not had a chance to look at it in-depth, but the first pass looks pretty good! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Improve "git am" support. (#854)

2019-09-25 Thread Peter Jones
In anticipation of your responses above, I've reworked this patch series. If you'd like it differently than I guessed, let me know. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Improve "git am" support. (#854)

2019-09-25 Thread Peter Jones
> Nice to see that at least somebody has discovered this and finding the idea > useful enough to improve. > > Please split to independent commits though, too much unrelated change packed > into one here: Sure, that's fine by me. > * creating a branch where patches are applied is one

Re: [Rpm-maint] [rpm-software-management/rpm] Improve "git am" support. (#854)

2019-09-25 Thread Panu Matilainen
Nice to see that at least somebody has discovered this and finding the idea useful enough to improve. Please split to independent commits though, too much unrelated change packed into one here: - creating a branch where patches are applied is one change and should arguably be done for all