Re: [Rpm-maint] [rpm-software-management/rpm] Odd handing of URLs containing a ? in Source*:/Patch*: lines (#1407)

2021-03-02 Thread Michal Domonkos
Closed #1407. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1407#event-4396891954___ Rpm-maint mailing list Rpm-maint@lists.r

Re: [Rpm-maint] [rpm-software-management/rpm] Odd handing of URLs containing a ? in Source*:/Patch*: lines (#1407)

2021-03-02 Thread Michal Domonkos
This is a known limitation in RPM, but there's a simple workaround, see below. The way RPM [derives](https://github.com/rpm-software-management/rpm/blob/d601a7b7ae764b31ad74b2dceff1eafb5297147f/build/parsePreamble.c#L125) the target file name from a Patch/Source tag is by taking everything after

Re: [Rpm-maint] [rpm-software-management/rpm] Odd handing of URLs containing a ? in Source*:/Patch*: lines (#1407)

2020-11-01 Thread ニール・ゴンパ
I would actually expect it to be `chromium-skia-harmony.patch?h=chromium-vaapi` or `fix-invalid-end-iterator-usage-in-CookieMonster.patch?h=chromium-vaapi` instead, since the idea is that the filenames are determined by the last path separator (I believe that's what `basename` does...). -- Yo

Re: [Rpm-maint] [rpm-software-management/rpm] Odd handing of URLs containing a ? in Source*:/Patch*: lines (#1407)

2020-11-01 Thread Bernhard Rosenkraenzer
I would expect it to be chromium-skia-harmony.patch or fix-invalid-end-iterator-usage-in-CookieMonster.patch because that's what you get if you use wget or curl on the same URLs, given the ? is usually a separator between address and parameters. But either of those would be fine with me, while j

[Rpm-maint] [rpm-software-management/rpm] Odd handing of URLs containing a ? in Source*:/Patch*: lines (#1407)

2020-10-21 Thread Bernhard Rosenkraenzer
When using an URL containing a ? in Source*:/Patch*: lines, the file name assumed by rpm is truncated to the bits after the ?, not not the filename preceding it. This makes it hard to e.g. reference a patch being "stolen" from Arch Linux since e.g. Patch1: https://aur.archlinux.org/cgit/aur.git