Closed #345.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/345#event-1480502056___
Rpm-maint mailing list
After discussing this with others from a wider perspective:
Sorry but no. This is a POSIX mandated function and even if this particular one
would be easy to work around in one way or another, the next one(s) that we
introduce might not be, in fact are not likely to be. If we let this door open
The idea was to return a valid file name, so called code has something to
open/close.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@ydario Sure, but then the question becomes, why `/dev/tty` is hardcoded then?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
ah ok now I see. Is "Test for ctermid() existence. This is done because the
OS/2 platform does not provide it" a valid commit message?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Yes, obviously. But the rationale etc needs to be documented in commit
messages, not somewhere in GH.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
This is a follow up of discussion on issue #260
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/345#issuecomment-341710617___
I think it might be actually better to just not export posix.ctermid() on
systems that don't support it. I don't see much good coming out of claiming the
controlling terminal is /dev/tty on a system that doesn't have terminals at all.
And yeah a bit of rationale as for the why part is in order,
Some rationale (e.g. where function doesn't exist) would be good ;)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
