Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)

2023-03-13 Thread Michal Domonkos
Merged #2406 into rpm-4.18.x. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2406#event-8732507709 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint m

Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)

2023-03-13 Thread Michal Domonkos
Oh, well... Commit e31fb5b75898bfa09180dba02475c6d01764d94f already was on the `rpm-4.18.x` branch :facepalm: So we need to make the above change a separate commit. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2406#issuecomment-146623

Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)

2023-03-13 Thread Michal Domonkos
One last fixup: amend upstream commit e31fb5b75898bfa09180dba02475c6d01764d94f so that `Home-page` in the newly added `rpm.egg-info.in` is hardcoded (we don't define `@PACKAGE_URL@` so the field would've been empty). -- Reply to this email directly or view it on GitHub: https://github.com/rpm-s

Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)

2023-03-13 Thread Michal Domonkos
@dmnks pushed 79 commits. f4400993780890a37ccad9856340946bb7f9b0c5 Generate Python egg-info from automake builds 6432673bb96761d41905bd741d7028a2d10cba4d Document need to do history research on behavior changes ca4406bd3f6793389de8cb1c9982eefeb4e137c9 Add more on pull requests to CONTRIBUTIN

Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)

2023-03-13 Thread Panu Matilainen
@pmatilai approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2406#pullrequestreview-1336774698 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)

2023-03-10 Thread Michal Domonkos
Another update, this time removing the following: 8a74780c0 check-buildroot: harden $tmp creation fb6ad2c74 check-buildroot script: use if-then-else f2b4c647c check-buildroot: Redirect xargs stderr to $tmp 11458278a check-buildroot script: Double-Quote the variables fd3ef9b09 check-buildroot scrip

Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)

2023-03-10 Thread Michal Domonkos
@dmnks pushed 78 commits. 2c0459a25aa9174373bb514bd8bb4246b03b56c0 Document need to do history research on behavior changes 49b5fffd958c532497d7e223ff1c9429e9f31a17 Add more on pull requests to CONTRIBUTING dae67690507ef192d64b0029105614615418293a Fix potential uninitialized variable use in

Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)

2023-03-10 Thread Michal Domonkos
> If you want to trim your budget more: > > * the check-buildroot cleanups, that script has been there for > 20 years > without those changes... Oh, truly. Let me drop that, too, then. One can never be overly conservative with updates :smile: > * split testing population into a script

Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)

2023-03-10 Thread Panu Matilainen
If you want to trim your budget more: - the check-buildroot cleanups, that script has been there for > 20 years without those changes... - split testing population into a script - drop historic remnants from test-suite PATH (unless something later depends on these two test-suite changes) Not tha

Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)

2023-03-09 Thread Michal Domonkos
@dmnks pushed 56 commits. 53733da3609df63557c035717faa18249cc6523e Make %_smp_mflags build rather than parse time determined df6359235215095f6a93993393320f59aad2cec8 Fix rpmkeys type confusion test. 8c7029da19ffe724001be361456725374fa5e47e Enable malloc checking with random perturb in the tes

Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)

2023-03-09 Thread Michal Domonkos
OK, changes pushed, dropping the following ones: b0c9b3d87 Calculate number of threads to use during build, not spec parse d0867bcea Fix OpenMP enablement in librpmbuild (broken by cmake transition) 37ec18d86 Fix silent wait when missing input RPM package The second one is a noop without the firs

Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)

2023-03-09 Thread Michal Domonkos
Oh, and I'll also drop b0c9b3d87 since that's not needed to fix the intended regression, as per #2344. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2406#issuecomment-1462018833 You are receiving this because you are subscribed to this

Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)

2023-03-09 Thread Michal Domonkos
Should we also consider #2408? -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2406#issuecomment-1461930609 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-

Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)

2023-03-09 Thread Michal Domonkos
I decided to go through the picks once again and *actually* view them from the "is this an important bugfix" perspective, and removed a couple of less important commits as a result, namely these: c4eb357fe Drop a leftover mcheck.h include 4eb26a828 Drop redundant _GNU_SOURCE definitions from ndb

Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)

2023-03-09 Thread Michal Domonkos
@dmnks pushed 80 commits. 506d4e600de99a010884724b782b1538e51f66bf Permit building rpm from git without pandoc d964136eb221306cb3c1c2e0a2ce3bb06c295308 Add a handler for libselinux log messages (RhBug:2123719, RhBug:2050774) c5b73532e98cca1a00f0804da94a64c404d0cdb7 Split testing population in

Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)

2023-03-09 Thread Michal Domonkos
Not too late, really, it's actually just in time! Let's pick these `rpmsign` fixes too, then, they seem to be important enough for some folks and are regression fixes so typically a good choice for a maintenance update. Thanks for the note, @eaon! -- Reply to this email directly or view it on

Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)

2023-03-07 Thread eaon
Maybe a bit too late of an addition, but since #2396 was merged today (thank you!), I wondered if it could also make it into this release, with it being a fix for a regression and all. It would really help us out, thank you! -- Reply to this email directly or view it on GitHub: https://github.c

Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)

2023-03-03 Thread Michal Domonkos
Makes sense, thanks! -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2406#issuecomment-1453149586 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mail

Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)

2023-03-03 Thread Panu Matilainen
> I was also wondering if we shouldn't have done a soname bump before 4.18.0 > due to the following commits which have changed or removed some public > interfaces Those interfaces are not considered public, even if the symbols may be visible in the DSOs. The rpm criteria for a public interface

[Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)

2023-03-02 Thread Michal Domonkos
OK, time to make the first 4.18 maintenance update, please let me know if the commit selection works for you. The focus is, as always, on important bugfixes, regressions and security fixes. Note that I deliberately stopped the selection process at commit 1f47b1cc0 to keep the amount of changes