Solved a bit differently by just dropping the bogus BYPRODUCTS directives:
#2900
Thanks for reporting, and the patch even if it didn't get used as-is!
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2820#issuecomment-1940624460
You are
Closed #2820.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2820#event-11784571037
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint mailing list
Rpm
> we want the tarballs always recreated on "dist".
Okay, I get that.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2820#issuecomment-1897680855
You are receiving this because you are subscribed to this thread.
Message ID:
Just FWIW, https://gitlab.kitware.com/cmake/cmake/-/issues/22852 describes this
very case.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2820#issuecomment-1895869882
You are receiving this because you are subscribed to this thread.
Mes
@pmatilai requested changes on this pull request.
I came *this* close to merging, but testing made me remember why it's done the
way it is: we want the tarballs always recreated on "dist". With this patch,
that no longer happens.
Of course loops can't be right either, but I can't apply this as-
Right, I remember encountering this pattern somewhere. Always looked like one
of those cmake WTFs for me, which is probably why I tried to find some other
way to do it. And as such, it was probably always for the worse.
I'll accept changing this for correctness, but note that we officially only
@pmatilai commented on this pull request.
> @@ -434,17 +434,17 @@ function(add_tarball targetname namever treeish)
set(distname ${tarname}.bz2)
set(docname ${namever}-doc.${distfmt})
- add_custom_target(${docname}
- DEPENDS man apidoc
+ file(GLOB man_p
Attempts to generate a Ninja build from the existing CMake structure failed
complaining about phony cycles related to the use of `add_custom_target` and
placing the primary output file in the `DEPENDS` option.
You can view, comment on, or merge this pull request online at:
https://github.com/r
