Re: [Rpm-maint] [rpm-software-management/rpm] Use git apply --reject to assist with modifying patches (#927)

2020-01-15 Thread Panu Matilainen
Merged #927 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/927#event-2950049257___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Use git apply --reject to assist with modifying patches (#927)

2020-01-15 Thread Panu Matilainen
Sorry for dropping the ball here, seems obvious enough to me. Thanks for the patch! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Use git apply --reject to assist with modifying patches (#927)

2019-11-29 Thread Orion Poplawski
Any more comments? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/927#issuecomment-559907230___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Use git apply --reject to assist with modifying patches (#927)

2019-11-07 Thread ニール・ゴンパ
Conan-Kudo approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/927#pullrequestreview-313301748___

Re: [Rpm-maint] [rpm-software-management/rpm] Use git apply --reject to assist with modifying patches (#927)

2019-11-06 Thread Orion Poplawski
@opoplawski pushed 1 commit. fc670e136d3549810178a91666a209fb6fca222f Also use --reject with git am -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Use git apply --reject to assist with modifying patches (#927)

2019-11-06 Thread ニール・ゴンパ
Conan-Kudo requested changes on this pull request. Could you also add `--reject` to the `git am` call? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Use git apply --reject to assist with modifying patches (#927)

2019-11-06 Thread ニール・ゴンパ
Conan-Kudo approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/927#pullrequestreview-312483209___

[Rpm-maint] [rpm-software-management/rpm] Use git apply --reject to assist with modifying patches (#927)

2019-11-05 Thread Orion Poplawski
I find %autosetup -S git very hard to use when a patch needs updating for a new release of a project. This gives us the standard patch behavior of applying what it can and giving .rej files for what it cannot. I dont know how far back the --reject argument is valid, but it at least appears to