Re: [Rpm-maint] [rpm-software-management/rpm] Fix use-after-free introduced in 0f21bdd0d7b2c45564ddb5a24bbebd530867… (#705)

2019-05-14 Thread Panu Matilainen
Merged #705 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/705#event-2339744626___ Rpm-maint mailing list

[Rpm-maint] [rpm-software-management/rpm] Fix use-after-free introduced in 0f21bdd0d7b2c45564ddb5a24bbebd530867… (#705)

2019-05-14 Thread Panu Matilainen
…bd54 Unlike typical fooFree() functions in rpm, Fclose() doesn't set the pointer to NULL so there's a use-after-free in checking for Ferror() that segfaults and stuff. Delay Fclose() until the end so we actually catch io errors too, that was another thing that went missing in commit