[Rpm-maint] Problems in rpmstrPoolRehash function

2013-09-11 Thread Michael Schroeder
Hi rpm Maintainers, I think I've found two bugs in the rpmstrPoolRehash() function: 1) IMHO there's an off-by-one in the for loop: pool->offs_size is the last used id, thus it should be "<=" instead of "<". 2) the function should to skip the "dummy" entries that are put at the end of

Re: [Rpm-maint] Problems in rpmstrPoolRehash function

2013-09-12 Thread Michael Schroeder
On Wed, Sep 11, 2013 at 07:09:29PM +0200, Michael Schroeder wrote: > There are different (and easier) ways to fix this: > > - you can always put an empty string into the pool, it would always > have id 1. This simplifies the dummy entry check to: > if (i != 1 && str[0] == 0) > > - you cou

Re: [Rpm-maint] Problems in rpmstrPoolRehash function

2013-10-08 Thread Panu Matilainen
On 09/11/2013 08:09 PM, Michael Schroeder wrote: Hi rpm Maintainers, Hi, Sorry for the late reply. Trying to finally get back in business, moved to a new house and life's been "slightly" chaotic for the past weeks. I was expecting Florian to comment on this as the pool chunks and dummy ent