Re: [Rpm-maint] [rpm-software-management/rpm] Use plain awk command in cmake config (PR #2960)

2024-03-12 Thread Michal Domonkos
OK, should be fixed now. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2960#issuecomment-1991531934 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Use plain awk command in cmake config (PR #2960)

2024-03-12 Thread Michal Domonkos
Thanks, I'll update the PR accordingly. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2960#issuecomment-1991244835 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [Rpm-maint] [rpm-software-management/rpm] Use plain awk command in cmake config (PR #2960)

2024-03-12 Thread Panu Matilainen
findutil() doesn't fail on purpose because we don't really want all those silly little utilities in /usr/bin/ as build-dependencies of rpm itself, most of them are only relevant for installed rpmbuild. But, clearly some of the utilities are more important than others. The easiest solution is pr

Re: [Rpm-maint] [rpm-software-management/rpm] Use plain awk command in cmake config (PR #2960)

2024-03-12 Thread Michal Domonkos
> Plain awk is commonly available, but it's quite possible to have eg a minimal > image where it's not installed. So I think we should check for it explicitly > and fail if not found. OK, I admit I was just being a bit lazy here :sweat_smile: The point of (cmake) configuration is not to *assume

Re: [Rpm-maint] [rpm-software-management/rpm] Use plain awk command in cmake config (PR #2960)

2024-03-11 Thread Panu Matilainen
Plain awk is commonly available, but it's quite possible to have eg a minimal image where it's not installed. So I think we should check for it explicitly and fail if not found. ... actually we *are* already looking for awk, we just don't check the outcome: ``` findutil(__AWK awk) ```