@ffesti commented on this pull request.
> @@ -715,7 +715,8 @@ package or when debugging this package.\
RPM_ARCH=\"%{_arch}\"\
RPM_OS=\"%{_os}\"\
RPM_BUILD_NCPUS=\"%{_smp_build_ncpus}\"\
- export RPM_SOURCE_DIR RPM_BUILD_DIR RPM_OPT_FLAGS RPM_ARCH RPM_OS
RPM_BUILD_NCPUS\
+
@ffesti commented on this pull request.
> + if (checkForEncoding(pkg->header, 0) != RPMRC_OK) {
+ badenc = 1;
+ }
+ }
+ if (badenc)
+ goto errxit;
+}
+
+closeSpec(spec);
+
+exit:
+return spec;
+
+errxit:
+if (!secondary)
+
@ffesti pushed 1 commit.
a2ec843b8dbc11ece43f057092b0f768931c933c Move rpmSpecFree out of
parseSpecSection
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1485/files/a07501c24c391ed091f72c2933f259bb617c6185..a2ec843b8dbc11ece43f057092b0f768931c933c
You are receiving
Added alternative error handling. Turns out to be less of a change than I
expected. So it's probably just the way to go.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1485#issuecomment-1307049064
You are receiving this because you are
@ffesti commented on this pull request.
> + if (checkForEncoding(pkg->header, 0) != RPMRC_OK) {
+ badenc = 1;
+ }
+ }
+ if (badenc)
+ goto errxit;
+}
+
+closeSpec(spec);
+
+exit:
+return spec;
+
+errxit:
+if (!secondary)
+
Merged #2270 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2270#event-7772829149
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint
Rebased on top of #2270 and squashed latest fixes.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1485#issuecomment-1308683146
You are receiving this because you are subscribed to this thread.
Message ID:
@ffesti pushed 3 commits.
a1056d0b1487ee921db9de8d53bf693976e1f0b5 Split actual parsing of spec into its
own function
a2592627c300ddbe9af1632d0681391567213791 Allow starting new spec parts with
PART_EMPTY
26de93c844ee13d456542e867cf35a60e574c90b Add Dynamic Spec generation
--
View it on
OK, #1485 is finally merged. This is the minimally useful step. I'll resubmit
the patch to `find-lang.sh` that uses this to create language sub-packages as a
use/show case.
Still the current state is limited to complete sub packages and can't really
interact with the content of the spec file.
Currently the creation of users and groups are left to the packagers and is
though done differently between different distribution and as %pre scriptlets.
This has several drawbacks:
* It is not known which packages create which users
* Packages may ship files with users/groups that don't exist
I will update the top post as a design document and add your answers and
suggestions so they don't get lost in the discussion below. So the first
questions to every one is:
How does your distribution handle user and group creation? What features would
you hope for and what issues solved? I am
Merged #2218 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2218#event-7803500644
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint
There are two different things to consider: When are BuildRequires checks done
during the build process and whether to do it depending on what
stage/subcommand are executed. Looking at
https://github.com/rpm-software-management/rpm/blob/master/build/build.c#L379
and
Well, I had considered both of these options and decided against both of them.
Yes, adding an empty statement solves this. But it is weird and makes it easy
to unnecessarily draw attention to some language quirk while we can also just
use totally fine C code.
--
Reply to this email directly
See #2434
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2434#issuecomment-1472593844
You are receiving this because you are subscribed to this thread.
Message ID: ___
Rpm-maint mailing list
Quick note: "m" lines in the `sysusers.d` files could be used to create
Requires to the user and group.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/discussions/2277#discussioncomment-5303187
You are receiving this because you are
Closed #2428 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2428#event-8766560643
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint
First, RPM does dependency checks for every type of operation. While the cli
only offers certain operations updaters and other API users can do more complex
operations. So matching the errors to the operation is not going to happen.
This is a generic error than can be caused by any type of
See #2432
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/discussions/2277#discussioncomment-562
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint
Looks good!
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2421#issuecomment-1466141491
You are receiving this because you are subscribed to this thread.
Message ID: ___
Rpm-maint mailing list
Merged #2421 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2421#event-8731747212
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint
I doubt that checking for the build time will work for long. You either need to
check in the package, set the file dates manually or filter out the dates in
the output.
--
Reply to this email directly or view it on GitHub:
Looks like the CI agrees with me...
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2430#issuecomment-1471643133
You are receiving this because you are subscribed to this thread.
Message ID:
in the reference manual
Resolves: #2413
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/2433
-- Commit Summary --
* Describe the stripped down payload format
-- File Changes --
M docs/manual/format.md (8)
-- Patch
@ffesti pushed 1 commit.
92cdf843d49c428ca01049f374b2d26d490ed2a4 Describe the stripped down payload
format
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2433/files/e0153b162d6e73edc7437218ddb53deed8e3fe29..92cdf843d49c428ca01049f374b2d26d490ed2a4
You are receiving
Turns out declarations cannot be labeled according to the C standard. And while
some compilers dont seem to care others do.
Moving the declaration of mayopen to the start of the function to avoid this
problem.
Resolves: #2435
You can view, comment on, or merge this pull request online at:
Merged #2395 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2395#event-8561147275
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint
My English is not good enough for all details of this change, but where it is
it looks good. Merging anyway.
Thanks for the patch!
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2395#issuecomment-1436932400
You are receiving this
hmpf
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2474#issuecomment-1511439562
You are receiving this because you are subscribed to this thread.
Message ID: ___
Rpm-maint mailing list
Reopened #2474.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2474#event-9025128067
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint mailing list
cmake variables and the derived macros.
CMAKE_INSTALL_INFODIR and CMAKE_INSTALL_MANDIR already include the
datarootdir. So just prepending the prefix is sufficient.
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/2500
--
I wonder if in
[b9c694e](https://github.com/rpm-software-management/rpm/pull/2432/commits/b9c694e5108bd6ae193484d01b7d59a8e94c4cd3)
we should also check for the user and group of the installed files.
Other than that this looks all good!
--
Reply to this email directly or view it on GitHub:
Thanks for the patch!
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2458#issuecomment-1494170389
You are receiving this because you are subscribed to this thread.
Message ID: ___
Rpm-maint
Merged #2458 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2458#event-8911940723
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint
Closed #2457 as completed via #2458.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2457#event-8911940983
You are receiving this because you are subscribed to this thread.
Message ID:
___
Merged #2459 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2459#event-8912848488
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint
Those who have been following RPM development already know that we have been
thinking about the next major release of RPM for quite a while. We are finally
ready to give a rough outline of where this is all going.
### Next Major Version
One point of discussion was which version number to pick.
@ffesti pushed 1 commit.
e35562e657c7c603b35d029ede258a05f64bd373 Add WITH_FAPOLICYD build option
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2473/files/45cabc125bc6e300bfd124851bdd15d40eb5d2cc..e35562e657c7c603b35d029ede258a05f64bd373
You are receiving this
@ffesti commented on this pull request.
> @@ -30,6 +30,7 @@ option(WITH_DBUS "Build with DBUS support" ON)
option(WITH_AUDIT "Build with audit support" ON)
option(WITH_FSVERITY "Build with fsverity support" OFF)
option(WITH_IMAEVM "Build with IMA support" OFF)
+option(WITH_FAPOLICYD "Build
defaulting to ON. The if clauses were already in place just the option line was
missing.
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/2473
-- Commit Summary --
* Add WITH_FAPOLICYD build option
-- File Changes --
it should go to /etc/dbus-1/system.d/org.rpm.conf to make the dbus announce
plugin work.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2474
You are receiving this because you are subscribed to this thread.
Message ID:
which was accidentially dropped when converting to cmake
Use CMAKE_INSTALL_FULL_SYSCONFDIR as it expands to /etc instead of /usr/etc
Resolves: #2474
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/2476
-- Commit Summary --
Based on downstream Fedora patch
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/2481
-- Commit Summary --
* Add RPM_LD_FLAGS to build environment
-- File Changes --
M macros.in (3)
-- Patch Links --
@ffesti pushed 1 commit.
d9c4d290e3cedb6341f75a4b0bceeb86717799e7 Use WITH_IMAEVM in cmake file
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2473/files/e35562e657c7c603b35d029ede258a05f64bd373..d9c4d290e3cedb6341f75a4b0bceeb86717799e7
You are receiving this because
Closed #2461 as resolved.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/discussions/2461
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint mailing list
Happy April's fool day everyone!
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/discussions/2461#discussioncomment-5521549
You are receiving this because you are subscribed to this thread.
Message ID:
@ffesti commented on this pull request.
> @@ -645,6 +663,20 @@ rpmScript rpmScriptFromTriggerTag(Header h, rpmTagVal
> triggerTag,
return script;
}
+rpmScript rpmScriptFromArgv(Header h, ARGV_t argv, rpmscriptFlags flags, int
chroot)
It's kinda weird to have a generic name like
@ffesti commented on this pull request.
> @@ -56,6 +56,7 @@
%__hg @__HG@
%__bzr @__BZR@
%__quilt @__QUILT@
+%__systemd_sysusers%{_bindir}/systemd-sysusers
This clearly needs a comment like "comment out to disable user and group
creation"
@ffesti pushed 1 commit.
0e923736841f30d20c29474c79461759b66ac519 Add %specpartsdir to macros.in
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2534/files/ebb9d2010c9dde4e2589bfe71a88c64c1653d169..0e923736841f30d20c29474c79461759b66ac519
You are receiving this
@ffesti pushed 1 commit.
252fc02ea530aaa9437f56a7d2e259ee0fbb2298 Add %specpartsdir to macros.in
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2534/files/0e923736841f30d20c29474c79461759b66ac519..252fc02ea530aaa9437f56a7d2e259ee0fbb2298
You are receiving this
Adjusted the docs to the new location and added Resolved tag to the original
ticket in the commit message.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2534#issuecomment-1588856898
You are receiving this because you are subscribed to
@ffesti pushed 4 commits.
0dd67944506a2cf62db7df74d8ff0471128930f9 Add sysusers.sh script
d173792ee2cddafa6ca729e02f41172970324989 Replace getent with grep
8424b3a0351181302163334064e6d8ed084277e9 Implement --replace
7b1600e2449421bbce1f1fdb76857c5d5d2d7dd9 Add test case for skipping user
for user and group generation.
This is currently failing in the test suite but works fine when rebased onto
#2559
Still needs --replace to be implemented
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/2573
-- Commit
This branch is missing the patch for adding groupadd and useradd to the test
suite but even with that `groupadd` fails due to not being able to access some
security/SElinux stuff like `/proc/thread-self/attr/fscreate` and
`/sys/fs/selinux/enforce`. Nothing we want to fix in a test suite that's
Life is confusing and RPM reflects that. There is no bug here and we are not
changing the version comparison breaking thousands of packages.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2574#issuecomment-1637196292
You are receiving
Closed #2574 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2574#event-9831818911
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint
This is always in /usr no matter what prefixes are used either in rpm or
systemd as it is package installed system configuration.
Setting this hard coded to not require systemd as a build dependency. Otherwise
the sysusers_dir or sysusersdir pkg-config variable could be used.
Borrowing the
@ffesti pushed 1 commit.
9cc0dbbe747307061226260e4a40d03bf424983c Make RUNDIR lower case (rundir)
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2575/files/9fe3f8616fcbd46886c14799ab53aa02044e80a4..9cc0dbbe747307061226260e4a40d03bf424983c
You are receiving this
@ffesti pushed 1 commit.
9fe3f8616fcbd46886c14799ab53aa02044e80a4 Set %_sysusersdir independent from
our prefix
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2575/files/8ccfa76f7ad6f65d66461469407ca7d193a1e92c..9fe3f8616fcbd46886c14799ab53aa02044e80a4
You are
Moved root_prefix definition into the CMake file
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2575#issuecomment-1638098487
You are receiving this because you are subscribed to this thread.
Message ID:
Hard code the prefix to /usr as this needs to match with dbus and not our own
install prefix.
Resolves: #2474
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/2530
-- Commit Summary --
* Move dbus announce plugin config in
Well, mainly because I am still getting used to CMake. Should be fixed now.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2530#issuecomment-1573800308
You are receiving this because you are subscribed to this thread.
Message ID:
@ffesti pushed 1 commit.
d35e9babdd959efce5574cd2724895d44b02251b Move dbus announce plugin config to
DATADIR
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2530/files/ba0647f01fa06b334fdfeb9d2c61bca976b8309b..d35e9babdd959efce5574cd2724895d44b02251b
You are
Yes, the underscores in macros are a bit of a mess. I modeled %specpartsdir on
%buildsubdir which also comes without an underscore. I think the idea is that
macros to be used directly don't have an underscore. Stuff to be configured
have one underscore and stuff not to be touched have two.
--
Replaces: #2533
Resolves: #2532
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2534#issuecomment-1580614313
You are receiving this because you are subscribed to this thread.
Message ID: ___
so it can be configured from the spec file
Also move the dir beside the %buildsubdir as %{buildsubdir}-SPECPARTS so it
doesnt pollute the %buildsubdir.
This patch is still missing adjustments to the dynamic_specs.md as we might
decide to keep the SPECPARTS in %buildsubdir
You can view, comment
#2534 would solve that issue by moving the SPECPARTS dir one dir up. It's only
one char different for moving it back in. But so far I don't quite see a
drawback for doing it this way except there is now one more way how builds of
the same package can step on each others toe.
--
Reply to this
@ffesti pushed 1 commit.
ac37764891a8d832427f057064610b07ca0dbf52 Add RPM_LD_FLAGS to build environment
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2481/files/ee3cb5002f9aedfd987983f12016c3d31d8dab8a..ac37764891a8d832427f057064610b07ca0dbf52
You are receiving this
Yeah, I see this is a problem. The fact that we don't really have a proper
directory for the build is really not great. We basically rely on the source
tarball providing a directory (*). Having the directory beside the buildsubdir
is probably the best solution for now until we move the whole
Merged #2521 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2521#event-9304180020
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint
OK, there is only one warning left caused by the `eval` line. Let me see if we
can get rid of that, too.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2573#issuecomment-1651069702
You are receiving this because you are subscribed to
@ffesti pushed 1 commit.
36cbc08980d643614e646eb39542aeacf1afdb5e Add --help and description
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2573/files/c69b996901e5d62f8d49d72b46dc651115c581a8..36cbc08980d643614e646eb39542aeacf1afdb5e
You are receiving this because
@ffesti pushed 6 commits.
d99cfdbc10ed5b56eaac54704a3b91631086061d Add sysusers.sh script
05328c5d35b79f24016fd945e4b264badc16caf4 Replace getent with grep
d020c8b082b29d02d9abd4e9fdd1176ed9e8c700 Implement --replace
16690d145b086e197c44d2c95c3b3d3c295d9527 Add test case for skipping user
Ok, all shellcheck warnings gone and test suite is passing.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2573#issuecomment-1651159358
You are receiving this because you are subscribed to this thread.
Message ID:
@ffesti pushed 1 commit.
c69b996901e5d62f8d49d72b46dc651115c581a8 Replace eval with mapfile and xargs
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2573/files/df7df2c046d6a26c2494b12bea89bb9b5d7916b3..c69b996901e5d62f8d49d72b46dc651115c581a8
You are receiving this
Merged #2573 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2573#event-9922341090
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint
Closed #2499.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2499#event-9923279896
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint mailing list
We have finally been able to get the new test suite back end merged into
master. With that this PR is now obsolete. We won't patch up the old test suite
to run on Nix. Please checkout the new test suite with the 4.19-beta that we
are going to release the next few days.
--
Reply to this email
@ffesti pushed 3 commits.
a1ead60c4e936fc154df917b54027a2e008b12b3 Fix missing signal.h include
c3db93214ec4f373be2d76c732efd7f7fc7dcdc7 Fix missing basename include on macOS
39f007b68e6f7d99d223a0e06076d88a8e4355bb Duplicate filename before passing it
to basename
--
View it on GitHub:
OK, still someone needs to squash this and provide a proper commit message.
I'll close this soonish otherwise.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2540#issuecomment-1651883205
You are receiving this because you are subscribed
@ffesti pushed 1 commit.
834f337d997b19a484bc80fa02c5af6ede875097 Check inside --root when querying for
files
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2582/files/82dd665bbde453a805a6e536b7d327fdd7a3a52e..834f337d997b19a484bc80fa02c5af6ede875097
You are
@ffesti pushed 1 commit.
cd750adc7f7d4be4e1ac173631c07fdb2e5f9757 Replace systemd-sysusers by new
sysusers.sh script
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2573/files/47a20f64e82eacdf91679a356de038208d487b86..cd750adc7f7d4be4e1ac173631c07fdb2e5f9757
You are
Merged #2582 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2582#event-9924391650
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint
Closed #2576 as completed via #2582.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2576#event-9924391910
You are receiving this because you are subscribed to this thread.
Message ID:
___
Closed #2579.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2579#event-9922708151
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint mailing list
We don't allow PRs for release branches as patches in there are supposed to be
cherry-picked from master. We now have a rpm-4.18.2 milestone that the original
issue can be attached to as a reminder that this should be backported.
Closing.
--
Reply to this email directly or view it on GitHub:
This PR needs to be against master. Also a feature like this needs at least
some documentation. `installplatform` is a script no one ever should need to
look into. So hiding features in there is not acceptable. May be adding a
section to INSTALL is a good first step. We can move that to the
Closed #2580.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2580#event-9923080277
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint mailing list
Sorry, this cast to (char*) makes me feel uneasy even if it is save here. Will
merge after the test suite passes.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2571#issuecomment-1651780526
You are receiving this because you are
Merged #2571 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2571#event-9924253332
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint
Closed #2566 as completed via 33bc736185b6929d9c61678843729ce51833365d.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2566#event-9907897479
You are receiving this because you are subscribed to this thread.
Message ID:
Thanks for reporting!
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2566#issuecomment-1649245855
You are receiving this because you are subscribed to this thread.
Message ID: ___
Rpm-maint
rpm -qf checks if the argument actually exists if it cant be found in the
rpmdb and gives different messages based on that.
This was done without taking the root dir into account leading to wrong
messages if the file only exists in the root dir but not outside.
Resolves: #2576
You can view,
> There's also the missing case for the `root` user, as the default shell for
> UID 0 is defined to be `/bin/sh` and homedir `/root`.
Not sure if we need / want a special case for root here. In my head it is the
responsibility of the distribution to create the root user (and all other
default
@ffesti commented on this pull request.
> +
+hasgroup() {
+ grep "^${1}:" "$ROOT"/etc/group >/dev/null
+}
+
+user() {
+ local user="$1"
+ local uid="$2"
+ local desc="$3"
+ local group="$4"
+ local home="$5"
+ local shell="$6"
+
+ [ "$desc" = '-'
@ffesti pushed 1 commit.
6f76e447208072a1ba7971f0fc1bf8efb12a1b8b Update INSTALL
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2585/files/98a7615d9db2d43126c453b9bd0f4cc5006c18b7..6f76e447208072a1ba7971f0fc1bf8efb12a1b8b
You are receiving this because you are
Adjusted the docs a bit to not assume platform is always "linux" - even if it
is for many people.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2585#issuecomment-1655442493
You are receiving this because you are subscribed to this
Closed #2578 as completed via #2585.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2578#event-9946483467
You are receiving this because you are subscribed to this thread.
Message ID:
___
Merged #2585 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2585#event-9946483232
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint
@ffesti commented on this pull request.
> +[ -e "$ROOT"/etc/passwd ] || touch "$ROOT"/etc/passwd
+[ -e "$ROOT"/etc/shadow ] || touch "$ROOT"/etc/shadow
+[ -e "$ROOT"/etc/group ] || touch "$ROOT"/etc/group
While I agree `useradd` and `groupadd` just won't work. And we want rpm -q
--root to
1201 - 1300 of 1611 matches
Mail list logo
