https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
Antonio changed:
What|Removed |Added
Status|ASSIGNED|RESOLVED
Blocks|4
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
Nicolas Chauvet changed:
What|Removed |Added
Blocks|33 |
--
Configure bugmail: https://bugzi
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
Antonio changed:
What|Removed |Added
Blocks||33
--- Comment #41 from Antonio 2013-06-08 1
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
--- Comment #40 from Antonio 2013-06-08 16:12:27 CEST
---
> Sorry, my bad... was a bit tired yesterday... hope you don't mind...
No problem :)
> there could be %check, but it's quiet exhaustive.
> Full tests take est. >= 15 min on i7-2860QM
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
Björn Esser changed:
What|Removed |Added
CC||ray...@yahoo.com
--- Comment #39 from Bjö
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
Björn Esser changed:
What|Removed |Added
Blocks|2 |4
--- Comment #38 from Björn Esser 2013-
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
--- Comment #37 from Antonio 2013-06-08 00:05:34 CEST
---
http://sagitter.fedorapeople.org/moc/moc.spec
http://sagitter.fedorapeople.org/moc/moc-2.5.0-0.8.beta1.fc18.src.rpm
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
--- Comment #36 from Antonio 2013-06-07 23:45:01 CEST
---
(In reply to comment #34)
> [!]: Development (unversioned) .so files in -devel subpackage, if present.
> Note: Unversioned so-files in private %_libdir subdirectory (see
> attach
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
--- Comment #35 from Antonio 2013-06-07 23:27:24 CEST
---
(In reply to comment #33)
> INFO: No upstream for (Source0): moc-2.5.0-beta1.tar.bz2
>
> Why don't you use Source0:
> http://ftp.daper.net/pub/soft/moc/unstable/%{name}-%{version}-beta1
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
Björn Esser changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|rpmfusion-pac
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
--- Comment #34 from Björn Esser 2013-06-07 22:01:04
CEST ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package doe
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
Björn Esser changed:
What|Removed |Added
CC||bjoern.es...@gmail.com
--- Comment #33 fr
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
--- Comment #32 from Antonio 2013-05-20 18:01:13 CEST
---
(In reply to comment #31)
> Can someone volunteer to be assigned for the review ?
Hi Nicolas.
Thanks for your consideration.
Just another change:
- Dist tag changed to %%{?dist}
http
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
--- Comment #31 from Nicolas Chauvet 2013-05-20 15:51:59
CEST ---
Can someone volunteer to be assigned for the review ?
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because:
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
--- Comment #30 from Antonio 2013-04-09 16:05:01 CEST
---
- Removed autoreconf task from %%build section
http://sagitter.fedorapeople.org/moc/moc.spec
http://sagitter.fedorapeople.org/moc/moc-2.5.0-0.6.beta1.fc18.src.rpm
--
Configure bugmail
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
--- Comment #29 from Antonio 2013-04-05 21:41:16 CEST
---
(In reply to comment #28)
> You don't need the librcc explicit require. It is added automatically since
> you
> BR librcc-devel
Hi Gianluca.
Thank for your note.
http://sagitter.fedor
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
Gianluca Sforna changed:
What|Removed |Added
CC||gia...@gmail.com
--- Comment #28 from
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
--- Comment #27 from Antonio 2013-03-19 20:05:55 CET ---
Now, I'm in Fedora Packager Group.
I think that everything is ok to complete this review. :)
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
Antonio changed:
What|Removed |Added
Blocks|30 |
--
Configure bugmail: https://bugzilla.rpmf
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
--- Comment #26 from Antonio 2013-03-03 19:52:27 CET ---
- Removed DESTDIR from %%make_install
- Changed source link with a public one
- Set up a new macro to define MOC's 'mocp' executable
- Added %%{name} prefix to the patch
SPEC: http://sag
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
--- Comment #25 from Antonio 2012-12-25 20:58:35 CET ---
http://sagitter.fedorapeople.org/moc.spec
http://sagitter.fedorapeople.org/moc-2.5.0-0.3.beta1.fc18.src.rpm
Added LibRCC library support (it fixes encoding in broken mp3 tags).
--
Confi
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
--- Comment #24 from Antonio 2012-10-28 10:21:54 CET ---
(In reply to comment #23)
> Ops, sorry.
>
> lines 4 and 78:
> * You have to increment the release number [1]. In this case, from '0.1.beta1'
> to '0.2.beta1'. Also, add a blank line betwe
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
--- Comment #23 from Elder Marco 2012-10-28 01:08:02
CEST ---
Ops, sorry.
lines 4 and 78:
* You have to increment the release number [1]. In this case, from '0.1.beta1'
to '0.2.beta1'. Also, add a blank line between changelog entries.
[1] - h
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
--- Comment #22 from Antonio 2012-10-22 17:32:45 CEST
---
(In reply to comment #21)
> (In reply to comment #19)
> > The db-devel inconsistency is listed as
> > https://bugzilla.redhat.com/show_bug.cgi?id=758491
>
> Thanks! :)
>
> (In reply to
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
--- Comment #21 from Elder Marco 2012-10-22 14:22:49
CEST ---
(In reply to comment #19)
> The db-devel inconsistency is listed as
> https://bugzilla.redhat.com/show_bug.cgi?id=758491
Thanks! :)
(In reply to comment #20)
> Added a patch to fix
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
--- Comment #20 from Antonio 2012-10-22 12:19:09 CEST
---
(In reply to comment #17)
> > > * Tell upstream that FSF for files decoder_plugins/mp3/xing.c
> > > and decoder_plugins/mp3/xing.h (see the first must item above) is
> > > outdated.
>
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
--- Comment #19 from Stephen Roylance 2012-10-22
05:48:49 CEST ---
The db-devel inconsistency is listed as
https://bugzilla.redhat.com/show_bug.cgi?id=758491
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
---
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
--- Comment #18 from Antonio 2012-10-21 17:12:24 CEST
---
(In reply to comment #17)
>
> > I have changed 'BuildRequires:ffmpeg-devel' with
> >
> > ##Build Requires of ffmpeg-devel
> > BuildRequires: pkgconfig(libavcodec)
> > BuildRequires:
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
--- Comment #17 from Elder Marco 2012-10-21 16:20:27
CEST ---
> > It is correct, but you can use this URL as Source URL:
> > Source0:
> > ftp://ftp.daper.net/pub/soft/moc/unstable/%{name}-%{version}-beta1.tar.z2
>
> Done but rpmlint p
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
--- Comment #16 from Elder Marco 2012-10-21 15:32:56
CEST ---
Hello Stephen,
You must install the dependencies. Open a terminal and run
$ yum-builddep /path/to/moc.spec
Remove the package db4-devel from your system before. These are the same
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
Stephen Roylance changed:
What|Removed |Added
CC||royla...@corplink.com.au
--- Comment
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
--- Comment #14 from Antonio 2012-10-21 12:03:31 CEST
---
I forgot ...
.spec file and .src package are available always here:
http://sagitter.fedorapeople.org/moc.spec
http://sagitter.fedorapeople.org/moc-2.5.0-0.1.beta1.fc17.src.rpm
--
Con
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
--- Comment #13 from Antonio 2012-10-21 12:01:14 CEST
---
(In reply to comment #12)
> This is an informal review since I can't sponsor you.
>
>
> Key:
>
> [+] - OK
> [-] - FIX/Needs work.
> [x] - Not applicable
> ---
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
--- Comment #12 from Elder Marco 2012-10-20 23:54:43
CEST ---
This is an informal review since I can't sponsor you.
Key:
[+] - OK
[-] - FIX/Needs work.
[x] - Not applicable
-
MUST ITEMS
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
--- Comment #11 from Antonio 2012-10-19 19:49:05 CEST
---
(In reply to comment #10)
> OK, thanks :)
>
> I will do an informal review tomorrow. Unfortunately, I am just a packager not
> a sponsor. So, I can't sponsor you.
Thank for your fundam
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
--- Comment #10 from Elder Marco 2012-10-19 19:21:14
CEST ---
OK, thanks :)
I will do an informal review tomorrow. Unfortunately, I am just a packager not
a sponsor. So, I can't sponsor you.
--
Configure bugmail: https://bugzilla.rpmfusion.o
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
--- Comment #9 from Antonio 2012-10-19 17:50:42 CEST ---
(In reply to comment #8)
> Oops, sorry. The spec file is wrong but it is my fault.
>
>
> line 54:
>
> rm -rf $RPM_BUILD_ROOT%{_datadir}/doc/%{name}
>
> The correct is
>
> rm -rf $RPM_
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
--- Comment #8 from Elder Marco 2012-10-19 17:28:18 CEST
---
Oops, sorry. The spec file is wrong but it is my fault.
line 54:
rm -rf $RPM_BUILD_ROOT%{_datadir}/doc/%{name}
The correct is
rm -rf $RPM_BUILD_ROOT%{_datadir}/doc
* In the %fi
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
--- Comment #7 from Antonio 2012-10-19 15:36:42 CEST ---
http://sagitter.fedorapeople.org/moc.spec
http://sagitter.fedorapeople.org/moc-2.5.0-0.1.beta1.fc17.src.rpm
Thank you very much.
--
Configure bugmail: https://bugzilla.rpmfusion.org/use
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
--- Comment #6 from Elder Marco 2012-10-19 15:15:53 CEST
---
No, you must add documentation files using the %doc section. In other words,
remove the directory $RPM_BUILD_ROOT%{_datadir}/doc/%{name}:
...
%install
%make_install DESTDIR=$RPM_BUI
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
--- Comment #5 from Antonio 2012-10-19 12:30:36 CEST ---
Created attachment 978
--> https://bugzilla.rpmfusion.org/attachment.cgi?id=978
moc.spec file
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You a
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
--- Comment #4 from Antonio 2012-10-19 12:29:53 CEST ---
(In reply to comment #3)
> OK. Just a few more comments.
>
> * Use %doc for the documentation [1];
> * You still should own the directory %{_datadir}/%{name} [2]. You can do it by
> addin
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
--- Comment #3 from Elder Marco 2012-10-18 21:50:58 CEST
---
OK. Just a few more comments.
* Use %doc for the documentation [1];
* You still should own the directory %{_datadir}/%{name} [2]. You can do it by
adding this line at the %files sect
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
--- Comment #2 from Antonio 2012-10-16 11:56:40 CEST ---
(In reply to comment #1)
> Hello,
>
> Just a few comments:
>
> - You don't need to add the first line (# This file is made...). The identity
> of the packager is evident from the changel
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
--- Comment #1 from Elder Marco 2012-10-16 01:44:27 CEST
---
Hello,
Just a few comments:
- You don't need to add the first line (# This file is made...). The identity
of the packager is evident from the changelog entry;
- It would be nice if
45 matches
Mail list logo
