https://bugzilla.rpmfusion.org/show_bug.cgi?id=4639
Nicolas Chauvet changed:
What|Removed |Added
Status|ASSIGNED|RESOLVED
Resolution|---
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4639
--- Comment #14 from Nicolas Chauvet ---
@Andrea
Please set the fedora-review flag to +
Thx
--
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4639
Andrea Musuruane changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #15 from
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4639
--- Comment #16 from Andrea Musuruane ---
(In reply to Ben Rosser from comment #13)
> - Remove static subpackage, move static library into devel subpackage.
When a package only provides static libraries you MAY place all the static
library file
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4639
--- Comment #18 from Nicolas Chauvet ---
git manually created.
--
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4639
--- Comment #17 from Ben Rosser ---
> When doing this you also MUST have a virtual Provide for the *-static package:
Whoops, good catch. Fixed.
Spec URL: https://mars.arosser.com/fedora/dwarffortress/rpmfusion/dfhack.spec
SRPM URL:
https://mar
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4639
--- Comment #13 from Ben Rosser ---
I've updated the spec with these fixes:
- Update to latest upstream release, add various review fixes.
- Remove static subpackage, move static library into devel subpackage.
- Remove re-definition of dist tag
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4639
--- Comment #12 from Ben Rosser ---
Thanks for the review! I will take care of those issues.
--
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailin
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4639
Andrea Musuruane changed:
What|Removed |Added
Blocks|3 |4
--- Comment #11 from Andrea Musuru
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4639
--- Comment #10 from Ben Rosser ---
Thanks for taking a look!
> IIRC using the %setup macro is the preferred way to unpack additional sources.
> http://www.tldp.org/HOWTO/RPM-HOWTO/build.html
> Do you think it is possible?
So I'd like to do t
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4639
--- Comment #9 from Andrea Musuruane ---
(In reply to Ben Rosser from comment #8)
> I finally got around to working on this.
Hi Ben!
Sorry for taking so long just to have a look.
> The dfhack build process creates an include file, "git-describ
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4639
--- Comment #8 from Ben Rosser ---
I finally got around to working on this.
The dfhack build process creates an include file, "git-describe.h", which
contains the commit hash information that gets incorporated into the version
strings. Rather t
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4639
--- Comment #7 from Andrea Musuruane ---
(In reply to Ben Rosser from comment #6)
> > Isn't it possible to patch sources? Please remember that RPM Fusion
> > builders will > need to download these data every time you request a build.
>
> > Isn
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4639
--- Comment #6 from Ben Rosser ---
> Isn't it possible to patch sources? Please remember that RPM Fusion builders
> will > need to download these data every time you request a build.
> Isn't it feasible to ship git submodules in the following
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4639
--- Comment #5 from Andrea Musuruane ---
Some other comments.
"licenses" is spelled as "licences" in the description. You should use American
spelling and not British spelling:
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Gu
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4639
--- Comment #4 from Andrea Musuruane ---
Hi Ben,
sorry for the late reply.
I have several doubts about how the Source tarball is created.
The first thing is the tarball snapshot I made using your script is different
from the one included i
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4639
--- Comment #3 from Ben Rosser ---
It seems that the cluster providing acm.jhu.edu has ran into some issues. The
spec and SRPM are, for the moment, also available at the following URL.
Spec URL: https://rubble.brosser.net/fedora/dwarffortress/
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4639
--- Comment #2 from Ben Rosser ---
> The build-dfhack-tarball script is not shipped inside the src.rpm file but
> you must provide it.
Whoops. It was always my intention to include it in the dist-git repository but
apparently I missed this det
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4639
Andrea Musuruane changed:
What|Removed |Added
Status|NEW |ASSIGNED
--- Comment #1 from Andrea
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4639
Andrea Musuruane changed:
What|Removed |Added
Blocks|2 |3
Referenced Bugs:
https://bugzill
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4639
Andrea Musuruane changed:
What|Removed |Added
CC||musur...@gmail.com
Assigne
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4639
Ben Rosser changed:
What|Removed |Added
Blocks||2
Referenced Bugs:
https://bugzilla.rpmf
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4639
Bug 4639 depends on bug 3953, which changed state.
Bug 3953 Summary: Review request: dwarffortress - A single-player procedurally
generated fantasy game
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3953
What|Removed
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4639
Ben Rosser changed:
What|Removed |Added
Depends on||3953
Referenced Bugs:
https://bugzilla.r
24 matches
Mail list logo
