Re: [rspec-users] Cucumber Feature Scenario critique

2009-02-20 Thread Michael Latta
I would suggest a different approach to organizing the features. In particular I would recommend the features be used to test implementation invariant aspects of the system. Our features are whole stack sequences that involve views, controllers, and models in almost every case. We test t

Re: [rspec-users] Too Clever?

2008-10-23 Thread Michael Latta
are not, and then have a script that runs the 3 cases? Michael On Oct 23, 2008, at 11:49 AM, Zach Dennis wrote: On Thu, Oct 23, 2008 at 1:20 PM, Michael Latta <[EMAIL PROTECTED]> wrote: It appears we were too clever, but I think this would be a reasonable use of stories. We tried t

[rspec-users] Too Clever?

2008-10-23 Thread Michael Latta
It appears we were too clever, but I think this would be a reasonable use of stories. We tried to have a story file run with 2 different sets of steps to use the same story against both the UI using selenium and against the server API using regular get/put/post. This way we could spec the

Re: [rspec-users] Cucumber: Migrating RSpec Story Listeners to Cucumber

2008-10-14 Thread Michael Latta
Why use a cucumber_scenario method when the After method could just pass it to the block? Michael On Oct 14, 2008, at 1:31 AM, aslak hellesoy wrote: On Tue, Oct 14, 2008 at 9:38 AM, Thomas Marek <[EMAIL PROTECTED]> wrote: No advice on that? Should i open a ticket on Lighthouse? Please

Re: [rspec-users] Associations should be private

2008-10-01 Thread Michael Latta
The point is to never assume the structure of another object, but to let it decide that. So you never get A.B.C you always use a method on A to do the work. You get a lot more methods on A but the structure underneath can change without a ripple effect. For example if you had 2 associati

Re: [rspec-users] Should change not comparing arrays how I expected

2008-09-28 Thread Michael Latta
I think the difference comes down to whether you are writing specs or tests. It is good enough for RSpec or Cucumber to fake out AR proxies if all you are doing is testing something. If it is a spec, then I believe that having the framework fake out the test is very dangerous, because a r

Re: [rspec-users] Should change not comparing arrays how I expected

2008-09-28 Thread Michael Latta
wrote: On Sun, Sep 28, 2008 at 1:44 PM, Michael Latta <[EMAIL PROTECTED]> wrote: Is your patch AR proxy specific? If it is for any collection, it prevents two collections from being compared for equality. I have had many examples of collections that are not simple containers, an

Re: [rspec-users] Should change not comparing arrays how I expected

2008-09-28 Thread Michael Latta
Sun, Sep 28, 2008 at 1:18 PM, Michael Latta <[EMAIL PROTECTED]> wrote: David, It seems to me that the root of the problem is that the specification is incorrect. Since Rails returns association proxies the specification fails because it does not specify what the behavior should be. I

Re: [rspec-users] Should change not comparing arrays how I expected

2008-09-28 Thread Michael Latta
David, It seems to me that the root of the problem is that the specification is incorrect. Since Rails returns association proxies the specification fails because it does not specify what the behavior should be. I would suggest that instead of patching the change matcher, that you shoul

Re: [rspec-users] DRY up story

2008-09-26 Thread Michael Latta
Ticket created http://rspec.lighthouseapp.com/projects/16211-cucumber/tickets/20-ability-to-write-steps-in-scenario-language Michael On Sep 26, 2008, at 5:20 PM, Michael Latta wrote: Using a "macros" directory rather than explicit dependencies (as is now true for steps) is fine.

Re: [rspec-users] DRY up story

2008-09-26 Thread Michael Latta
ners would want to see the details, while most other reviewers would not. I think I will submit a new ticket with what you suggest and what we need from it. Michael On Sep 26, 2008, at 3:57 PM, David Chelimsky wrote: On Fri, Sep 26, 2008 at 1:48 PM, Michael Latta <[EMAIL PROTECTED]&g

Re: [rspec-users] DRY up story

2008-09-26 Thread Michael Latta
oing to really need readable specs for business logic, UI, and so on. What do you think? Michael On Sep 25, 2008, at 8:52 AM, David Chelimsky wrote: On Thu, Sep 25, 2008 at 9:42 AM, Michael Latta <[EMAIL PROTECTED]> wrote: The problem I have with this reasoning is that the point of

Re: [rspec-users] DRY up story

2008-09-25 Thread Michael Latta
The problem I have with this reasoning is that the point of plain text stories is to get more stakeholder involvement. Being able to express shared content in plain text allows the non-programmer reader to verify more details (for example UI interactions within a high level story). I woul

Re: [rspec-users] Shared scenarios?

2008-02-20 Thread Michael Latta
PM, Michael Latta <[EMAIL PROTECTED]> wrote: >> In the story framework I would like to have tests that mix and match >> scenarios using GivenScenario so for example a scenario that does >> scenarios A, B, C in various orders. Right now all scenarios need to >> be self

[rspec-users] Shared scenarios?

2008-02-20 Thread Michael Latta
In the story framework I would like to have tests that mix and match scenarios using GivenScenario so for example a scenario that does scenarios A, B, C in various orders. Right now all scenarios need to be self-standing since all the scenarios in the story get run. I would like scenarios