Re: [rspec-users] Issue with parameterized shared example group on ruby 1.8.6

2010-08-21 Thread Myron Marston
I messed with this some more and implemented the idea I mentioned above: http://github.com/myronmarston/rspec-core/commit/ec3001f290b091fcdab9fb972d9596dd34a91e4e I think this is *definitely* a better implementation of #module_eval_with_args for ruby 1.8.6. It does have the undesirable side effe

Re: [rspec-users] Issue with parameterized shared example group on ruby 1.8.6

2010-08-20 Thread Myron Marston
> 1. Find a better way to fake module_exec on ruby 1.8.6. I'm not sure > if this is even doable. Actually, after thinking about this some more, I think I've come up with a solution that will eliminate the error I'm seeing, but it's not a perfect solution. Let me see if I can explain this well..

Re: [rspec-users] Issue with parameterized shared example group on ruby 1.8.6

2010-08-20 Thread Myron Marston
> 4 makes sense to me iff the code does actually run correctly in all > circumstances, otherwise I'd lean towards 3. Given that ruby blocks are just code, and you can do anything you want in them, and that our faked version of #module_exec runs the block twice...it's easy to conceive of ways of a

Re: [rspec-users] Issue with parameterized shared example group on ruby 1.8.6

2010-08-20 Thread Ashley Moran
On 20 Aug 2010, at 06:40, Myron Marston wrote: > describe VCR::HttpStubbingAdapters::FakeWeb do > it_should_behave_like 'an http stubbing adapter', ['net/http'], > [:method, :uri, :host] > end > > describe VCR::HttpStubbingAdapters::WebMock do > it_should_behave_like 'an http stubbing adapter'

[rspec-users] Issue with parameterized shared example group on ruby 1.8.6

2010-08-19 Thread Myron Marston
I've been refactoring the specs for my VCR gem[1] to take advantage of the new shared example group parameterization. VCR supports both FakeWeb and WebMock, with an appropriate adapter class implemented for each. The adapter classes have nearly identical behavior, except for the differences in th